* [PATCH] e2fsprogs: Escape filenames in populate-extfs.sh
@ 2013-10-28 23:11 Søren Holm
2013-10-28 23:15 ` Søren Holm
2013-11-01 11:11 ` Burton, Ross
0 siblings, 2 replies; 6+ messages in thread
From: Søren Holm @ 2013-10-28 23:11 UTC (permalink / raw)
To: yocto
[YOCTO #5401]
---
.../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
index 9eff030..7de720b 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
@@ -35,7 +35,7 @@ DEBUGFS="debugfs"
fi
# Only stat once since stat is a time consuming command
- STAT=$(stat -c "TYPE=\"%F\";DEVNO=\"0x%t 0x%T\";MODE=\"%f\";U=\"%u\";G=\"%g\"" $FILE)
+ STAT=$(stat -c "TYPE=\"%F\";DEVNO=\"0x%t 0x%T\";MODE=\"%f\";U=\"%u\";G=\"%g\"" "$FILE")
eval $STAT
case $TYPE in
@@ -43,20 +43,20 @@ DEBUGFS="debugfs"
echo "mkdir $TGT"
;;
"regular file" | "regular empty file")
- echo "write $FILE $TGT"
+ echo "write \"$FILE\" \"$TGT\""
;;
"symbolic link")
- LINK_TGT=$(readlink $FILE)
- echo "symlink $TGT $LINK_TGT"
+ LINK_TGT=$(readlink "$FILE")
+ echo "symlink \"$TGT\" \"$LINK_TGT\""
;;
"block special file")
- echo "mknod $TGT b $DEVNO"
+ echo "mknod \"$TGT\" b $DEVNO"
;;
"character special file")
- echo "mknod $TGT c $DEVNO"
+ echo "mknod \"$TGT\" c $DEVNO"
;;
"fifo")
- echo "mknod $TGT p"
+ echo "mknod \"$TGT\" p"
;;
*)
echo "Unknown/unhandled file type '$TYPE' file: $FILE" 1>&2
@@ -64,11 +64,11 @@ DEBUGFS="debugfs"
esac
# Set the file mode
- echo "sif $TGT mode 0x$MODE"
+ echo "sif \"$TGT\" mode 0x$MODE"
# Set uid and gid
- echo "sif $TGT uid $U"
- echo "sif $TGT gid $G"
+ echo "sif \"$TGT\" uid $U"
+ echo "sif \"$TGT\" gid $G"
done
# Handle the hard links.
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] e2fsprogs: Escape filenames in populate-extfs.sh
2013-10-28 23:11 [PATCH] e2fsprogs: Escape filenames in populate-extfs.sh Søren Holm
@ 2013-10-28 23:15 ` Søren Holm
2013-10-28 23:16 ` Søren Holm
2013-11-01 11:11 ` Burton, Ross
1 sibling, 1 reply; 6+ messages in thread
From: Søren Holm @ 2013-10-28 23:15 UTC (permalink / raw)
To: yocto
Hi
I'm reposting my patch as a response tot this message. I forgot adding some
actual description of why the change is necessary. Sorry.
I would like the change to go into dora if possible.
--
Søren Holm
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] e2fsprogs: Escape filenames in populate-extfs.sh
2013-10-28 23:15 ` Søren Holm
@ 2013-10-28 23:16 ` Søren Holm
0 siblings, 0 replies; 6+ messages in thread
From: Søren Holm @ 2013-10-28 23:16 UTC (permalink / raw)
To: yocto
Without this patch filenames containing spaces do not get into the final
ext2/3/4 filsystem.
[YOCTO #5401]
---
.../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
index 9eff030..7de720b 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
@@ -35,7 +35,7 @@ DEBUGFS="debugfs"
fi
# Only stat once since stat is a time consuming command
- STAT=$(stat -c "TYPE=\"%F\";DEVNO=\"0x%t 0x%T\";MODE=\"%f\";U=\"%u\";G=\"%g\"" $FILE)
+ STAT=$(stat -c "TYPE=\"%F\";DEVNO=\"0x%t 0x%T\";MODE=\"%f\";U=\"%u\";G=\"%g\"" "$FILE")
eval $STAT
case $TYPE in
@@ -43,20 +43,20 @@ DEBUGFS="debugfs"
echo "mkdir $TGT"
;;
"regular file" | "regular empty file")
- echo "write $FILE $TGT"
+ echo "write \"$FILE\" \"$TGT\""
;;
"symbolic link")
- LINK_TGT=$(readlink $FILE)
- echo "symlink $TGT $LINK_TGT"
+ LINK_TGT=$(readlink "$FILE")
+ echo "symlink \"$TGT\" \"$LINK_TGT\""
;;
"block special file")
- echo "mknod $TGT b $DEVNO"
+ echo "mknod \"$TGT\" b $DEVNO"
;;
"character special file")
- echo "mknod $TGT c $DEVNO"
+ echo "mknod \"$TGT\" c $DEVNO"
;;
"fifo")
- echo "mknod $TGT p"
+ echo "mknod \"$TGT\" p"
;;
*)
echo "Unknown/unhandled file type '$TYPE' file: $FILE" 1>&2
@@ -64,11 +64,11 @@ DEBUGFS="debugfs"
esac
# Set the file mode
- echo "sif $TGT mode 0x$MODE"
+ echo "sif \"$TGT\" mode 0x$MODE"
# Set uid and gid
- echo "sif $TGT uid $U"
- echo "sif $TGT gid $G"
+ echo "sif \"$TGT\" uid $U"
+ echo "sif \"$TGT\" gid $G"
done
# Handle the hard links.
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] e2fsprogs: Escape filenames in populate-extfs.sh
2013-10-28 23:11 [PATCH] e2fsprogs: Escape filenames in populate-extfs.sh Søren Holm
2013-10-28 23:15 ` Søren Holm
@ 2013-11-01 11:11 ` Burton, Ross
2013-11-01 11:14 ` Søren Holm
1 sibling, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2013-11-01 11:11 UTC (permalink / raw)
To: Søren Holm; +Cc: yocto@yoctoproject.org
Please sent patches to oe-core@.
Ross
On 28 October 2013 23:11, Søren Holm <sgh@sgh.dk> wrote:
> [YOCTO #5401]
> ---
> .../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
> index 9eff030..7de720b 100644
> --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
> @@ -35,7 +35,7 @@ DEBUGFS="debugfs"
> fi
>
> # Only stat once since stat is a time consuming command
> - STAT=$(stat -c "TYPE=\"%F\";DEVNO=\"0x%t 0x%T\";MODE=\"%f\";U=\"%u\";G=\"%g\"" $FILE)
> + STAT=$(stat -c "TYPE=\"%F\";DEVNO=\"0x%t 0x%T\";MODE=\"%f\";U=\"%u\";G=\"%g\"" "$FILE")
> eval $STAT
>
> case $TYPE in
> @@ -43,20 +43,20 @@ DEBUGFS="debugfs"
> echo "mkdir $TGT"
> ;;
> "regular file" | "regular empty file")
> - echo "write $FILE $TGT"
> + echo "write \"$FILE\" \"$TGT\""
> ;;
> "symbolic link")
> - LINK_TGT=$(readlink $FILE)
> - echo "symlink $TGT $LINK_TGT"
> + LINK_TGT=$(readlink "$FILE")
> + echo "symlink \"$TGT\" \"$LINK_TGT\""
> ;;
> "block special file")
> - echo "mknod $TGT b $DEVNO"
> + echo "mknod \"$TGT\" b $DEVNO"
> ;;
> "character special file")
> - echo "mknod $TGT c $DEVNO"
> + echo "mknod \"$TGT\" c $DEVNO"
> ;;
> "fifo")
> - echo "mknod $TGT p"
> + echo "mknod \"$TGT\" p"
> ;;
> *)
> echo "Unknown/unhandled file type '$TYPE' file: $FILE" 1>&2
> @@ -64,11 +64,11 @@ DEBUGFS="debugfs"
> esac
>
> # Set the file mode
> - echo "sif $TGT mode 0x$MODE"
> + echo "sif \"$TGT\" mode 0x$MODE"
>
> # Set uid and gid
> - echo "sif $TGT uid $U"
> - echo "sif $TGT gid $G"
> + echo "sif \"$TGT\" uid $U"
> + echo "sif \"$TGT\" gid $G"
> done
>
> # Handle the hard links.
> --
> 1.8.3.2
>
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] e2fsprogs: Escape filenames in populate-extfs.sh
2013-11-01 11:11 ` Burton, Ross
@ 2013-11-01 11:14 ` Søren Holm
2013-11-01 11:57 ` Burton, Ross
0 siblings, 1 reply; 6+ messages in thread
From: Søren Holm @ 2013-11-01 11:14 UTC (permalink / raw)
To: Burton, Ross; +Cc: yocto@yoctoproject.org
Fredag den 1. november 2013 11:11:52 skrev Burton, Ross:
> Please sent patches to oe-core@.
>
Should patches be sent to oe-core only or should they also be sent to yocto?
--
Søren Holm
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] e2fsprogs: Escape filenames in populate-extfs.sh
2013-11-01 11:14 ` Søren Holm
@ 2013-11-01 11:57 ` Burton, Ross
0 siblings, 0 replies; 6+ messages in thread
From: Burton, Ross @ 2013-11-01 11:57 UTC (permalink / raw)
To: Søren Holm; +Cc: yocto@yoctoproject.org
openembedded-core@lists.openembedded.org only. yocto@ is for community
announcements and user support.
Ross
On 1 November 2013 11:14, Søren Holm <sgh@sgh.dk> wrote:
> Fredag den 1. november 2013 11:11:52 skrev Burton, Ross:
>> Please sent patches to oe-core@.
>>
>
> Should patches be sent to oe-core only or should they also be sent to yocto?
>
> --
> Søren Holm
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-01 11:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-28 23:11 [PATCH] e2fsprogs: Escape filenames in populate-extfs.sh Søren Holm
2013-10-28 23:15 ` Søren Holm
2013-10-28 23:16 ` Søren Holm
2013-11-01 11:11 ` Burton, Ross
2013-11-01 11:14 ` Søren Holm
2013-11-01 11:57 ` Burton, Ross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.