From: "Rojewski, Cezary" <cezary.rojewski@intel.com>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Jie Yang" <yang.jie@linux.intel.com>,
"Takashi Iwai" <tiwai@suse.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Joe Perches" <joe@perches.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/8] ASoC: Intel: bytcr_rt5651: use semicolons rather than commas to separate statements
Date: Mon, 12 Oct 2020 07:14:54 +0000 [thread overview]
Message-ID: <225ad3480553428bbf50e34322c8688a@intel.com> (raw)
In-Reply-To: <1602407979-29038-4-git-send-email-Julia.Lawall@inria.fr>
On 2020-10-11 11:19 AM, Julia Lawall wrote:
> Replace commas with semicolons. What is done is essentially described by
> the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
>
> // <smpl>
> @@ expression e1,e2; @@
> e1
> -,
> +;
> e2
> ... when any
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
Thanks,
Czarek
> ---
> sound/soc/intel/boards/bytcr_rt5651.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards/bytcr_rt5651.c
> index 688b5e0a49e3..64d3fc4a3225 100644
> --- a/sound/soc/intel/boards/bytcr_rt5651.c
> +++ b/sound/soc/intel/boards/bytcr_rt5651.c
> @@ -143,7 +143,7 @@ static int byt_rt5651_prepare_and_enable_pll1(struct snd_soc_dai *codec_dai,
>
> /* Configure the PLL before selecting it */
> if (!(byt_rt5651_quirk & BYT_RT5651_MCLK_EN)) {
> - clk_id = RT5651_PLL1_S_BCLK1,
> + clk_id = RT5651_PLL1_S_BCLK1;
> clk_freq = rate * bclk_ratio;
> } else {
> clk_id = RT5651_PLL1_S_MCLK;
>
WARNING: multiple messages have this Message-ID (diff)
From: "Rojewski, Cezary" <cezary.rojewski@intel.com>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Joe Perches" <joe@perches.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
"Jie Yang" <yang.jie@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/8] ASoC: Intel: bytcr_rt5651: use semicolons rather than commas to separate statements
Date: Mon, 12 Oct 2020 07:14:54 +0000 [thread overview]
Message-ID: <225ad3480553428bbf50e34322c8688a@intel.com> (raw)
In-Reply-To: <1602407979-29038-4-git-send-email-Julia.Lawall@inria.fr>
On 2020-10-11 11:19 AM, Julia Lawall wrote:
> Replace commas with semicolons. What is done is essentially described by
> the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
>
> // <smpl>
> @@ expression e1,e2; @@
> e1
> -,
> +;
> e2
> ... when any
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
Thanks,
Czarek
> ---
> sound/soc/intel/boards/bytcr_rt5651.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards/bytcr_rt5651.c
> index 688b5e0a49e3..64d3fc4a3225 100644
> --- a/sound/soc/intel/boards/bytcr_rt5651.c
> +++ b/sound/soc/intel/boards/bytcr_rt5651.c
> @@ -143,7 +143,7 @@ static int byt_rt5651_prepare_and_enable_pll1(struct snd_soc_dai *codec_dai,
>
> /* Configure the PLL before selecting it */
> if (!(byt_rt5651_quirk & BYT_RT5651_MCLK_EN)) {
> - clk_id = RT5651_PLL1_S_BCLK1,
> + clk_id = RT5651_PLL1_S_BCLK1;
> clk_freq = rate * bclk_ratio;
> } else {
> clk_id = RT5651_PLL1_S_MCLK;
>
next prev parent reply other threads:[~2020-10-12 7:16 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 9:19 [PATCH 0/8] use semicolons rather than commas to separate statements Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-11 9:19 ` [PATCH 1/8] ASoC: wm8350: " Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-12 9:26 ` Charles Keepax
2020-10-12 9:26 ` Charles Keepax
2020-10-11 9:19 ` [PATCH 2/8] ALSA: hda: " Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-12 6:52 ` Takashi Iwai
2020-10-12 6:52 ` Takashi Iwai
2020-10-12 6:52 ` Takashi Iwai
2020-10-11 9:19 ` [PATCH 3/8] ASoC: Intel: bytcr_rt5651: " Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-12 7:14 ` Rojewski, Cezary [this message]
2020-10-12 7:14 ` Rojewski, Cezary
2020-10-11 9:19 ` [PATCH 4/8] ALSA: fireworks: " Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-11 11:32 ` Takashi Sakamoto
2020-10-11 11:32 ` Takashi Sakamoto
2020-10-11 11:32 ` Takashi Sakamoto
2020-10-12 6:53 ` Takashi Iwai
2020-10-12 6:53 ` Takashi Iwai
2020-10-12 6:53 ` Takashi Iwai
2020-10-11 9:19 ` [PATCH 5/8] ASoC: SOF: Intel: hda: " Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-11 9:19 ` [PATCH 6/8] ASoC: samsung: snow: " Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-12 7:12 ` Krzysztof Kozlowski
2020-10-12 7:12 ` Krzysztof Kozlowski
2020-10-12 7:12 ` Krzysztof Kozlowski
2020-10-11 9:19 ` [PATCH 7/8] ASoC: madera: " Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-12 9:26 ` Charles Keepax
2020-10-12 9:26 ` Charles Keepax
2020-10-11 9:19 ` [PATCH 8/8] ASoC: dapm: " Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-11 9:19 ` Julia Lawall
2020-10-26 23:45 ` [PATCH 0/8] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=225ad3480553428bbf50e34322c8688a@intel.com \
--to=cezary.rojewski@intel.com \
--cc=Julia.Lawall@inria.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=valdis.kletnieks@vt.edu \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.