[Qemu-devel] target i386 compile problem for hw/core/nmi.c

[Qemu-devel] target i386 compile problem for hw/core/nmi.c

[Tim Sander]

Hi

We are trying to call "inject_nmi" from a device on a x386 target. 
Unfortunatly it gets called with the wrong defines and the define
TARGET_I386 is *not* defined. If we define TARGET_I386 for testing 
the code in the defines fails to compile.

Trying to fix this by including:
"qom/cpu.h" and "target-i386/qom-cpu.h" leads to 
target-i386/cpu-qom.h:24
hw/core/nmi.c:27:
include/config.h:2:27: fatal error: config-target.h: No such file or directory
compilation terminated.

There is literally the same code in the function qmp_inject_nmi which has the 
right defines and works from command line.

The question is what needs to be done that inject_nmi gets compiled for the 
right context (configure --target-list=softmmu-i386) with the TARGET_I386 define 
enabled?

Best regards
Tim

Re: [Qemu-devel] target i386 compile problem for hw/core/nmi.c

[Peter Maydell]

On 27 November 2015 at 15:03, Tim Sander <tim@krieglstein.org> wrote:
> We are trying to call "inject_nmi" from a device on a x386 target.
> Unfortunatly it gets called with the wrong defines and the define
> TARGET_I386 is *not* defined. If we define TARGET_I386 for testing
> the code in the defines fails to compile.
>
> Trying to fix this by including:
> "qom/cpu.h" and "target-i386/qom-cpu.h" leads to
> target-i386/cpu-qom.h:24
> hw/core/nmi.c:27:
> include/config.h:2:27: fatal error: config-target.h: No such file or directory
> compilation terminated.
>
> There is literally the same code in the function qmp_inject_nmi which has the
> right defines and works from command line.
>
> The question is what needs to be done that inject_nmi gets compiled for the
> right context (configure --target-list=softmmu-i386) with the TARGET_I386 define
> enabled?

The problem here is that nmi.o is listed in common-obj-y in
hw/core/Makefile.objs, which means it is built only once and must
not have any code which is built differently for different targets.
Either the code needs to be changed not to have the target-dependency,
or the file should be put in obj-y instead of common-obj-y.

thanks
-- PMM