Re: [PATCH] kni: optimizing the rte_kni_rx_burst

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

2014-11-26 22:20, Thomas Monjalon:
> Ping
> 
> 2014-11-11 23:58, Thomas Monjalon:
> > Is there anyone interested in KNI to review this patch please?
> > 
> > 
> > 2014-07-23 12:15, Hemant Agrawal:
> > > The current implementation of rte_kni_rx_burst polls the fifo for buffers.
> > > Irrespective of success or failure, it allocates the mbuf and try to put them into the alloc_q
> > > if the buffers are not added to alloc_q, it frees them.
> > > This waste lots of cpu cycles in allocating and freeing the buffers if alloc_q is full.
> > > 
> > > The logic has been changed to:
> > > 1. Initially allocand add buffer(burstsize) to alloc_q
> > > 2. Add buffers to alloc_q only when you are pulling out the buffers.
> > > 
> > > Signed-off-by: Hemant Agrawal <Hemant-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

>From http://dpdk.org/ml/archives/dev/2015-January/011771.html, Jay said
"The patch looks good from a DPDK 1.6r2 viewpoint. We saw the same behavior
in our app and ended up avoiding it higher in the stack (in our code)."
Reviewed-by: Jay Rolette <rolette-bIuJOMs36aleGPcbtGPokg@public.gmane.org>

-- 
Thomas