From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Hemant Agrawal <Hemant-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] kni: optimizing the rte_kni_rx_burst
Date: Tue, 24 Feb 2015 02:29:14 +0100 [thread overview]
Message-ID: <7915859.T53PE4ELEn@xps13> (raw)
In-Reply-To: <2263080.JfiolkiDdp@xps13>
> > > 2014-07-23 12:15, Hemant Agrawal:
> > > > The current implementation of rte_kni_rx_burst polls the fifo for buffers.
> > > > Irrespective of success or failure, it allocates the mbuf and try to put them into the alloc_q
> > > > if the buffers are not added to alloc_q, it frees them.
> > > > This waste lots of cpu cycles in allocating and freeing the buffers if alloc_q is full.
> > > >
> > > > The logic has been changed to:
> > > > 1. Initially allocand add buffer(burstsize) to alloc_q
> > > > 2. Add buffers to alloc_q only when you are pulling out the buffers.
> > > >
> > > > Signed-off-by: Hemant Agrawal <Hemant-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> From http://dpdk.org/ml/archives/dev/2015-January/011771.html, Jay said
> "The patch looks good from a DPDK 1.6r2 viewpoint. We saw the same behavior
> in our app and ended up avoiding it higher in the stack (in our code)."
> Reviewed-by: Jay Rolette <rolette-bIuJOMs36aleGPcbtGPokg@public.gmane.org>
Applied, thanks
prev parent reply other threads:[~2015-02-24 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 6:45 [PATCH] kni: optimizing the rte_kni_rx_burst Hemant Agrawal
[not found] ` <14060979121185-git-send-email-Hemant-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-11-11 22:58 ` Thomas Monjalon
2014-11-26 21:20 ` Thomas Monjalon
2015-01-30 9:59 ` Thomas Monjalon
2015-02-24 1:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7915859.T53PE4ELEn@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=Hemant-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.