From: Heiko Stuebner <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
Geraldo Nascimento <geraldogabriel@gmail.com>
Cc: "Shawn Lin" <shawn.lin@rock-chips.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
linux-phy@lists.infradead.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] Quality Improvements for Rockchip-IP PCIe
Date: Mon, 09 Jun 2025 10:50:45 +0200 [thread overview]
Message-ID: <2266650.atdPhlSkOF@phil> (raw)
In-Reply-To: <aEQbx0Qu-2UKhV1y@geday>
Hi Geraldo,
Am Samstag, 7. Juni 2025, 13:00:23 Mitteleuropäische Sommerzeit schrieb Geraldo Nascimento:
> During a 30-day debugging-run fighting quirky PCIe devices on RK3399
> some quality improvements began to take form and this is my attempt
> at upstreaming it. It will ensure maximum chance of retraining to Gen2
> 5.0GT/s, on all four lanes and plus if anybody is debugging the PHY
> they'll now get real values from TEST_I[3:0] for every TEST_ADDR[4:0]
> without risk of locking up kernel like with present broken async
> strobe TEST_WRITE.
could you check your settings for sending patches please?
The individual patches of this series did not get "in-reply-to" headers
that would point to this cover-letter. Instead each mail of this
series stands on its own, preventing mail clients from creating a
threaded display of the series.
git-send-email normally does create these needed headers on its own,
so could you check if you have some option enabled that prevents this?
Thanks a lot
Heiko
>
> Geraldo Nascimento (4):
> PCI: pcie-rockchip: add bits for Target Link Speed in LCS_2
> PCI: rockchip-host: Set Target Link Speed before retraining
> phy: rockchip-pcie: enable all four lanes
> phy: rockchip-pcie: adjust read mask and write strobe disable
>
> drivers/pci/controller/pcie-rockchip-host.c | 4 ++++
> drivers/pci/controller/pcie-rockchip.h | 3 +++
> drivers/phy/rockchip/phy-rockchip-pcie.c | 16 +++++++++-------
> 3 files changed, 16 insertions(+), 7 deletions(-)
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
Geraldo Nascimento <geraldogabriel@gmail.com>
Cc: "Shawn Lin" <shawn.lin@rock-chips.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
linux-phy@lists.infradead.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] Quality Improvements for Rockchip-IP PCIe
Date: Mon, 09 Jun 2025 10:50:45 +0200 [thread overview]
Message-ID: <2266650.atdPhlSkOF@phil> (raw)
In-Reply-To: <aEQbx0Qu-2UKhV1y@geday>
Hi Geraldo,
Am Samstag, 7. Juni 2025, 13:00:23 Mitteleuropäische Sommerzeit schrieb Geraldo Nascimento:
> During a 30-day debugging-run fighting quirky PCIe devices on RK3399
> some quality improvements began to take form and this is my attempt
> at upstreaming it. It will ensure maximum chance of retraining to Gen2
> 5.0GT/s, on all four lanes and plus if anybody is debugging the PHY
> they'll now get real values from TEST_I[3:0] for every TEST_ADDR[4:0]
> without risk of locking up kernel like with present broken async
> strobe TEST_WRITE.
could you check your settings for sending patches please?
The individual patches of this series did not get "in-reply-to" headers
that would point to this cover-letter. Instead each mail of this
series stands on its own, preventing mail clients from creating a
threaded display of the series.
git-send-email normally does create these needed headers on its own,
so could you check if you have some option enabled that prevents this?
Thanks a lot
Heiko
>
> Geraldo Nascimento (4):
> PCI: pcie-rockchip: add bits for Target Link Speed in LCS_2
> PCI: rockchip-host: Set Target Link Speed before retraining
> phy: rockchip-pcie: enable all four lanes
> phy: rockchip-pcie: adjust read mask and write strobe disable
>
> drivers/pci/controller/pcie-rockchip-host.c | 4 ++++
> drivers/pci/controller/pcie-rockchip.h | 3 +++
> drivers/phy/rockchip/phy-rockchip-pcie.c | 16 +++++++++-------
> 3 files changed, 16 insertions(+), 7 deletions(-)
>
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
Geraldo Nascimento <geraldogabriel@gmail.com>
Cc: "Shawn Lin" <shawn.lin@rock-chips.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
linux-phy@lists.infradead.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] Quality Improvements for Rockchip-IP PCIe
Date: Mon, 09 Jun 2025 10:50:45 +0200 [thread overview]
Message-ID: <2266650.atdPhlSkOF@phil> (raw)
In-Reply-To: <aEQbx0Qu-2UKhV1y@geday>
Hi Geraldo,
Am Samstag, 7. Juni 2025, 13:00:23 Mitteleuropäische Sommerzeit schrieb Geraldo Nascimento:
> During a 30-day debugging-run fighting quirky PCIe devices on RK3399
> some quality improvements began to take form and this is my attempt
> at upstreaming it. It will ensure maximum chance of retraining to Gen2
> 5.0GT/s, on all four lanes and plus if anybody is debugging the PHY
> they'll now get real values from TEST_I[3:0] for every TEST_ADDR[4:0]
> without risk of locking up kernel like with present broken async
> strobe TEST_WRITE.
could you check your settings for sending patches please?
The individual patches of this series did not get "in-reply-to" headers
that would point to this cover-letter. Instead each mail of this
series stands on its own, preventing mail clients from creating a
threaded display of the series.
git-send-email normally does create these needed headers on its own,
so could you check if you have some option enabled that prevents this?
Thanks a lot
Heiko
>
> Geraldo Nascimento (4):
> PCI: pcie-rockchip: add bits for Target Link Speed in LCS_2
> PCI: rockchip-host: Set Target Link Speed before retraining
> phy: rockchip-pcie: enable all four lanes
> phy: rockchip-pcie: adjust read mask and write strobe disable
>
> drivers/pci/controller/pcie-rockchip-host.c | 4 ++++
> drivers/pci/controller/pcie-rockchip.h | 3 +++
> drivers/phy/rockchip/phy-rockchip-pcie.c | 16 +++++++++-------
> 3 files changed, 16 insertions(+), 7 deletions(-)
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-06-09 8:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-07 11:00 [RFC PATCH 0/4] Quality Improvements for Rockchip-IP PCIe Geraldo Nascimento
2025-06-07 11:00 ` Geraldo Nascimento
2025-06-07 11:00 ` Geraldo Nascimento
2025-06-09 8:50 ` Heiko Stuebner [this message]
2025-06-09 8:50 ` Heiko Stuebner
2025-06-09 8:50 ` Heiko Stuebner
2025-06-09 12:51 ` Geraldo Nascimento
2025-06-09 12:51 ` Geraldo Nascimento
2025-06-09 12:51 ` Geraldo Nascimento
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2266650.atdPhlSkOF@phil \
--to=heiko@sntech.de \
--cc=bhelgaas@google.com \
--cc=geraldogabriel@gmail.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.