All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Chris Morgan <macromorgan@hotmail.com>,
	Jonas Karlman <jonas@kwiboo.se>, Tim Lunn <tim@feathertop.org>,
	Andy Yan <andyshrk@163.com>,
	Muhammed Efe Cetin <efectn@protonmail.com>,
	Jagan Teki <jagan@edgeble.ai>, Dragan Simic <dsimic@manjaro.org>,
	Ondrej Jirman <megi@xff.cz>, Yao Zi <ziyao@disroot.org>
Cc: Celeste Liu <CoelacanthusHex@gmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 3/4] arm64: dts: rockchip: Add base DT for rk3528 SoC
Date: Fri, 16 Aug 2024 08:45:53 +0200	[thread overview]
Message-ID: <22683755.GTVRSBfYgM@diego> (raw)
In-Reply-To: <Zr7z-SOFIgcuplq-@ziyaolaptop.my.domain>

Am Freitag, 16. August 2024, 08:39:38 CEST schrieb Yao Zi:
> On Thu, Aug 15, 2024 at 06:43:20PM +0200, Heiko Stübner wrote:
> > Hi,
> > 
> > Am Mittwoch, 14. August 2024, 17:50:13 CEST schrieb Yao Zi:
> > > This initial device tree describes CPU, interrupts and UART on the chip
> > > and is able to boot into basic kernel with only UART. Cache information
> > > is omitted for now as there is no precise documentation. Support for
> > > other features will be added later.
> > > 
> > > Signed-off-by: Yao Zi <ziyao@disroot.org>
> > 
> > not sure if you have seen Krzysztof's comment yesterday, that he found
> > the soc node getting documented in 2019 [0].
> 
> Oops, I don't read that before sending the series.

no worries, I think both mails (the linked on and your v3) happened at 
nearly the same time on wednesday.


> > I guess that counts as a strong suggestion. Not sure how you're feeling
> > about that, but I guess we could move to that scheme for new socs.
> > 
> > So would you be willing to move the mmio-devices to a soc node?
> > (stuff with mmio addresses in the node name)
> 
> I'm willing to, there will be patch v4.

thanks a lot :-)

Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Chris Morgan <macromorgan@hotmail.com>,
	Jonas Karlman <jonas@kwiboo.se>, Tim Lunn <tim@feathertop.org>,
	Andy Yan <andyshrk@163.com>,
	Muhammed Efe Cetin <efectn@protonmail.com>,
	Jagan Teki <jagan@edgeble.ai>, Dragan Simic <dsimic@manjaro.org>,
	Ondrej Jirman <megi@xff.cz>, Yao Zi <ziyao@disroot.org>
Cc: Celeste Liu <CoelacanthusHex@gmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH v3 3/4] arm64: dts: rockchip: Add base DT for rk3528 SoC
Date: Fri, 16 Aug 2024 08:45:53 +0200	[thread overview]
Message-ID: <22683755.GTVRSBfYgM@diego> (raw)
In-Reply-To: <Zr7z-SOFIgcuplq-@ziyaolaptop.my.domain>

Am Freitag, 16. August 2024, 08:39:38 CEST schrieb Yao Zi:
> On Thu, Aug 15, 2024 at 06:43:20PM +0200, Heiko Stübner wrote:
> > Hi,
> > 
> > Am Mittwoch, 14. August 2024, 17:50:13 CEST schrieb Yao Zi:
> > > This initial device tree describes CPU, interrupts and UART on the chip
> > > and is able to boot into basic kernel with only UART. Cache information
> > > is omitted for now as there is no precise documentation. Support for
> > > other features will be added later.
> > > 
> > > Signed-off-by: Yao Zi <ziyao@disroot.org>
> > 
> > not sure if you have seen Krzysztof's comment yesterday, that he found
> > the soc node getting documented in 2019 [0].
> 
> Oops, I don't read that before sending the series.

no worries, I think both mails (the linked on and your v3) happened at 
nearly the same time on wednesday.


> > I guess that counts as a strong suggestion. Not sure how you're feeling
> > about that, but I guess we could move to that scheme for new socs.
> > 
> > So would you be willing to move the mmio-devices to a soc node?
> > (stuff with mmio addresses in the node name)
> 
> I'm willing to, there will be patch v4.

thanks a lot :-)

Heiko



  reply	other threads:[~2024-08-16  6:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 15:50 [PATCH v3 0/4] Add initial support for Rockchip RK3528 SoC Yao Zi
2024-08-14 15:50 ` Yao Zi
2024-08-14 15:50 ` [PATCH v3 1/4] dt-bindings: serial: snps-dw-apb-uart: Document Rockchip RK3528 Yao Zi
2024-08-14 15:50   ` Yao Zi
2024-08-14 15:50 ` [PATCH v3 2/4] dt-bindings: arm: rockchip: Add Radxa E20C board Yao Zi
2024-08-14 15:50   ` Yao Zi
2024-08-14 15:50 ` [PATCH v3 3/4] arm64: dts: rockchip: Add base DT for rk3528 SoC Yao Zi
2024-08-14 15:50   ` Yao Zi
2024-08-15 16:43   ` Heiko Stübner
2024-08-15 16:43     ` Heiko Stübner
2024-08-16  6:39     ` Yao Zi
2024-08-16  6:39       ` Yao Zi
2024-08-16  6:45       ` Heiko Stübner [this message]
2024-08-16  6:45         ` Heiko Stübner
2024-08-14 15:50 ` [PATCH v3 4/4] arm64: dts: rockchip: Add Radxa e20c board Yao Zi
2024-08-14 15:50   ` Yao Zi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22683755.GTVRSBfYgM@diego \
    --to=heiko@sntech.de \
    --cc=CoelacanthusHex@gmail.com \
    --cc=andyshrk@163.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dsimic@manjaro.org \
    --cc=efectn@protonmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jagan@edgeble.ai \
    --cc=jirislaby@kernel.org \
    --cc=jonas@kwiboo.se \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=macromorgan@hotmail.com \
    --cc=megi@xff.cz \
    --cc=robh@kernel.org \
    --cc=tim@feathertop.org \
    --cc=ziyao@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.