All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@sigma-star.at>
To: Richard Weinberger <richard@nod.at>,
	xenomai@lists.linux.dev, upstream+xenomai@sigma-star.at,
	Florian Bezdeka <florian.bezdeka@siemens.com>
Subject: Re: [PATCH 03/16] prepare-kernel.sh: Convert to tabs
Date: Mon, 27 May 2024 10:14:39 +0200	[thread overview]
Message-ID: <2274162.2U7a3VyTpS@somecomputer> (raw)
In-Reply-To: <4236b09da042f9bfb766707a95dd60f229b69a51.camel@siemens.com>

Florian,

Am Montag, 27. Mai 2024, 09:19:44 CEST schrieb 'Florian Bezdeka' via upstream:
> Hi Richard!
> 
> On Sat, 2024-05-25 at 13:57 +0200, Richard Weinberger wrote:
> >  patch_reverse() {
> > -    file="$1"
> > -    if test "x$output_patch" = "x"; then
> > -        if test -L "$linux_tree/$file" ; then
> > -            rm "$linux_tree/$file"
> > -        fi
> > -        mv "$linux_tree/$file.orig" "$linux_tree/$file"
> > -    fi
> > +	file="$1"
> > +	if test "x$output_patch" = "x"; then
> > +		if test -L "$linux_tree/$file" ; then
> > +			rm "$linux_tree/$file"
> > +		fi
> > +		mv "$linux_tree/$file.orig" "$linux_tree/$file"
> > +	fi
> >  }
> >  
> 
> This part is introduced in patch 1 and completely rewritten in this
> patch (patch 3).
> 
> We could avoid that by applying patch 3 fist, so basically reordering
> the patches so that patch 3 becomes the first one. Could help if
> someone has to bisect later...

How does it hurt bisecing beside of adding an extra step?
But sure, I can reorder.
So, I assume you're fine with tabs? :-)

Thanks,
//richard

-- 
​​​​​sigma star gmbh | Eduard-Bodem-Gasse 6, 6020 Innsbruck, AUT
UID/VAT Nr: ATU 66964118 | FN: 374287y



  parent reply	other threads:[~2024-05-27  8:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-25 11:57 [PATCH 00/16] Assorted Cleanups For prepare-kernel.sh Richard Weinberger
2024-05-25 11:57 ` [PATCH 01/16] prepare-kernel.sh: Add reverse mode Richard Weinberger
2024-05-25 11:57 ` [PATCH 02/16] prepare-kernel.sh: Emit architecture agnostic changes Richard Weinberger
2024-05-25 11:57 ` [PATCH 03/16] prepare-kernel.sh: Convert to tabs Richard Weinberger
2024-05-27  7:19   ` Florian Bezdeka
2024-05-27  7:27     ` Jan Kiszka
2024-05-27  8:14     ` Richard Weinberger [this message]
2024-05-25 11:57 ` [PATCH 04/16] prepare-kernel.sh: Improve kernel tree check Richard Weinberger
2024-05-27 10:51   ` Jan Kiszka
2024-05-27 15:42     ` Richard Weinberger
2024-05-25 11:57 ` [PATCH 05/16] prepare-kernel.sh: Fix shellcheck SC2046 warnings wrt. check_filter Richard Weinberger
2024-05-27 10:52   ` Jan Kiszka
2024-05-25 11:57 ` [PATCH 06/16] prepare-kernel.sh: Disable SC2115 warning around $linux_tree Richard Weinberger
2024-05-25 11:57 ` [PATCH 07/16] prepare-kernel.sh: Don't use eval Richard Weinberger
2024-05-25 11:57 ` [PATCH 08/16] prepare-kernel.sh: Don't depend on bash Richard Weinberger
2024-05-27 10:56   ` Jan Kiszka
2024-05-27 16:00     ` Richard Weinberger
2024-05-27 16:02       ` Jan Kiszka
2024-05-25 11:57 ` [PATCH 09/16] prepare-kernel.sh: Remove --filterkvers= and --filterarch= Richard Weinberger
2024-05-25 11:58 ` [PATCH 10/16] prepare-kernel.sh: Remove interactivity Richard Weinberger
2024-05-25 11:58 ` [PATCH 11/16] prepare-kernel.sh: Remove --forcelink Richard Weinberger
2024-05-25 11:58 ` [PATCH 12/16] prepare-kernel.sh: Fix dovetail check Richard Weinberger
2024-05-25 11:58 ` [PATCH 13/16] prepare-kernel.sh: Define command line variables Richard Weinberger
2024-05-25 11:58 ` [PATCH 14/16] prepare-kernel.sh: Remove dead code Richard Weinberger
2024-05-25 11:58 ` [PATCH 15/16] prepare-kernel.sh: Don't allow uninitialized variables Richard Weinberger
2024-05-25 11:58 ` [PATCH 16/16] prepare-kernel.sh: Remove kernel version check Richard Weinberger
2024-05-27 11:06   ` Jan Kiszka
2024-06-21 14:42 ` [PATCH 00/16] Assorted Cleanups For prepare-kernel.sh Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2274162.2U7a3VyTpS@somecomputer \
    --to=richard@sigma-star.at \
    --cc=florian.bezdeka@siemens.com \
    --cc=richard@nod.at \
    --cc=upstream+xenomai@sigma-star.at \
    --cc=xenomai@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.