Re: [PATCH 04/16] prepare-kernel.sh: Improve kernel tree check

[Richard Weinberger <richard@nod.at>]

----- Ursprüngliche Mail -----
>> diff --git a/scripts/prepare-kernel.sh b/scripts/prepare-kernel.sh
>> index 534531e2b..800528058 100755
>> --- a/scripts/prepare-kernel.sh
>> +++ b/scripts/prepare-kernel.sh
>> @@ -237,7 +237,7 @@ done
>>  
>>  linux_tree=`cd $linux_tree && pwd`
>>  
>> -if test \! -r $linux_tree/Makefile; then
>> +if test \! -r $linux_tree/kernel/kallsyms.c; then
> 
> Fine with checking for a real kernel, but this here is not my favorite
> method. How about
> 
> test "$(head -1 README)" = "Linux kernel"
> 
> instead?

My idea was that kernel/kallsyms.c is an old file which is unlikely to
get renamed soon.

It came via:
commit e42f617ecdfc68e68b0108cd337d30224b541352
Author: Ingo Molnar <mingo@elte.hu>
Date:   Thu Sep 26 03:31:07 2002 -0700

    [PATCH] kksymoops-2.5.38-C9
    
    Make the kernel print out symbolic bactraces if symbol table information
    is available (CONFIG_KALLSYMS)

and was never renamed since.

README, one other hand, saw more changes.
In it's current form it looks more stable, though.

So, I don't have a strong opinion on this.

Thanks,
//richard