All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: stable@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	dev@dpdk.org, stephen@networkplumber.org,
	pablo.de.lara.guarch@intel.com
Subject: Re: [dpdk-stable] [PATCH v2] kni: fix build with gcc 8.1
Date: Tue, 26 Jun 2018 11:54:47 +0200	[thread overview]
Message-ID: <22836779.FGhLq8pQDX@xps> (raw)
In-Reply-To: <07e4d536-edd6-292d-5adb-c05793731623@intel.com>

26/06/2018 11:02, Ferruh Yigit:
> --- a/kernel/linux/kni/ethtool/igb/igb_ethtool.c
> +++ b/kernel/linux/kni/ethtool/igb/igb_ethtool.c
> @@ -811,9 +811,10 @@ static void igb_get_drvinfo(struct net_device *netdev,
>  	strncpy(drvinfo->driver,  igb_driver_name, sizeof(drvinfo->driver) - 1);
>  	strncpy(drvinfo->version, igb_driver_version, sizeof(drvinfo->version) - 1);
>  -	strncpy(drvinfo->fw_version, adapter->fw_version,
> -		sizeof(drvinfo->fw_version) - 1);

There is a leading space before the minus of first line.

  reply	other threads:[~2018-06-26  9:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19 12:08 [PATCH] kni: fix build with gcc 8.1 Ferruh Yigit
2018-06-19 23:35 ` Stephen Hemminger
2018-06-20 16:39   ` Ferruh Yigit
2018-06-20 17:04     ` Ferruh Yigit
2018-06-20  9:01 ` [dpdk-stable] " De Lara Guarch, Pablo
2018-06-20 16:40   ` Ferruh Yigit
2018-06-26  9:02 ` [PATCH v2] " Ferruh Yigit
2018-06-26  9:54   ` Thomas Monjalon [this message]
2018-06-26 11:38   ` [PATCH v3] " Ferruh Yigit
2018-06-26 13:43     ` De Lara Guarch, Pablo
2018-06-27 13:15       ` [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22836779.FGhLq8pQDX@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.