* [PATCH] powerpc: pseries: Fix kexec on machines with more than 4TB of RAM
@ 2011-07-27 4:15 ` Anton Blanchard
0 siblings, 0 replies; 4+ messages in thread
From: Anton Blanchard @ 2011-07-27 4:15 UTC (permalink / raw)
To: benh, paulus, mikey, miltonm; +Cc: kexec, linuxppc-dev
On a box with 8TB of RAM the MMU hashtable is 64GB in size. That
means we have 4G PTEs. pSeries_lpar_hptab_clear was using a signed
int to store the index which will overflow at 2G.
Signed-off-by: Anton Blanchard <anton@samba.org>
Cc: <stable@kernel.org>
---
Index: linux-powerpc/arch/powerpc/platforms/pseries/lpar.c
===================================================================
--- linux-powerpc.orig/arch/powerpc/platforms/pseries/lpar.c 2011-07-27 13:50:18.408091576 +1000
+++ linux-powerpc/arch/powerpc/platforms/pseries/lpar.c 2011-07-27 13:51:19.359196131 +1000
@@ -203,7 +203,7 @@ static void pSeries_lpar_hptab_clear(voi
unsigned long ptel;
} ptes[4];
long lpar_rc;
- int i, j;
+ unsigned long i, j;
/* Read in batches of 4,
* invalidate only valid entries not in the VRMA
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] powerpc: pseries: Fix kexec on machines with more than 4TB of RAM
@ 2011-07-27 4:15 ` Anton Blanchard
0 siblings, 0 replies; 4+ messages in thread
From: Anton Blanchard @ 2011-07-27 4:15 UTC (permalink / raw)
To: benh, paulus, mikey, miltonm; +Cc: kexec, linuxppc-dev
On a box with 8TB of RAM the MMU hashtable is 64GB in size. That
means we have 4G PTEs. pSeries_lpar_hptab_clear was using a signed
int to store the index which will overflow at 2G.
Signed-off-by: Anton Blanchard <anton@samba.org>
Cc: <stable@kernel.org>
---
Index: linux-powerpc/arch/powerpc/platforms/pseries/lpar.c
===================================================================
--- linux-powerpc.orig/arch/powerpc/platforms/pseries/lpar.c 2011-07-27 13:50:18.408091576 +1000
+++ linux-powerpc/arch/powerpc/platforms/pseries/lpar.c 2011-07-27 13:51:19.359196131 +1000
@@ -203,7 +203,7 @@ static void pSeries_lpar_hptab_clear(voi
unsigned long ptel;
} ptes[4];
long lpar_rc;
- int i, j;
+ unsigned long i, j;
/* Read in batches of 4,
* invalidate only valid entries not in the VRMA
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: pseries: Fix kexec on machines with more than 4TB of RAM
2011-07-27 4:15 ` Anton Blanchard
@ 2011-07-27 4:26 ` Michael Neuling
-1 siblings, 0 replies; 4+ messages in thread
From: Michael Neuling @ 2011-07-27 4:26 UTC (permalink / raw)
To: Anton Blanchard; +Cc: benh, paulus, linuxppc-dev, miltonm, kexec
> On a box with 8TB of RAM the MMU hashtable is 64GB in size. That
> means we have 4G PTEs. pSeries_lpar_hptab_clear was using a signed
> int to store the index which will overflow at 2G.
Wow, I hear... "Anton Blanchard's machine has more memory in it's MMU
than you have in total".
Acked-by: Michael Neuling <mikey@neuling.org>
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> Cc: <stable@kernel.org>
> ---
>
> Index: linux-powerpc/arch/powerpc/platforms/pseries/lpar.c
> ===================================================================
> --- linux-powerpc.orig/arch/powerpc/platforms/pseries/lpar.c 2011-07-27 13:5
0:18.408091576 +1000
> +++ linux-powerpc/arch/powerpc/platforms/pseries/lpar.c 2011-07-27 13:5
1:19.359196131 +1000
> @@ -203,7 +203,7 @@ static void pSeries_lpar_hptab_clear(voi
> unsigned long ptel;
> } ptes[4];
> long lpar_rc;
> - int i, j;
> + unsigned long i, j;
>
> /* Read in batches of 4,
> * invalidate only valid entries not in the VRMA
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc: pseries: Fix kexec on machines with more than 4TB of RAM
@ 2011-07-27 4:26 ` Michael Neuling
0 siblings, 0 replies; 4+ messages in thread
From: Michael Neuling @ 2011-07-27 4:26 UTC (permalink / raw)
To: Anton Blanchard; +Cc: paulus, linuxppc-dev, miltonm, kexec
> On a box with 8TB of RAM the MMU hashtable is 64GB in size. That
> means we have 4G PTEs. pSeries_lpar_hptab_clear was using a signed
> int to store the index which will overflow at 2G.
Wow, I hear... "Anton Blanchard's machine has more memory in it's MMU
than you have in total".
Acked-by: Michael Neuling <mikey@neuling.org>
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> Cc: <stable@kernel.org>
> ---
>
> Index: linux-powerpc/arch/powerpc/platforms/pseries/lpar.c
> ===================================================================
> --- linux-powerpc.orig/arch/powerpc/platforms/pseries/lpar.c 2011-07-27 13:5
0:18.408091576 +1000
> +++ linux-powerpc/arch/powerpc/platforms/pseries/lpar.c 2011-07-27 13:5
1:19.359196131 +1000
> @@ -203,7 +203,7 @@ static void pSeries_lpar_hptab_clear(voi
> unsigned long ptel;
> } ptes[4];
> long lpar_rc;
> - int i, j;
> + unsigned long i, j;
>
> /* Read in batches of 4,
> * invalidate only valid entries not in the VRMA
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-27 4:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-27 4:15 [PATCH] powerpc: pseries: Fix kexec on machines with more than 4TB of RAM Anton Blanchard
2011-07-27 4:15 ` Anton Blanchard
2011-07-27 4:26 ` Michael Neuling
2011-07-27 4:26 ` Michael Neuling
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.