From: "Liang He" <windhl@126.com>
To: "Marc Zyngier" <maz@kernel.org>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
"Miaoqian Lin" <linmq006@gmail.com>
Subject: Re:Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe()
Date: Wed, 22 Jun 2022 16:15:56 +0800 (CST) [thread overview]
Message-ID: <229e8ea9.5a09.1818a7b7a35.Coremail.windhl@126.com> (raw)
In-Reply-To: <87mte52khd.wl-maz@kernel.org>
At 2022-06-22 16:03:26, "Marc Zyngier" <maz@kernel.org> wrote:
>+ Miaoqian Lin
>
>On Wed, 22 Jun 2022 07:21:38 +0100,
>Liang He <windhl@126.com> wrote:
>>
>> We need to add missing of_node_get() for of_find_matching_node() to
>> keep refcount balance.
>>
>> Note: of_find_matching_node() will decrease the refcount of its first
>> arg.
>>
>> Signed-off-by: Liang He <windhl@126.com>
>
>[...]
>
>Please send these refcount fixes as a series for all the irqchip
>drivers, not one every other day.
>
Sorry, I will group similar bugs in future.
>And please synchronise with Miaoqian Lin, as you are obviously both
>chasing the same bugs.
>
>Thanks,
>
> M.
Yes, before I send any new bug, I will confirm that this bug has not been reported in lore.kernel.org.
By the way, this is a bug missing |GET|, not |PUT|, which is different with Miaoqian's and my patches before.
>
>--
>Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-06-22 8:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 6:21 [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe() Liang He
2022-06-22 8:03 ` Marc Zyngier
2022-06-22 8:15 ` Liang He [this message]
2022-06-22 8:29 ` Marc Zyngier
2022-06-22 8:34 ` Liang He
2022-06-22 9:39 ` Miaoqian Lin
2022-06-22 9:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=229e8ea9.5a09.1818a7b7a35.Coremail.windhl@126.com \
--to=windhl@126.com \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.