All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Liang He <windhl@126.com>,
	tglx@linutronix.de, maz@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe()
Date: Wed, 22 Jun 2022 11:02:15 +0200	[thread overview]
Message-ID: <6abb20a4-1858-3e04-ed5b-dff18110e58a@kernel.org> (raw)
In-Reply-To: <20220622062138.4095598-1-windhl@126.com>

On 22/06/2022 08:21, Liang He wrote:
> We need to add missing of_node_get() for of_find_matching_node() to
> keep refcount balance.
> 
> Note: of_find_matching_node() will decrease the refcount of its first
> arg.
> 
> Signed-off-by: Liang He <windhl@126.com>
> ---
>  drivers/irqchip/irq-gic-v3-its.c | 2 ++
>  1 file changed, 2 insertions(+)

Before applying the patch please check it carefully. Previous evidence
[1][2] suggests that not it was not even compiled.



[1] https://lore.kernel.org/all/202206221602.odN70SHs-lkp@intel.com/

[2]
https://lore.kernel.org/all/16f9a971.44e5.1817068ee3c.Coremail.windhl@126.com/


Best regards,
Krzysztof

      parent reply	other threads:[~2022-06-22  9:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  6:21 [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe() Liang He
2022-06-22  8:03 ` Marc Zyngier
2022-06-22  8:15   ` Liang He
2022-06-22  8:29     ` Marc Zyngier
2022-06-22  8:34       ` Liang He
2022-06-22  9:39         ` Miaoqian Lin
2022-06-22  9:02 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6abb20a4-1858-3e04-ed5b-dff18110e58a@kernel.org \
    --to=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=windhl@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.