[PATCH] drm/i915: Enable stolen for iommu on snb/ivb

[PATCH] drm/i915: Enable stolen for iommu on snb/ivb

[Chris Wilson]

Now that we have CI testing of iommu, let's enable stolen + iommu with a
lot more confidence that we can diagnose any potential erors.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Martin Peres <martin.peres@linux.intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index bfbc3e3daf92..c52ecf525c24 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
@@ -369,13 +369,6 @@ int i915_gem_init_stolen(struct drm_i915_private *dev_priv)
 		return 0;
 	}
 
-	if (intel_vtd_active() && INTEL_GEN(dev_priv) < 8) {
-		dev_notice(dev_priv->drm.dev,
-			   "%s, disabling use of stolen memory\n",
-			   "DMAR active");
-		return 0;
-	}
-
 	if (resource_size(&intel_graphics_stolen_res) == 0)
 		return 0;
 
-- 
2.23.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: failure for drm/i915: Enable stolen for iommu on snb/ivb

[Patchwork]

== Series Details ==

Series: drm/i915: Enable stolen for iommu on snb/ivb
URL   : https://patchwork.freedesktop.org/series/66675/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6891 -> Patchwork_14404
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_14404 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_14404, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14404/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_14404:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live_gem_contexts:
    - fi-cfl-8700k:       [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6891/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14404/fi-cfl-8700k/igt@i915_selftest@live_gem_contexts.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@gem_exec_fence@nb-await-default:
    - {fi-tgl-u}:         [FAIL][3] ([fdo#111562] / [fdo#111597]) -> [WARN][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6891/fi-tgl-u/igt@gem_exec_fence@nb-await-default.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14404/fi-tgl-u/igt@gem_exec_fence@nb-await-default.html

  
Known issues
------------

  Here are the changes found in Patchwork_14404 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@i915_module_load@reload-with-fault-injection:
    - {fi-icl-u4}:        [DMESG-WARN][5] ([fdo#106107] / [fdo#106350]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6891/fi-icl-u4/igt@i915_module_load@reload-with-fault-injection.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14404/fi-icl-u4/igt@i915_module_load@reload-with-fault-injection.html

  * igt@kms_frontbuffer_tracking@basic:
    - {fi-icl-u4}:        [FAIL][7] ([fdo#103167]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6891/fi-icl-u4/igt@kms_frontbuffer_tracking@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14404/fi-icl-u4/igt@kms_frontbuffer_tracking@basic.html

  
#### Warnings ####

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][9] ([fdo#111407]) -> [FAIL][10] ([fdo#111096])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6891/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14404/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
  [fdo#106350]: https://bugs.freedesktop.org/show_bug.cgi?id=106350
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#111562]: https://bugs.freedesktop.org/show_bug.cgi?id=111562
  [fdo#111597]: https://bugs.freedesktop.org/show_bug.cgi?id=111597


Participating hosts (52 -> 47)
------------------------------

  Additional (2): fi-icl-u3 fi-skl-6600u 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_6891 -> Patchwork_14404

  CI-20190529: 20190529
  CI_DRM_6891: 77f0ebb91e6a0dfd22223e2531479f28e9738b83 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5180: 811b10e2bd7fd2cd8ced9bbb55361c178886bbbd @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_14404: 74d98cdf523aa51a109ca933610da2cbabd24788 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

74d98cdf523a drm/i915: Enable stolen for iommu on snb/ivb

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14404/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Enable stolen for iommu on snb/ivb

[Martin Peres]

On 13/09/2019 19:43, Chris Wilson wrote:
> Now that we have CI testing of iommu, let's enable stolen + iommu with a
> lot more confidence that we can diagnose any potential erors.

AFAIK, we still haven't checked that these machines indeed have the
IOMMU enabled yet. Am I wrong?

If I am not, then let's hold the merging of this patch :)

Martin

> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> index bfbc3e3daf92..c52ecf525c24 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
> @@ -369,13 +369,6 @@ int i915_gem_init_stolen(struct drm_i915_private *dev_priv)
>  		return 0;
>  	}
>  
> -	if (intel_vtd_active() && INTEL_GEN(dev_priv) < 8) {
> -		dev_notice(dev_priv->drm.dev,
> -			   "%s, disabling use of stolen memory\n",
> -			   "DMAR active");
> -		return 0;
> -	}
> -
>  	if (resource_size(&intel_graphics_stolen_res) == 0)
>  		return 0;
>  
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Enable stolen for iommu on snb/ivb

[Chris Wilson]

Quoting Martin Peres (2019-09-17 12:39:13)
> On 13/09/2019 19:43, Chris Wilson wrote:
> > Now that we have CI testing of iommu, let's enable stolen + iommu with a
> > lot more confidence that we can diagnose any potential erors.
> 
> AFAIK, we still haven't checked that these machines indeed have the
> IOMMU enabled yet. Am I wrong?

Hmm, let's have a quick look,

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6906/fi-snb-2600/boot0.txt
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6907/fi-snb-2520m/boot0.txt
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6905/shard-snb6/boot1.txt
No iommu

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6905/shard-hsw8/boot1.txt
<6>[    1.540343] pci 0000:00:02.0: Adding to iommu group 1

So only a smattering of coverage on Haswell (didn't check the farm1
ivb/hsw/byt).

So indeed hard to draw any conclusion from our test results at present.
Hopefully, Tomi will have some success in fighting with the BIOS.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx