From: Juergen Gross <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: javi.merino@cloud.com, Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 01/13] xen/spinlock: fix coding style issues
Date: Wed, 18 Oct 2023 17:52:36 +0200 [thread overview]
Message-ID: <22c544a1-cd26-41dc-aed8-bc822b42cbbf@suse.com> (raw)
In-Reply-To: <03f6b4e4-adb2-db15-c07f-532d93254fe0@suse.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1047 bytes --]
On 18.10.23 17:47, Jan Beulich wrote:
> On 13.10.2023 11:42, Juergen Gross wrote:
>> Fix some coding style issues in spinlock coding:
>>
>> - Instead of u64 etc. use the preferred uint64_t etc. types
>> - Remove some trailing spaces
>> - Add missing spaces in "if" statements
>> - Add some missing blank lines
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> with one possible further request:
>
>> @@ -298,7 +298,7 @@ static always_inline spinlock_tickets_t observe_lock(spinlock_tickets_t *t)
>> return v;
>> }
>>
>> -static always_inline u16 observe_head(spinlock_tickets_t *t)
>> +static always_inline uint16_t observe_head(spinlock_tickets_t *t)
>
> While there, could you also add const to the pointed-to parameter type?
> t, after all, ...
>
>> {
>> smp_rmb();
>> return read_atomic(&t->head);
>
> ... is only read through. (I'd also be happy for this to be adjusted on
> commit, so long as you agree.)
I agree.
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2023-10-18 15:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 9:42 [PATCH v2 00/13] xen/spinlock: make recursive spinlocks a dedicated type Juergen Gross
2023-10-13 9:42 ` [PATCH v2 01/13] xen/spinlock: fix coding style issues Juergen Gross
2023-10-18 15:47 ` Jan Beulich
2023-10-18 15:52 ` Juergen Gross [this message]
2023-10-13 9:42 ` [PATCH v2 02/13] xen/spinlock: reduce lock profile ifdefs Juergen Gross
2023-10-18 15:57 ` Jan Beulich
2023-10-19 9:05 ` Juergen Gross
2023-10-13 9:42 ` [PATCH v2 03/13] xen/spinlock: make spinlock initializers more readable Juergen Gross
2023-10-18 16:00 ` Jan Beulich
2023-10-13 9:42 ` [PATCH v2 04/13] xen/spinlock: introduce new type for recursive spinlocks Juergen Gross
2023-10-13 9:42 ` [PATCH v2 05/13] xen/spinlock: rename recursive lock functions Juergen Gross
2023-10-13 9:42 ` [PATCH v2 06/13] xen/spinlock: add rspin_[un]lock_irq[save|restore]() Juergen Gross
2023-10-13 9:42 ` [PATCH v2 07/13] xen/spinlock: make struct lock_profile rspinlock_t aware Juergen Gross
2023-10-13 9:42 ` [PATCH v2 08/13] xen/spinlock: add explicit non-recursive locking functions Juergen Gross
2023-10-13 9:42 ` [PATCH v2 09/13] xen/spinlock: add another function level Juergen Gross
2023-10-13 9:42 ` [PATCH v2 10/13] xen/spinlock: add missing rspin_is_locked() and rspin_barrier() Juergen Gross
2023-10-13 9:42 ` [PATCH v2 11/13] xen/spinlock: split recursive spinlocks from normal ones Juergen Gross
2023-10-13 9:42 ` [PATCH v2 12/13] xen/spinlock: remove indirection through macros for spin_*() functions Juergen Gross
2023-10-13 9:42 ` [PATCH v2 13/13] xen/spinlock: support higher number of cpus Juergen Gross
2023-10-19 7:48 ` [PATCH v2 00/13] xen/spinlock: make recursive spinlocks a dedicated type Jan Beulich
2023-10-19 9:35 ` Andrew Cooper
2023-10-19 9:39 ` Jan Beulich
2023-10-19 11:05 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22c544a1-cd26-41dc-aed8-bc822b42cbbf@suse.com \
--to=jgross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=javi.merino@cloud.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.