From: Heiko Stuebner <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
Chris Morgan <macroalpha82@gmail.com>
Cc: mripard@kernel.org, devicetree@vger.kernel.org,
conor+dt@kernel.org, rfoss@kernel.org, tzimmermann@suse.de,
jonas@kwiboo.se, neil.armstrong@linaro.org,
Chris Morgan <macromorgan@hotmail.com>,
sebastian.reichel@collabora.com, jernej.skrabec@gmail.com,
dri-devel@lists.freedesktop.org, andrzej.hajda@intel.com,
andy.yan@rock-chips.com, krzk+dt@kernel.org, robh@kernel.org,
Laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 2/3] drm/bridge: dw-hdmi-qp: Add support for missing HPD
Date: Thu, 06 Nov 2025 20:40:55 +0100 [thread overview]
Message-ID: <2301926.irdbgypaU6@phil> (raw)
In-Reply-To: <20251106180914.768502-3-macroalpha82@gmail.com>
Am Donnerstag, 6. November 2025, 19:09:13 Mitteleuropäische Normalzeit schrieb Chris Morgan:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add support for the dw-hdmi-qp driver to handle devices with missing
> HPD pins.
>
> Since in this situation we are now polling for the EDID data via i2c
> change the error message to a debug message when we are unable to
> complete an i2c read, as a disconnected device would otherwise fill
> dmesg with i2c read errors.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> @@ -1074,12 +1095,18 @@ struct dw_hdmi_qp *dw_hdmi_qp_bind(struct platform_device *pdev,
> if (ret)
> return ERR_PTR(ret);
>
> + if (of_property_present(pdev->dev.of_node, "no-hpd"))
> + hdmi->no_hpd = 1;
> + else
> + hdmi->no_hpd = 0;
> +
what is the argument against
hdmi->no_hpd = of_property_read_bool(pdev->dev.of_node, "no-hpd")); ?
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
Chris Morgan <macroalpha82@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
cristian.ciocaltea@collabora.com,
sebastian.reichel@collabora.com, jernej.skrabec@gmail.com,
jonas@kwiboo.se, Laurent.pinchart@ideasonboard.com,
rfoss@kernel.org, neil.armstrong@linaro.org,
andrzej.hajda@intel.com, conor+dt@kernel.org, krzk+dt@kernel.org,
robh@kernel.org, tzimmermann@suse.de, mripard@kernel.org,
andy.yan@rock-chips.com, Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 2/3] drm/bridge: dw-hdmi-qp: Add support for missing HPD
Date: Thu, 06 Nov 2025 20:40:55 +0100 [thread overview]
Message-ID: <2301926.irdbgypaU6@phil> (raw)
In-Reply-To: <20251106180914.768502-3-macroalpha82@gmail.com>
Am Donnerstag, 6. November 2025, 19:09:13 Mitteleuropäische Normalzeit schrieb Chris Morgan:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add support for the dw-hdmi-qp driver to handle devices with missing
> HPD pins.
>
> Since in this situation we are now polling for the EDID data via i2c
> change the error message to a debug message when we are unable to
> complete an i2c read, as a disconnected device would otherwise fill
> dmesg with i2c read errors.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> @@ -1074,12 +1095,18 @@ struct dw_hdmi_qp *dw_hdmi_qp_bind(struct platform_device *pdev,
> if (ret)
> return ERR_PTR(ret);
>
> + if (of_property_present(pdev->dev.of_node, "no-hpd"))
> + hdmi->no_hpd = 1;
> + else
> + hdmi->no_hpd = 0;
> +
what is the argument against
hdmi->no_hpd = of_property_read_bool(pdev->dev.of_node, "no-hpd")); ?
next prev parent reply other threads:[~2025-11-06 19:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 18:09 [PATCH 0/3] Add HDMI for Gameforce Ace Chris Morgan
2025-11-06 18:09 ` Chris Morgan
2025-11-06 18:09 ` [PATCH 1/3] dt-bindings: display: rockchip: Add no-hpd for dw-hdmi-qp controller Chris Morgan
2025-11-06 18:09 ` Chris Morgan
2025-11-07 17:26 ` Conor Dooley
2025-11-07 17:26 ` Conor Dooley
2025-11-06 18:09 ` [PATCH 2/3] drm/bridge: dw-hdmi-qp: Add support for missing HPD Chris Morgan
2025-11-06 18:09 ` Chris Morgan
2025-11-06 19:40 ` Heiko Stuebner [this message]
2025-11-06 19:40 ` Heiko Stuebner
2025-11-06 23:46 ` Chris Morgan
2025-11-06 23:46 ` Chris Morgan
2025-11-07 10:08 ` Sebastian Reichel
2025-11-07 10:08 ` Sebastian Reichel
2025-11-06 18:09 ` [PATCH 3/3] arm64: dts: rockchip: Add HDMI to Gameforce Ace Chris Morgan
2025-11-06 18:09 ` Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2301926.irdbgypaU6@phil \
--to=heiko@sntech.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.