From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents)
Date: Sat, 05 Dec 2015 23:19:04 +0100 [thread overview]
Message-ID: <23027215.8RIhViTVaB@wuerfel> (raw)
In-Reply-To: <1449295856-31068-3-git-send-email-yankejian@huawei.com>
On Saturday 05 December 2015 14:10:56 yankejian wrote:
> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
> index 80411b2..ecacfa4 100644
> --- a/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
> +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
> @@ -4,8 +4,6 @@ Required properties:
> - compatible: should be "hisilicon,hns-dsaf-v1" or "hisilicon,hns-dsaf-v2".
> "hisilicon,hns-dsaf-v1" is for hip05.
> "hisilicon,hns-dsaf-v2" is for Hi1610 and Hi1612.
> -- dsa-name: dsa fabric name who provide this interface.
> - should be "dsafX", X is the dsaf id.
> - mode: dsa fabric mode string. only support one of dsaf modes like these:
> "2port-64vf",
> "6port-16rss",
> @@ -26,9 +24,8 @@ Required properties:
>
> Example:
>
> -dsa: dsa at c7000000 {
> +dsaf0: dsa at c7000000 {
> compatible = "hisilicon,hns-dsaf-v1";
> - dsa_name = "dsaf0";
> mode = "6port-16rss";
> interrupt-parent = <&mbigen_dsa>;
> reg = <0x0 0xC0000000 0x0 0x420000
> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt
> index 41d19be..e6a9d1c 100644
> --- a/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt
> +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt
> @@ -4,8 +4,9 @@ Required properties:
> - compatible: "hisilicon,hns-nic-v1" or "hisilicon,hns-nic-v2".
> "hisilicon,hns-nic-v1" is for hip05.
> "hisilicon,hns-nic-v2" is for Hi1610 and Hi1612.
> -- ae-name: accelerator name who provides this interface,
> - is simply a name referring to the name of name in the accelerator node.
> +- ae-handle: accelerator engine handle for hns,
> + specifies a reference to the associating hardware driver node.
> + see Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
> - port-id: is the index of port provided by DSAF (the accelerator). DSAF can
> connect to 8 PHYs. Port 0 to 1 are both used for adminstration purpose. They
> are called debug ports.
> @@ -41,7 +42,7 @@ Example:
>
>
This looks like an incompatible change, as you add and remove
required properties. Is there a way to support both the old and
the new style?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: yankejian <yankejian@huawei.com>
Cc: davem@davemloft.net, fengguang.wu@intel.com, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
catalin.marinas@arm.com, will.deacon@arm.com,
salil.mehta@huawei.com, Yisen.Zhuang@huawei.com,
liguozhu@huawei.com, lisheng011@huawei.com,
huangdaode@hisilicon.com, xuwei5@hisilicon.com,
haifeng.wei@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents)
Date: Sat, 05 Dec 2015 23:19:04 +0100 [thread overview]
Message-ID: <23027215.8RIhViTVaB@wuerfel> (raw)
In-Reply-To: <1449295856-31068-3-git-send-email-yankejian@huawei.com>
On Saturday 05 December 2015 14:10:56 yankejian wrote:
> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
> index 80411b2..ecacfa4 100644
> --- a/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
> +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
> @@ -4,8 +4,6 @@ Required properties:
> - compatible: should be "hisilicon,hns-dsaf-v1" or "hisilicon,hns-dsaf-v2".
> "hisilicon,hns-dsaf-v1" is for hip05.
> "hisilicon,hns-dsaf-v2" is for Hi1610 and Hi1612.
> -- dsa-name: dsa fabric name who provide this interface.
> - should be "dsafX", X is the dsaf id.
> - mode: dsa fabric mode string. only support one of dsaf modes like these:
> "2port-64vf",
> "6port-16rss",
> @@ -26,9 +24,8 @@ Required properties:
>
> Example:
>
> -dsa: dsa@c7000000 {
> +dsaf0: dsa@c7000000 {
> compatible = "hisilicon,hns-dsaf-v1";
> - dsa_name = "dsaf0";
> mode = "6port-16rss";
> interrupt-parent = <&mbigen_dsa>;
> reg = <0x0 0xC0000000 0x0 0x420000
> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt
> index 41d19be..e6a9d1c 100644
> --- a/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt
> +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt
> @@ -4,8 +4,9 @@ Required properties:
> - compatible: "hisilicon,hns-nic-v1" or "hisilicon,hns-nic-v2".
> "hisilicon,hns-nic-v1" is for hip05.
> "hisilicon,hns-nic-v2" is for Hi1610 and Hi1612.
> -- ae-name: accelerator name who provides this interface,
> - is simply a name referring to the name of name in the accelerator node.
> +- ae-handle: accelerator engine handle for hns,
> + specifies a reference to the associating hardware driver node.
> + see Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
> - port-id: is the index of port provided by DSAF (the accelerator). DSAF can
> connect to 8 PHYs. Port 0 to 1 are both used for adminstration purpose. They
> are called debug ports.
> @@ -41,7 +42,7 @@ Example:
>
>
This looks like an incompatible change, as you add and remove
required properties. Is there a way to support both the old and
the new style?
Arnd
next prev parent reply other threads:[~2015-12-05 22:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-05 6:10 [PATCH net-next 0/2] net: hns: enet specisies a reference to dsaf yankejian
2015-12-05 6:10 ` yankejian
2015-12-05 6:10 ` yankejian
2015-12-05 6:10 ` yankejian
2015-12-05 6:10 ` [PATCH net-next 1/2] " yankejian
2015-12-05 6:10 ` yankejian
2015-12-05 6:10 ` yankejian
2015-12-05 6:10 ` [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents) yankejian
2015-12-05 6:10 ` yankejian
2015-12-05 6:10 ` yankejian
2015-12-05 22:19 ` Arnd Bergmann [this message]
2015-12-05 22:19 ` Arnd Bergmann
2015-12-07 7:14 ` Yankejian (Hackim Yim)
2015-12-07 7:14 ` Yankejian (Hackim Yim)
2015-12-07 7:14 ` Yankejian (Hackim Yim)
2015-12-07 7:14 ` Yankejian (Hackim Yim)
2015-12-07 9:40 ` arRe: " Arnd Bergmann
2015-12-07 9:40 ` Arnd Bergmann
2015-12-09 9:25 ` Yankejian (Hackim Yim)
2015-12-09 9:25 ` Yankejian (Hackim Yim)
2015-12-09 9:25 ` Yankejian (Hackim Yim)
2015-12-09 10:00 ` Arnd Bergmann
2015-12-09 10:00 ` Arnd Bergmann
2015-12-09 10:23 ` Yankejian (Hackim Yim)
2015-12-09 10:23 ` Yankejian (Hackim Yim)
2015-12-09 10:23 ` Yankejian (Hackim Yim)
-- strict thread matches above, loose matches on Subject: below --
2015-12-05 7:59 [PATCH net-next 0/2] net: hns: enet specisies a reference to dsaf yankejian
2015-12-05 7:59 ` [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents) yankejian
2015-12-05 7:59 ` yankejian
2015-12-05 7:59 ` yankejian
2015-12-05 7:59 ` yankejian
2015-12-07 14:12 ` Rob Herring
2015-12-07 14:12 ` Rob Herring
2015-12-08 12:21 ` Yankejian (Hackim Yim)
2015-12-08 12:21 ` Yankejian (Hackim Yim)
2015-12-08 12:21 ` Yankejian (Hackim Yim)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23027215.8RIhViTVaB@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.