[RFC PATCH 7/7] selinux: drop copy-paste comment

[RFC PATCH 7/7] selinux: drop copy-paste comment

[Christian Göttsche]

From: Christian Göttsche <cgzones@googlemail.com>

Port labeling is based on port number and protocol (TCP/UDP/...) but not
based on network family (IPv4/IPv6).

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
 security/selinux/netport.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/security/selinux/netport.c b/security/selinux/netport.c
index 2a315dcc4344..cfa55d703ce1 100644
--- a/security/selinux/netport.c
+++ b/security/selinux/netport.c
@@ -47,12 +47,6 @@ struct sel_netport {
 	struct rcu_head rcu;
 };
 
-/* NOTE: we are using a combined hash table for both IPv4 and IPv6, the reason
- * for this is that I suspect most users will not make heavy use of both
- * address families at the same time so one table will usually end up wasted,
- * if this becomes a problem we can always add a hash table for each address
- * family later */
-
 static DEFINE_SPINLOCK(sel_netport_lock);
 static struct sel_netport_bkt sel_netport_hash[SEL_NETPORT_HASH_SIZE];
 
-- 
2.49.0

Re: [PATCH RFC 7/7] selinux: drop copy-paste comment

[Paul Moore]

On Mar 18, 2025 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgoettsche@seltendoof.de> wrote:
> 
> Port labeling is based on port number and protocol (TCP/UDP/...) but not
> based on network family (IPv4/IPv6).
> 
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> ---
>  security/selinux/netport.c | 6 ------
>  1 file changed, 6 deletions(-)

Merged into selinux/dev, thanks!

--
paul-moore.com