From: David Howells <dhowells@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org,
Linux Memory Management <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/14] get_unmapped_area handles MAP_FIXED on ramfs (nommu)
Date: Wed, 04 Apr 2007 11:16:58 +0100 [thread overview]
Message-ID: <23091.1175681818@redhat.com> (raw)
In-Reply-To: <20070404040231.A110CDDEB8@ozlabs.org>
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> - if (!(flags & MAP_SHARED))
> + /* Deal with MAP_FIXED differently ? Forbid it ? Need help from some nommu
> + * folks there... --BenH.
> + */
> + if ((flags & MAP_FIXED) || !(flags & MAP_SHARED))
MAP_FIXED on NOMMU? Surely you jest...
See the first if-statement in validate_mmap_request().
If anything, you should be adding BUG_ON(flags & MAP_FIXED).
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org,
Linux Memory Management <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/14] get_unmapped_area handles MAP_FIXED on ramfs (nommu)
Date: Wed, 04 Apr 2007 11:16:58 +0100 [thread overview]
Message-ID: <23091.1175681818@redhat.com> (raw)
In-Reply-To: <20070404040231.A110CDDEB8@ozlabs.org>
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> - if (!(flags & MAP_SHARED))
> + /* Deal with MAP_FIXED differently ? Forbid it ? Need help from some nommu
> + * folks there... --BenH.
> + */
> + if ((flags & MAP_FIXED) || !(flags & MAP_SHARED))
MAP_FIXED on NOMMU? Surely you jest...
See the first if-statement in validate_mmap_request().
If anything, you should be adding BUG_ON(flags & MAP_FIXED).
David
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-04-04 10:17 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 4:02 [PATCH 0/14] Pass MAP_FIXED down to get_unmapped_area Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 1/14] get_unmapped_area handles MAP_FIXED on powerpc Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 2/14] get_unmapped_area handles MAP_FIXED on alpha Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 3/14] get_unmapped_area handles MAP_FIXED on arm Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 4/14] get_unmapped_area handles MAP_FIXED on frv Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 5/14] get_unmapped_area handles MAP_FIXED on i386 Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 6/14] get_unmapped_area handles MAP_FIXED on ia64 Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 7/14] get_unmapped_area handles MAP_FIXED on parisc Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 8/14] get_unmapped_area handles MAP_FIXED on sparc64 Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 9/14] get_unmapped_area handles MAP_FIXED on x86_64 Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 11/14] get_unmapped_area handles MAP_FIXED on ramfs (nommu) Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 10:16 ` David Howells [this message]
2007-04-04 10:16 ` David Howells
2007-04-04 23:13 ` Benjamin Herrenschmidt
2007-04-04 23:13 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 10/14] get_unmapped_area handles MAP_FIXED in hugetlbfs Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 12/14] get_unmapped_area handles MAP_FIXED in /dev/mem (nommu) Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 10:31 ` David Howells
2007-04-04 10:31 ` David Howells
2007-04-04 23:14 ` Benjamin Herrenschmidt
2007-04-04 23:14 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 13/14] get_unmapped_area handles MAP_FIXED in generic code Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` [PATCH 14/14] get_unmapped_area doesn't need hugetlbfs hacks anymore Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 4:02 ` Benjamin Herrenschmidt
2007-04-04 10:31 ` [PATCH 0/14] Pass MAP_FIXED down to get_unmapped_area David Howells
2007-04-04 10:31 ` David Howells
2007-04-04 23:20 ` Benjamin Herrenschmidt
2007-04-04 23:20 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2007-04-04 4:01 Benjamin Herrenschmidt
2007-04-04 4:01 ` [PATCH 11/14] get_unmapped_area handles MAP_FIXED on ramfs (nommu) Benjamin Herrenschmidt
2007-04-04 4:01 ` Benjamin Herrenschmidt
2007-04-04 4:01 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23091.1175681818@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.