From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Arnd Bergmann <arnd@arndb.de>, Kevin Hilman <khilman@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Olof Johansson <olof@lixom.net>,
Simon Horman <horms@verge.net.au>,
linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 8/9] ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge options
Date: Mon, 10 Jul 2017 16:41:46 +0300 [thread overview]
Message-ID: <2320662.jifSpTNEif@avalon> (raw)
In-Reply-To: <1499693302-25120-9-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Monday 10 Jul 2017 15:28:21 Geert Uytterhoeven wrote:
> The manual bridge implementation was removed in favor of the generic
> one, so now we need to enable standard bridge drivers like
> DRM_DUMB_VGA_DAC and DRM_I2C_ADV7511.
> Both were already enabled, but the (newer) ADV7511 audio part wasn't.
>
> Fixes: 5c602531feb3db39 ("drm: rcar-du: Replace manual bridge implementation
> with DRM bridge")
I wonder if this patch really needs a Fixes tag. All it does is removing a now
deleted kernel option, and adding a new unrelated one. The former is related
to 5c602531feb3db39, but I'm not sure it should be considered as a bug.
The content of this patch looks good to me though.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> multi_v7_defconfig is in desperate need of a refresh.
>
> To reduce conflicts, I went for the simple option of adding
> CONFIG_DRM_I2C_ADV7511_AUDIO below CONFIG_DRM_I2C_ADV7511, instead of
> moving CONFIG_DRM_I2C_ADV7511 and CONFIG_DRM_DUMB_VGA_DAC around.
> ---
> arch/arm/configs/multi_v7_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig
> b/arch/arm/configs/multi_v7_defconfig index
> 7fa1746970ecc531..ea2075d8e185f7aa 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -584,6 +584,7 @@ CONFIG_VIDEO_ADV7180=m
> CONFIG_VIDEO_ML86V7667=m
> CONFIG_DRM=y
> CONFIG_DRM_I2C_ADV7511=m
> +CONFIG_DRM_I2C_ADV7511_AUDIO=y
> # CONFIG_DRM_I2C_CH7006 is not set
> # CONFIG_DRM_I2C_SIL164 is not set
> CONFIG_DRM_DUMB_VGA_DAC=m
> @@ -603,7 +604,6 @@ CONFIG_ROCKCHIP_DW_MIPI_DSI=y
> CONFIG_ROCKCHIP_INNO_HDMI=y
> CONFIG_DRM_ATMEL_HLCDC=m
> CONFIG_DRM_RCAR_DU=m
> -CONFIG_DRM_RCAR_HDMI=y
> CONFIG_DRM_RCAR_LVDS=y
> CONFIG_DRM_SUN4I=m
> CONFIG_DRM_TEGRA=y
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/9] ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge options
Date: Mon, 10 Jul 2017 16:41:46 +0300 [thread overview]
Message-ID: <2320662.jifSpTNEif@avalon> (raw)
In-Reply-To: <1499693302-25120-9-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Monday 10 Jul 2017 15:28:21 Geert Uytterhoeven wrote:
> The manual bridge implementation was removed in favor of the generic
> one, so now we need to enable standard bridge drivers like
> DRM_DUMB_VGA_DAC and DRM_I2C_ADV7511.
> Both were already enabled, but the (newer) ADV7511 audio part wasn't.
>
> Fixes: 5c602531feb3db39 ("drm: rcar-du: Replace manual bridge implementation
> with DRM bridge")
I wonder if this patch really needs a Fixes tag. All it does is removing a now
deleted kernel option, and adding a new unrelated one. The former is related
to 5c602531feb3db39, but I'm not sure it should be considered as a bug.
The content of this patch looks good to me though.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> multi_v7_defconfig is in desperate need of a refresh.
>
> To reduce conflicts, I went for the simple option of adding
> CONFIG_DRM_I2C_ADV7511_AUDIO below CONFIG_DRM_I2C_ADV7511, instead of
> moving CONFIG_DRM_I2C_ADV7511 and CONFIG_DRM_DUMB_VGA_DAC around.
> ---
> arch/arm/configs/multi_v7_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig
> b/arch/arm/configs/multi_v7_defconfig index
> 7fa1746970ecc531..ea2075d8e185f7aa 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -584,6 +584,7 @@ CONFIG_VIDEO_ADV7180=m
> CONFIG_VIDEO_ML86V7667=m
> CONFIG_DRM=y
> CONFIG_DRM_I2C_ADV7511=m
> +CONFIG_DRM_I2C_ADV7511_AUDIO=y
> # CONFIG_DRM_I2C_CH7006 is not set
> # CONFIG_DRM_I2C_SIL164 is not set
> CONFIG_DRM_DUMB_VGA_DAC=m
> @@ -603,7 +604,6 @@ CONFIG_ROCKCHIP_DW_MIPI_DSI=y
> CONFIG_ROCKCHIP_INNO_HDMI=y
> CONFIG_DRM_ATMEL_HLCDC=m
> CONFIG_DRM_RCAR_DU=m
> -CONFIG_DRM_RCAR_HDMI=y
> CONFIG_DRM_RCAR_LVDS=y
> CONFIG_DRM_SUN4I=m
> CONFIG_DRM_TEGRA=y
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-07-10 13:41 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 13:28 [PATCH 0/9] ARM: renesas: shmobile and multi_v7 defconfig updates Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 1/9] ARM: shmobile: defconfig: Enable missing PCIE_RCAR dependency Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 2/9] ARM: shmobile: defconfig: Replace USB_XHCI_RCAR by USB_XHCI_PLATFORM Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 3/9] ARM: shmobile: defconfig: Replace SND_SOC_RSRC_CARD by SND_SIMPLE_SCU_CARD Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 4/9] ARM: shmobile: defconfig: Replace DRM_RCAR_HDMI by generic bridge options Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 5/9] ARM: shmobile: defconfig: Enable DMA for serial ports Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 6/9] ARM: shmobile: defconfig: Refresh Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 7/9] ARM: multi_v7_defconfig: Replace SND_SOC_RSRC_CARD by SND_SIMPLE_SCU_CARD Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 8/9] ARM: multi_v7_defconfig: Replace DRM_RCAR_HDMI by generic bridge options Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-10 13:41 ` Laurent Pinchart [this message]
2017-07-10 13:41 ` Laurent Pinchart
2017-07-10 14:05 ` Geert Uytterhoeven
2017-07-10 14:05 ` Geert Uytterhoeven
2017-07-10 13:28 ` [PATCH 9/9] ARM: multi_v7_defconfig: Enable DMA for Renesas serial ports Geert Uytterhoeven
2017-07-10 13:28 ` Geert Uytterhoeven
2017-07-11 3:38 ` Magnus Damm
2017-07-11 3:38 ` Magnus Damm
2017-07-11 6:59 ` Geert Uytterhoeven
2017-07-11 6:59 ` Geert Uytterhoeven
2017-07-11 6:59 ` Geert Uytterhoeven
2017-07-11 8:39 ` Arnd Bergmann
2017-07-11 8:39 ` Arnd Bergmann
2017-07-11 8:39 ` Arnd Bergmann
2017-07-11 8:57 ` Geert Uytterhoeven
2017-07-11 8:57 ` Geert Uytterhoeven
2017-07-11 8:57 ` Geert Uytterhoeven
2017-07-11 8:42 ` Arnd Bergmann
2017-07-11 8:42 ` Arnd Bergmann
2017-07-11 8:42 ` Arnd Bergmann
2017-07-11 8:59 ` Geert Uytterhoeven
2017-07-11 8:59 ` Geert Uytterhoeven
2017-07-11 8:59 ` Geert Uytterhoeven
2017-07-11 10:37 ` Rob Landley
2017-07-11 10:37 ` Rob Landley
2017-07-11 10:37 ` Rob Landley
2017-07-11 10:46 ` Geert Uytterhoeven
2017-07-11 10:46 ` Geert Uytterhoeven
2017-07-11 10:46 ` Geert Uytterhoeven
2017-11-01 8:58 ` Rob Landley
2017-11-01 8:58 ` Rob Landley
2017-11-01 8:58 ` Rob Landley
2017-07-11 9:13 ` [PATCH 0/9] ARM: renesas: shmobile and multi_v7 defconfig updates Simon Horman
2017-07-11 9:13 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2320662.jifSpTNEif@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=arnd@arndb.de \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.