From: Florian Fainelli <florian@openwrt.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Julia Lawall <julia@diku.dk>,
apkm@linux-foundation.org
Subject: Re: [patch] vlynq: fix another resource size off by 1 error
Date: Sun, 12 Jan 2014 19:43:36 +0000 [thread overview]
Message-ID: <2337301.FMvHPCUCYL@lenovo> (raw)
In-Reply-To: <20131111114827.GE5443@mwanda>
Le lundi 11 novembre 2013, 14:48:27 Dan Carpenter a écrit :
> We still need to apply this fix.
Sorry for this late answer, vlynq changes usually go through AKPM's tree as I
don't maintain one due to the low number of changes in this code.
>
> regards,
> dan carpenter
>
> On Fri, Aug 23, 2013 at 11:19:49AM +0300, Dan Carpenter wrote:
> > We fixed the call to request_mem_region() patch
> > 3354f73 ('drivers/vlynq/vlynq.c: fix resource size off by 1 error').
> > But we need to fix the call the release_mem_region() as well.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Static checker stuff.
> >
> > diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
> > index 7b07135..c0227f9 100644
> > --- a/drivers/vlynq/vlynq.c
> > +++ b/drivers/vlynq/vlynq.c
> > @@ -762,7 +762,8 @@ static int vlynq_remove(struct platform_device *pdev)
> >
> > device_unregister(&dev->dev);
> > iounmap(dev->local);
> >
> > - release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
> > + release_mem_region(dev->regs_start,
> > + dev->regs_end - dev->regs_start + 1);
> >
> > kfree(dev);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian@openwrt.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Julia Lawall <julia@diku.dk>,
apkm@linux-foundation.org
Subject: Re: [patch] vlynq: fix another resource size off by 1 error
Date: Sun, 12 Jan 2014 11:43:36 -0800 [thread overview]
Message-ID: <2337301.FMvHPCUCYL@lenovo> (raw)
In-Reply-To: <20131111114827.GE5443@mwanda>
Le lundi 11 novembre 2013, 14:48:27 Dan Carpenter a écrit :
> We still need to apply this fix.
Sorry for this late answer, vlynq changes usually go through AKPM's tree as I
don't maintain one due to the low number of changes in this code.
>
> regards,
> dan carpenter
>
> On Fri, Aug 23, 2013 at 11:19:49AM +0300, Dan Carpenter wrote:
> > We fixed the call to request_mem_region() patch
> > 3354f73 ('drivers/vlynq/vlynq.c: fix resource size off by 1 error').
> > But we need to fix the call the release_mem_region() as well.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Static checker stuff.
> >
> > diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
> > index 7b07135..c0227f9 100644
> > --- a/drivers/vlynq/vlynq.c
> > +++ b/drivers/vlynq/vlynq.c
> > @@ -762,7 +762,8 @@ static int vlynq_remove(struct platform_device *pdev)
> >
> > device_unregister(&dev->dev);
> > iounmap(dev->local);
> >
> > - release_mem_region(dev->regs_start, dev->regs_end - dev->regs_start);
> > + release_mem_region(dev->regs_start,
> > + dev->regs_end - dev->regs_start + 1);
> >
> > kfree(dev);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Florian
next prev parent reply other threads:[~2014-01-12 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 8:19 [patch] vlynq: fix another resource size off by 1 error Dan Carpenter
2014-01-13 8:16 ` [patch -resend] " Dan Carpenter
2013-11-11 11:48 ` [patch] " Dan Carpenter
2013-11-11 11:48 ` Dan Carpenter
2014-01-12 19:43 ` Florian Fainelli [this message]
2014-01-12 19:43 ` Florian Fainelli
2014-01-13 8:41 ` [patch -resend] " Dan Carpenter
2014-01-13 8:41 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2337301.FMvHPCUCYL@lenovo \
--to=florian@openwrt.org \
--cc=apkm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.