From: Thomas Monjalon <thomas@monjalon.net>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] net/failsafe: fix blank line parsing
Date: Thu, 03 Aug 2017 22:34:59 +0200 [thread overview]
Message-ID: <2340494.aB5PmPcCMt@xps> (raw)
In-Reply-To: <e9354faa7de5fcf5e8fc9606b62c2e64029fecf1.1501772768.git.gaetan.rivet@6wind.com>
03/08/2017 17:08, Gaetan Rivet:
> When the output of an exec() slave definition is only a single newline
> character, the fail-safe currently fails to parse the device with the
> value returned by the rte_devargs library.
>
> This behavior is incorrect, because the fail-safe should make a
> difference between the absence of a device, and an erroneous device
> declaration.
>
> Fix the output sanitization in the case where no newline was at its end
> and detect the special case of an absent device. The correct error code
> is then returned.
>
> Fixes: a0194d828100 ("net/failsafe: add flexible device definition")
>
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied, thanks
prev parent reply other threads:[~2017-08-03 20:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 14:52 [PATCH] net/failsafe: fix blank line parsing Gaetan Rivet
2017-08-03 15:08 ` [PATCH v2] " Gaetan Rivet
2017-08-03 20:34 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2340494.aB5PmPcCMt@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.