From: "Heiko Stübner" <heiko@sntech.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Kukjin Kim <kgene.kim@samsung.com>,
Ben Dooks <ben-linux@fluff.org>, Arnd Bergmann <arnd@arndb.de>,
Tomasz Figa <tomasz.figa@gmail.com>,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ARM: s3c24xx: explicit dependency on <plat/gpio-cfg.h>
Date: Tue, 14 Jan 2014 15:20:36 +0100 [thread overview]
Message-ID: <2340755.WhXRgu2emH@phil> (raw)
In-Reply-To: <1389708788-18331-1-git-send-email-linus.walleij@linaro.org>
Am Dienstag, 14. Januar 2014, 15:13:08 schrieb Linus Walleij:
> Previously the custom GPIO header for the S3C24xx would in turn
> bring in the custom pin control implementation from
> <plat/gpio-cfg.h>. This is not good as it mixes up two
> subsystems and makes the dependencies hard to track. Make
> the dependency explicit by explicitly including the pin
> control header where needed.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
> Cc: Ben Dooks <ben-linux@fluff.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: linux-samsung-soc@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Maintainers: this builds on top of the previous patch moving
> headers back to <mach/*>. This will also boil in linux-next,
> ACKs appreciated.
> ---
Acked-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: s3c24xx: explicit dependency on <plat/gpio-cfg.h>
Date: Tue, 14 Jan 2014 15:20:36 +0100 [thread overview]
Message-ID: <2340755.WhXRgu2emH@phil> (raw)
In-Reply-To: <1389708788-18331-1-git-send-email-linus.walleij@linaro.org>
Am Dienstag, 14. Januar 2014, 15:13:08 schrieb Linus Walleij:
> Previously the custom GPIO header for the S3C24xx would in turn
> bring in the custom pin control implementation from
> <plat/gpio-cfg.h>. This is not good as it mixes up two
> subsystems and makes the dependencies hard to track. Make
> the dependency explicit by explicitly including the pin
> control header where needed.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Tomasz Figa <tomasz.figa@gmail.com>
> Cc: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
> Cc: Ben Dooks <ben-linux@fluff.org>
> Cc: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: linux-samsung-soc at vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Maintainers: this builds on top of the previous patch moving
> headers back to <mach/*>. This will also boil in linux-next,
> ACKs appreciated.
> ---
Acked-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2014-01-14 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 14:13 [PATCH] ARM: s3c24xx: explicit dependency on <plat/gpio-cfg.h> Linus Walleij
2014-01-14 14:13 ` Linus Walleij
2014-01-14 14:20 ` Heiko Stübner [this message]
2014-01-14 14:20 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2340755.WhXRgu2emH@phil \
--to=heiko@sntech.de \
--cc=arnd@arndb.de \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sylvester.nawrocki@gmail.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.