All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Jimmy Hon <honyuenkwun@gmail.com>
Cc: Ondrej Jirman <megi@xff.cz>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	Jimmy Hon <honyuenkwun@gmail.com>
Subject: Re: [PATCH v6 1/4] arm64: dts: rockchip: refactor common rk3588-orangepi-5.dtsi
Date: Sun, 05 Jan 2025 14:20:26 +0100	[thread overview]
Message-ID: <2341242.bB369e8A3T@phil> (raw)
In-Reply-To: <20250104020544.6777-2-honyuenkwun@gmail.com>

Hi Jimmy,

Am Samstag, 4. Januar 2025, 03:05:37 CET schrieb Jimmy Hon:
> for Orange Pi 5 Plus/Max/Ultra and AI Max

somehow your subject continues int the patch description.
We definitly would like some more explanation here.

And also you're missing the Signed-off-by statement.

> ---
>  .../dts/rockchip/rk3588-orangepi-5-plus.dts   | 855 ++----------------
>  .../boot/dts/rockchip/rk3588-orangepi-5.dtsi  | 797 ++++++++++++++++
>  2 files changed, 862 insertions(+), 790 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-orangepi-5.dtsi


Heiko




WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Jimmy Hon <honyuenkwun@gmail.com>
Cc: Ondrej Jirman <megi@xff.cz>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	Jimmy Hon <honyuenkwun@gmail.com>
Subject: Re: [PATCH v6 1/4] arm64: dts: rockchip: refactor common rk3588-orangepi-5.dtsi
Date: Sun, 05 Jan 2025 14:20:26 +0100	[thread overview]
Message-ID: <2341242.bB369e8A3T@phil> (raw)
In-Reply-To: <20250104020544.6777-2-honyuenkwun@gmail.com>

Hi Jimmy,

Am Samstag, 4. Januar 2025, 03:05:37 CET schrieb Jimmy Hon:
> for Orange Pi 5 Plus/Max/Ultra and AI Max

somehow your subject continues int the patch description.
We definitly would like some more explanation here.

And also you're missing the Signed-off-by statement.

> ---
>  .../dts/rockchip/rk3588-orangepi-5-plus.dts   | 855 ++----------------
>  .../boot/dts/rockchip/rk3588-orangepi-5.dtsi  | 797 ++++++++++++++++
>  2 files changed, 862 insertions(+), 790 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-orangepi-5.dtsi


Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-01-05 13:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-04  2:05 [PATCH v6 0/4] Orange Pi 5 Max Jimmy Hon
2025-01-04  2:05 ` Jimmy Hon
2025-01-04  2:05 ` [PATCH v6 1/4] arm64: dts: rockchip: refactor common rk3588-orangepi-5.dtsi Jimmy Hon
2025-01-04  2:05   ` Jimmy Hon
2025-01-05 13:20   ` Heiko Stuebner [this message]
2025-01-05 13:20     ` Heiko Stuebner
2025-01-04  2:05 ` [PATCH v6 2/4] dt-bindings: arm: rockchip: Add Xunlong Orange Pi 5 Max Jimmy Hon
2025-01-04  2:05   ` Jimmy Hon
2025-01-04  2:05 ` [PATCH v6 3/4] arm64: dts: rockchip: Add Orange Pi 5 Max board Jimmy Hon
2025-01-04  2:05   ` Jimmy Hon
2025-01-04  2:05 ` [PATCH v6 4/4] arm64: dts: rockchip: Enable HDMI1 on Orange Pi 5 Max Jimmy Hon
2025-01-04  2:05   ` Jimmy Hon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2341242.bB369e8A3T@phil \
    --to=heiko@sntech.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=honyuenkwun@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=megi@xff.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.