All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	Ziyuan Xu <xzy.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	Elaine Zhang <zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	Douglas Anderson
	<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	David Wu <david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	Jianqun Xu <jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	Yakir Yang <ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	Brian Norris
	<briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 1/9] arm64: dts: rockchip: add eMMC's power domain support for rk3399
Date: Mon, 14 Nov 2016 15:45:20 +0100	[thread overview]
Message-ID: <2342292.tK2jqRKrXH@phil> (raw)
In-Reply-To: <1478697721-2323-2-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

Am Mittwoch, 9. November 2016, 21:21:53 CET schrieb Caesar Wang:
> From: Ziyuan Xu <xzy.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> 
> Control power domain for eMMC via genpd to reduce power consumption.
> 
> Signed-off-by: Elaine Zhang <zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> Signed-off-by: Ziyuan Xu <xzy.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

Authorship / Signed-off mismatch. From above suggest Ziyuan is the author 
while first Signed-off-by indicates Elaine as author. Please clarify.


Thanks
Heiko

> ---
> 
> Changes in v2:
> - Reviewed-on: https://chromium-review.googlesource.com/376558
> - Verified on ChromeOS kernel4.4
> 
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index cbb7f8b..b401176 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -269,6 +269,7 @@
>  		#clock-cells = <0>;
>  		phys = <&emmc_phy>;
>  		phy-names = "phy_arasan";
> +		power-domains = <&power RK3399_PD_EMMC>;
>  		status = "disabled";
>  	};
> 
> @@ -690,6 +691,11 @@
>  		status = "disabled";
>  	};
> 
> +	qos_emmc: qos@ffa58000 {
> +		compatible = "syscon";
> +		reg = <0x0 0xffa58000 0x0 0x20>;
> +	};
> +
>  	qos_gmac: qos@ffa5c000 {
>  		compatible = "syscon";
>  		reg = <0x0 0xffa5c000 0x0 0x20>;
> @@ -823,6 +829,11 @@
>  			};
> 
>  			/* These power domains are grouped by VD_LOGIC */
> +			pd_emmc@RK3399_PD_EMMC {
> +				reg = <RK3399_PD_EMMC>;
> +				clocks = <&cru ACLK_EMMC>;
> +				pm_qos = <&qos_emmc>;
> +			};
>  			pd_gmac@RK3399_PD_GMAC {
>  				reg = <RK3399_PD_GMAC>;
>  				clocks = <&cru ACLK_GMAC>;


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/9] arm64: dts: rockchip: add eMMC's power domain support for rk3399
Date: Mon, 14 Nov 2016 15:45:20 +0100	[thread overview]
Message-ID: <2342292.tK2jqRKrXH@phil> (raw)
In-Reply-To: <1478697721-2323-2-git-send-email-wxt@rock-chips.com>

Am Mittwoch, 9. November 2016, 21:21:53 CET schrieb Caesar Wang:
> From: Ziyuan Xu <xzy.xu@rock-chips.com>
> 
> Control power domain for eMMC via genpd to reduce power consumption.
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>

Authorship / Signed-off mismatch. From above suggest Ziyuan is the author 
while first Signed-off-by indicates Elaine as author. Please clarify.


Thanks
Heiko

> ---
> 
> Changes in v2:
> - Reviewed-on: https://chromium-review.googlesource.com/376558
> - Verified on ChromeOS kernel4.4
> 
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index cbb7f8b..b401176 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -269,6 +269,7 @@
>  		#clock-cells = <0>;
>  		phys = <&emmc_phy>;
>  		phy-names = "phy_arasan";
> +		power-domains = <&power RK3399_PD_EMMC>;
>  		status = "disabled";
>  	};
> 
> @@ -690,6 +691,11 @@
>  		status = "disabled";
>  	};
> 
> +	qos_emmc: qos at ffa58000 {
> +		compatible = "syscon";
> +		reg = <0x0 0xffa58000 0x0 0x20>;
> +	};
> +
>  	qos_gmac: qos at ffa5c000 {
>  		compatible = "syscon";
>  		reg = <0x0 0xffa5c000 0x0 0x20>;
> @@ -823,6 +829,11 @@
>  			};
> 
>  			/* These power domains are grouped by VD_LOGIC */
> +			pd_emmc at RK3399_PD_EMMC {
> +				reg = <RK3399_PD_EMMC>;
> +				clocks = <&cru ACLK_EMMC>;
> +				pm_qos = <&qos_emmc>;
> +			};
>  			pd_gmac at RK3399_PD_GMAC {
>  				reg = <RK3399_PD_GMAC>;
>  				clocks = <&cru ACLK_GMAC>;

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Caesar Wang <wxt@rock-chips.com>
Cc: eddie.cai@rock-chips.com, tfiga@chromium.org,
	Ziyuan Xu <xzy.xu@rock-chips.com>,
	Elaine Zhang <zhangqing@rock-chips.com>,
	Douglas Anderson <dianders@chromium.org>,
	David Wu <david.wu@rock-chips.com>,
	Jianqun Xu <jay.xu@rock-chips.com>,
	Yakir Yang <ykk@rock-chips.com>,
	Brian Norris <briannorris@chromium.org>,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Will Deacon <will.deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/9] arm64: dts: rockchip: add eMMC's power domain support for rk3399
Date: Mon, 14 Nov 2016 15:45:20 +0100	[thread overview]
Message-ID: <2342292.tK2jqRKrXH@phil> (raw)
In-Reply-To: <1478697721-2323-2-git-send-email-wxt@rock-chips.com>

Am Mittwoch, 9. November 2016, 21:21:53 CET schrieb Caesar Wang:
> From: Ziyuan Xu <xzy.xu@rock-chips.com>
> 
> Control power domain for eMMC via genpd to reduce power consumption.
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>

Authorship / Signed-off mismatch. From above suggest Ziyuan is the author 
while first Signed-off-by indicates Elaine as author. Please clarify.


Thanks
Heiko

> ---
> 
> Changes in v2:
> - Reviewed-on: https://chromium-review.googlesource.com/376558
> - Verified on ChromeOS kernel4.4
> 
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index cbb7f8b..b401176 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -269,6 +269,7 @@
>  		#clock-cells = <0>;
>  		phys = <&emmc_phy>;
>  		phy-names = "phy_arasan";
> +		power-domains = <&power RK3399_PD_EMMC>;
>  		status = "disabled";
>  	};
> 
> @@ -690,6 +691,11 @@
>  		status = "disabled";
>  	};
> 
> +	qos_emmc: qos@ffa58000 {
> +		compatible = "syscon";
> +		reg = <0x0 0xffa58000 0x0 0x20>;
> +	};
> +
>  	qos_gmac: qos@ffa5c000 {
>  		compatible = "syscon";
>  		reg = <0x0 0xffa5c000 0x0 0x20>;
> @@ -823,6 +829,11 @@
>  			};
> 
>  			/* These power domains are grouped by VD_LOGIC */
> +			pd_emmc@RK3399_PD_EMMC {
> +				reg = <RK3399_PD_EMMC>;
> +				clocks = <&cru ACLK_EMMC>;
> +				pm_qos = <&qos_emmc>;
> +			};
>  			pd_gmac@RK3399_PD_GMAC {
>  				reg = <RK3399_PD_GMAC>;
>  				clocks = <&cru ACLK_GMAC>;

  parent reply	other threads:[~2016-11-14 14:45 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09 13:21 [PATCH v2 0/9] rockchip: add more power domain and devices dts for rk3399 Caesar Wang
2016-11-09 13:21 ` Caesar Wang
2016-11-09 13:21 ` Caesar Wang
2016-11-09 13:21 ` [PATCH v2 1/9] arm64: dts: rockchip: add eMMC's power domain support " Caesar Wang
2016-11-09 13:21   ` Caesar Wang
     [not found]   ` <1478697721-2323-2-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-11-12  4:22     ` Shawn Lin
2016-11-12  4:22       ` Shawn Lin
2016-11-12  4:22       ` Shawn Lin
     [not found]       ` <bce1a5eb-fbb3-9ed9-46b9-72a95eefed3e-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-11-14 15:05         ` Caesar Wang
2016-11-14 15:05           ` Caesar Wang
2016-11-14 15:05           ` Caesar Wang
2016-11-14 14:45     ` Heiko Stuebner [this message]
2016-11-14 14:45       ` Heiko Stuebner
2016-11-14 14:45       ` Heiko Stuebner
2016-11-14 15:01       ` Caesar Wang
2016-11-14 15:01         ` Caesar Wang
2016-11-14 15:01         ` Caesar Wang
2016-11-14 15:26         ` Heiko Stuebner
2016-11-14 15:26           ` Heiko Stuebner
     [not found] ` <1478697721-2323-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-11-09 13:21   ` [PATCH v2 2/9] arm64: dts: rockchip: add pd_sd power node " Caesar Wang
2016-11-09 13:21     ` Caesar Wang
2016-11-09 13:21     ` Caesar Wang
     [not found]     ` <1478697721-2323-3-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-11-12  4:35       ` Shawn Lin
2016-11-12  4:35         ` Shawn Lin
2016-11-12  4:35         ` Shawn Lin
2016-11-14 15:27       ` Heiko Stuebner
2016-11-14 15:27         ` Heiko Stuebner
2016-11-14 15:27         ` Heiko Stuebner
2016-11-09 13:21   ` [PATCH v2 3/9] arm64: dts: rockchip: add VOP and VOP iommu " Caesar Wang
2016-11-09 13:21     ` Caesar Wang
2016-11-09 13:21     ` Caesar Wang
     [not found]     ` <1478697721-2323-4-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-11-14 16:05       ` Heiko Stuebner
2016-11-14 16:05         ` Heiko Stuebner
2016-11-14 16:05         ` Heiko Stuebner
2016-11-21  2:55         ` Caesar Wang
2016-11-21  2:55           ` Caesar Wang
2016-11-09 13:21   ` [PATCH v2 4/9] arm64: dts: rockchip: add eDP device " Caesar Wang
2016-11-09 13:21     ` Caesar Wang
2016-11-09 13:21     ` Caesar Wang
2016-11-09 13:22   ` [PATCH v2 8/9] arm64: dts: rockchip: support dwc3 USB " Caesar Wang
2016-11-09 13:22     ` Caesar Wang
2016-11-09 13:22     ` Caesar Wang
     [not found]     ` <1478697721-2323-9-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-11-30 22:28       ` Brian Norris
2016-11-30 22:28         ` Brian Norris
2016-11-30 22:28         ` Brian Norris
2016-11-21  2:17   ` [PATCH v2.1 7/9] arm64: dts: rockchip: add pd_edp node " Caesar Wang
2016-11-21  2:17     ` Caesar Wang
2016-11-21  2:17     ` Caesar Wang
2016-11-09 13:21 ` [PATCH v2 5/9] arm64: dts: rockchip: add backlight support for rk3399 evb board Caesar Wang
2016-11-09 13:21   ` Caesar Wang
     [not found]   ` <1478697721-2323-6-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-11-14 14:53     ` Heiko Stuebner
2016-11-14 14:53       ` Heiko Stuebner
2016-11-14 14:53       ` Heiko Stuebner
2016-11-09 13:21 ` [PATCH v2 6/9] arm64: dts: rockchip: introduce pclk_vio_grf in eDP device node Caesar Wang
2016-11-09 13:21   ` Caesar Wang
2016-11-09 13:21 ` [PATCH v2 7/9] arm64: dts: rockchip: add pd_edp node for rk3399 Caesar Wang
2016-11-09 13:21   ` Caesar Wang
2016-11-14 17:26   ` Doug Anderson
2016-11-14 17:26     ` Doug Anderson
2016-11-09 13:22 ` [PATCH v2 9/9] arm64: dts: rockchip: add the usb3 pd " Caesar Wang
2016-11-09 13:22   ` Caesar Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2342292.tK2jqRKrXH@phil \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
    --cc=david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    --cc=wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=xzy.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.