All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: paulmck@linux.vnet.ibm.com, npiggin@suse.de, corbet@lwn.net
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
	linux-cachefs@redhat.com
Subject: An incorrect assumption over radix_tree_tag_get()
Date: Tue, 06 Apr 2010 17:19:49 +0100	[thread overview]
Message-ID: <23428.1270570789@redhat.com> (raw)


Hi,

I think I've made a bad assumption over my usage of radix_tree_tag_get() in
fs/fscache/page.c.

I've assumed that radix_tree_tag_get() is protected from radix_tree_tag_set()
and radix_tree_tag_clear() by the RCU read lock.  However, now I'm not so
sure.  I think it's only protected against removal of part of the tree.

Can you confirm?

David

             reply	other threads:[~2010-04-06 16:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-06 16:19 David Howells [this message]
2010-04-06 17:09 ` An incorrect assumption over radix_tree_tag_get() Nick Piggin
2010-04-06 18:52   ` David Howells
2010-04-06 19:16     ` David Howells
2010-04-06 23:34   ` Dave Chinner
2010-04-07  7:57     ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23428.1270570789@redhat.com \
    --to=dhowells@redhat.com \
    --cc=corbet@lwn.net \
    --cc=linux-cachefs@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.