All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Nick Piggin <npiggin@suse.de>
Cc: dhowells@redhat.com, paulmck@linux.vnet.ibm.com, corbet@lwn.net,
	linux-kernel@vger.kernel.org, linux-cachefs@redhat.com
Subject: Re: An incorrect assumption over radix_tree_tag_get()
Date: Tue, 06 Apr 2010 19:52:45 +0100	[thread overview]
Message-ID: <25610.1270579965@redhat.com> (raw)
In-Reply-To: <20100406170903.GH5288@laptop>

Nick Piggin <npiggin@suse.de> wrote:

> It is safe. Synchronization requirements for using the radix tree API
> are documented.

I presume you mean the big comment on it in radix-tree.h.

According to that, it is not safe:

 * - any function _modifying_ the tree or tags (inserting or deleting
 *   items, setting or clearing tags) must exclude other modifications, and
 *   exclude any functions reading the tree.
 
David

  reply	other threads:[~2010-04-06 18:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-06 16:19 An incorrect assumption over radix_tree_tag_get() David Howells
2010-04-06 17:09 ` Nick Piggin
2010-04-06 18:52   ` David Howells [this message]
2010-04-06 19:16     ` David Howells
2010-04-06 23:34   ` Dave Chinner
2010-04-07  7:57     ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25610.1270579965@redhat.com \
    --to=dhowells@redhat.com \
    --cc=corbet@lwn.net \
    --cc=linux-cachefs@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@suse.de \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.