All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: dron0gus@gmail.com
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
	linux-arm-kernel@lists.infradead.org,
	sylvester.nawrocki@gmail.com, Andrey Gusakov <dron_gus@mail.ru>
Subject: Re: [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of "camera" clock
Date: Sat, 10 Nov 2012 16:01:29 +0100	[thread overview]
Message-ID: <2352709.lKq9axvLZf@flatron> (raw)
In-Reply-To: <509e6047.a766980a.0f91.14f6@mx.google.com>

Hi Andrey,

On Saturday 10 of November 2012 18:07:57 dron0gus@gmail.com wrote:
> From: Andrey Gusakov <dron_gus@mail.ru>
> 
> The "camera" clock have only one parent. Define it staticly and
> remove unused source clock list.
> 
> Signed-off-by: Andrey Gusakov <dron0gus@gmail.com>
> ---
>  arch/arm/mach-s3c64xx/clock.c |   12 +-----------
>  1 files changed, 1 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c64xx/clock.c
> b/arch/arm/mach-s3c64xx/clock.c index b2d08fa..19228f3 100644
> --- a/arch/arm/mach-s3c64xx/clock.c
> +++ b/arch/arm/mach-s3c64xx/clock.c
> @@ -677,15 +677,6 @@ static struct clksrc_sources clkset_audio2 = {
>  	.nr_sources	= ARRAY_SIZE(clkset_audio2_list),
>  };
> 
> -static struct clk *clkset_camif_list[] = {
> -	&clk_h2,
> -};
> -
> -static struct clksrc_sources clkset_camif = {
> -	.sources	= clkset_camif_list,
> -	.nr_sources	= ARRAY_SIZE(clkset_camif_list),
> -};
> -
>  static struct clk *clkset_mfc_list[] = {
>  	&clk_h2,
>  	&clk_mout_epll.clk,
> @@ -750,10 +741,9 @@ static struct clksrc_clk clksrcs[] = {
>  			.name		= "camera",
>  			.ctrlbit        = S3C_CLKCON_SCLK_CAM,
>  			.enable		= s3c64xx_sclk_ctrl,
> +			.parent		= &clk_h2,
>  		},
>  		.reg_div	= { .reg = S3C_CLK_DIV0, .shift = 20, .size 
= 4  },
> -		.reg_src	= { .reg = NULL, .shift = 0, .size = 0  },
> -		.sources	= &clkset_camif,
>  	}, {
>  		.clk	= {
>  			.name		= "sclk_mfc",

Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>

Best regards,
Tomasz Figa

WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of "camera" clock
Date: Sat, 10 Nov 2012 16:01:29 +0100	[thread overview]
Message-ID: <2352709.lKq9axvLZf@flatron> (raw)
In-Reply-To: <509e6047.a766980a.0f91.14f6@mx.google.com>

Hi Andrey,

On Saturday 10 of November 2012 18:07:57 dron0gus at gmail.com wrote:
> From: Andrey Gusakov <dron_gus@mail.ru>
> 
> The "camera" clock have only one parent. Define it staticly and
> remove unused source clock list.
> 
> Signed-off-by: Andrey Gusakov <dron0gus@gmail.com>
> ---
>  arch/arm/mach-s3c64xx/clock.c |   12 +-----------
>  1 files changed, 1 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c64xx/clock.c
> b/arch/arm/mach-s3c64xx/clock.c index b2d08fa..19228f3 100644
> --- a/arch/arm/mach-s3c64xx/clock.c
> +++ b/arch/arm/mach-s3c64xx/clock.c
> @@ -677,15 +677,6 @@ static struct clksrc_sources clkset_audio2 = {
>  	.nr_sources	= ARRAY_SIZE(clkset_audio2_list),
>  };
> 
> -static struct clk *clkset_camif_list[] = {
> -	&clk_h2,
> -};
> -
> -static struct clksrc_sources clkset_camif = {
> -	.sources	= clkset_camif_list,
> -	.nr_sources	= ARRAY_SIZE(clkset_camif_list),
> -};
> -
>  static struct clk *clkset_mfc_list[] = {
>  	&clk_h2,
>  	&clk_mout_epll.clk,
> @@ -750,10 +741,9 @@ static struct clksrc_clk clksrcs[] = {
>  			.name		= "camera",
>  			.ctrlbit        = S3C_CLKCON_SCLK_CAM,
>  			.enable		= s3c64xx_sclk_ctrl,
> +			.parent		= &clk_h2,
>  		},
>  		.reg_div	= { .reg = S3C_CLK_DIV0, .shift = 20, .size 
= 4  },
> -		.reg_src	= { .reg = NULL, .shift = 0, .size = 0  },
> -		.sources	= &clkset_camif,
>  	}, {
>  		.clk	= {
>  			.name		= "sclk_mfc",

Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>

Best regards,
Tomasz Figa

  reply	other threads:[~2012-11-10 15:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1352556477-3700-1-git-send-email-y>
2012-11-10 14:07 ` [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of "camera" clock dron0gus
2012-11-10 14:07   ` dron0gus at gmail.com
2012-11-10 15:01   ` Tomasz Figa [this message]
2012-11-10 15:01     ` Tomasz Figa
2012-11-10 21:13   ` Sylwester Nawrocki
2012-11-10 21:13     ` Sylwester Nawrocki
2012-11-10 21:33     ` Sylwester Nawrocki
2012-11-10 21:33       ` Sylwester Nawrocki
2012-11-12  5:02       ` Kukjin Kim
2012-11-12  5:02         ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2352709.lKq9axvLZf@flatron \
    --to=tomasz.figa@gmail.com \
    --cc=dron0gus@gmail.com \
    --cc=dron_gus@mail.ru \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sylvester.nawrocki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.