Re: [Buildroot] [PATCH] package/connman: Remove wpa_supplicant selection for wifi

[Arnout Vandecappelle via buildroot <buildroot@buildroot.org>]

On 16/07/2024 23:14, Bryce Johnson wrote:
> Connman wifi works both with IWD and wpa_supplicant.  You don't want
> BR2_PACKAGE_WPA_SUPPLICANT selected when using IWD.

  But you still need one of them, right? We normally do that with a condition like:

	select BR2_PACKAGE_WPA_SUPPLICANT if !BR2_PACKAGE_IWD

(or the other way round, of course).

> 
> ---
>   package/connman/Config.in | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/package/connman/Config.in b/package/connman/Config.in
> index af3e1f69f6..44a3b41fb2 100644
> --- a/package/connman/Config.in
> +++ b/package/connman/Config.in
> @@ -45,8 +45,6 @@ config BR2_PACKAGE_CONNMAN_ETHERNET
> 
>   config BR2_PACKAGE_CONNMAN_WIFI
>          bool "enable WiFi support"
> -       select BR2_PACKAGE_WPA_SUPPLICANT # runtime
> -       select BR2_PACKAGE_WPA_SUPPLICANT_DBUS # runtime

  Actually, we would typically only enable it automatically in the .mk file, 
something like

ifneq ($(BR2_PACKAGE_IWD)$(BR2_PACKAGE_WPA_SUPPLICANT),)
CONNMAN_CONF_OPTS += --enable-wifi
else
CONNMAN_CONF_OPTS += --disable-wifi
endif

  But since we already have the explicit option, I guess we should keep it.

  Regards,
  Arnout

>          help
>            Enable WiFi support (scan and static/dhcp interface
>            setup). ConnMan detects the start of wpa_supplicant
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot