Re: [PATCH v10 2/2] arm64: dts: rockchip: Add ALIENTEK QuarkPi-CA2

[Heiko Stuebner <heiko@sntech.de>]

Am Donnerstag, 22. Oktober 2026, 18:26:21 Mitteleuropäische Normalzeit schrieb Bob Hui:
> Add a device tree for the ALIENTEK QuarkPi-CA2, an RK3588S based card
> computer. The board comes in 4, 8 and 16 GiB LPDDR4X variants with
> 32 GB, 64 GB or 128 GB of eMMC; this was tested on the 16 GiB/128 GB
> one.
> 
> Supported peripherals:
>   - 2x LPDDR4X SDRAM and eMMC, plus the microSD card slot
>   - RK806-1 PMIC with the full regulator tree
>   - HDMI output up to 4K60, through hdptxphy0 and VOP2
>   - Gigabit Ethernet with the YT8531 RGMII PHY on MDIO1
>   - four USB Type-A ports (1x USB 3.0, 3x USB 2.0)
>   - USB Type-C port with USB 3.0 and DP output, described through the
>     USBDP PHY and DP0, with role switch and DP altmode
>   - 3.5 mm headset jack (headphones + microphone) with the ES8388
>     codec, the headphone amplifier and jack detection
>   - three function keys (volume down, volume up and PWR_ON from the
>     PMIC) and the headset hook button
>   - IR receiver, 4-pin PWM fan connector and two LEDs
>   - 3-wire debug UART (UART2)
>   - 40-pin expansion header with UART5, I2C3, I2C5, SPI0 and PWM14
>   - two 26-pin MIPI DSI and three 22-pin MIPI CSI connectors, with the
>     connector I2C buses enabled (i2c4, i2c7); panels and cameras are
>     described by overlays
>   - M.2 E-key socket for a WiFi/BT module, with the PCIe 2.0 x1 link
>     enabled (pcie2x1l2, combphy0_ps)
>   - Mali GPU and the three NPU cores

Please trim your commit message down a lot, this should definitly
not be this long and contain stuff nobody cares about ;-)
So I guess the above should be enough.


> Assisted-by: Hermes:deepseek-v4-flash

Assisted-by got removed again from the process documentation with 7.4-rc1
so is not necessary anymore.


> Signed-off-by: Bob Hui <bg9oxa@163.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Andrew always just reviews part of the board, namely the gmac and mdio
nodes - and states that in his review mail, so I guess a nice way to
do this would be:

Reviewed-by: Andrew Lunn <andrew@lunn.ch> #gmac1 + mdio1


> +	aliases {
> +		mmc0 = &sdhci;
> +		mmc1 = &sdmmc;
> +		ethernet0 = &gmac1;

please sort properties according to the devicetree writing guide,
namely here, properties alphabetically, "e" comes before "m".

> +		button-vol-up {
> +			label = "volume up";
> +			linux,code = <KEY_VOLUMEUP>;
> +			press-threshold-microvolt = <17000>;
> +		};
> +
> +		button-vol-down {
> +			label = "volume down";
> +			linux,code = <KEY_VOLUMEDOWN>;
> +			press-threshold-microvolt = <417000>;
> +		};

similarly please sort nodes without addresses alphabetically,
"down" before "up"


> +	vcc_1v1_nldo_s3: regulator-vcc-1v1-nldo-s3 {
[...]
> +	};
> +
> +	combophy_avdd0v85: regulator-combophy-avdd0v85 {
[...]
> +	};
> +
> +	combophy_avdd1v8: regulator-combophy-avdd1v8 {
[...]
> +	};

another example of the sorting issue.
The parts I highlight are not exhaustive, please make sure all are
sorted correctly.

[...]

> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +					regulator-suspend-microvolt = <750000>;

regulator-suspend-microvolt is deprecated in the binding, please don't
introduce new instances of it. (applicable to all cases)


> +&i2c2 {
[...]
> +};
> +
> +&cpu_l0 {

please sort phandle references alphabetically, &cpu... before &i2c
same for all other places in the file.

> +/ {

you have one root block at the top, you should definitly not need another
one here.


> +/ {

or here

> +	analog_sound: analog-sound {
> +		compatible = "simple-audio-card";


> +&{/} {

this is geting crazy now

> +	ir_receiver: ir-receiver {
> +		compatible = "gpio-ir-receiver";
> +		gpios = <&gpio0 RK_PD4 GPIO_ACTIVE_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&ir_receiver_pin>;
> +	};
> +};
> +


Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip