From: Dang Huynh <danct12@riseup.net>
To: Anatolij Gustschin <agust@denx.de>,
Simon Glass <sjg@chromium.org>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Kever Yang <kever.yang@rock-chips.com>,
Tom Rini <trini@konsulko.com>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>, Ondrej Jirman <megi@xff.cz>,
Dragan Simic <dsimic@manjaro.org>,
Svyatoslav Ryhel <clamor95@gmail.com>,
u-boot@lists.denx.de
Cc: u-boot@lists.denx.de, Chaoyi Chen <chaoyi.chen@rock-chips.com>
Subject: Re: [PATCH v2 06/11] video: rockchip: Add VOP2 support
Date: Sun, 02 Mar 2025 11:09:34 +0700 [thread overview]
Message-ID: <2377708.irdbgypaU6@melttower> (raw)
In-Reply-To: <97d68df3-e6e3-4912-aab3-0ffe09c218e2@rock-chips.com>
Hi Chaoyi Chen,
On Thursday, February 27, 2025 6:29:13 AM UTC Chaoyi Chen wrote:
>
> Could you use a naming prefix like "rkvop2" to explicitly indicate the
> use of vop2, thereby distinguishing it from rk_vop.c?
>
Yes. This will be in v3.
> > + struct rk3568_vop_esmart *esmart = priv->regs +
VOP2_ESMART_OFFSET(0);
>
> You are assuming that the RK356X is always used ESMART0, which generally
> works. But considering
> that there are multiple Video Ports and different Video Ports may have
> different primary win,
> selecting the appropriate win can simplifies the processing for U-Boot
> to Kernel transitions in the future.
>
> It's a good idea to implement the win selection as a configurable
> parameter, or we can consider the
> default win used for different Video Ports.
ESMART0 is configured to the desired video port on U-Boot. VOP2 should be
reconfigured by Linux.
next prev parent reply other threads:[~2025-03-02 4:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-23 12:13 [PATCH v2 00/11] Rockchip VOP2 support Dang Huynh
2025-02-23 12:13 ` [PATCH v2 01/11] video: rockchip: dw-mipi-dsi: Depend on CONFIG_VIDEO_BRIDGE Dang Huynh
2025-02-23 12:44 ` Svyatoslav Ryhel
2025-02-23 12:13 ` [PATCH v2 02/11] video: rockchip: dw_mipi_dsi: Improve pixel clock calculations Dang Huynh
2025-02-23 12:13 ` [PATCH v2 03/11] video: rockchip: dw_mipi_dsi: Proceed when external PHY is not defined Dang Huynh
2025-02-23 12:46 ` Svyatoslav Ryhel
2025-02-23 12:13 ` [PATCH v2 04/11] video: rockchip: dw-mipi-dsi: Add get_display_timing support Dang Huynh
2025-02-23 12:48 ` Svyatoslav Ryhel
2025-02-23 12:13 ` [PATCH v2 05/11] video: Add BOE TH101MB31IG002-28A MIPI-DSI panel Dang Huynh
2025-02-23 12:51 ` Svyatoslav Ryhel
2025-02-23 12:13 ` [PATCH v2 06/11] video: rockchip: Add VOP2 support Dang Huynh
2025-02-27 8:29 ` Chaoyi Chen
2025-03-02 4:09 ` Dang Huynh [this message]
2025-03-03 9:48 ` Chaoyi Chen
2025-03-04 1:04 ` Dang Huynh
2025-03-04 1:12 ` Andy Yan
2025-02-23 12:13 ` [PATCH v2 07/11] video: rockchip: vop2: Add video bridge support Dang Huynh
2025-02-23 12:55 ` Svyatoslav Ryhel
2025-02-23 12:13 ` [PATCH v2 08/11] dts: rockchip: rk356x: Prerelocate VOP in U-Boot proper Dang Huynh
2025-02-23 12:13 ` [PATCH v2 09/11] configs: quartz64: Enable vidconsole Dang Huynh
2025-02-23 12:13 ` [PATCH v2 10/11] video: rockchip: Add HDMI support for RK3568 Dang Huynh
2025-02-23 12:13 ` [PATCH v2 11/11] configs: pinetab2-rk3566: Enable video and USB keyboard Dang Huynh
[not found] ` <mailman.0.1742764847.19692.u-boot@lists.denx.de>
2025-03-23 21:32 ` Rockchip VOP2 support Maciej Pijanowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2377708.irdbgypaU6@melttower \
--to=danct12@riseup.net \
--cc=agust@denx.de \
--cc=chaoyi.chen@rock-chips.com \
--cc=clamor95@gmail.com \
--cc=dsimic@manjaro.org \
--cc=frattaroli.nicolas@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=megi@xff.cz \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.