All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Leon Romanovsky <leon@leon.nu>
Cc: dhowells@redhat.com, Linux-MM <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-cachefs <linux-cachefs@redhat.com>,
	linux-afs <linux-afs@lists.infradead.org>
Subject: Re: [RFC] Refactor kenter/kleave/kdebug macros
Date: Mon, 18 May 2015 14:29:01 +0100	[thread overview]
Message-ID: <23799.1431955741@warthog.procyon.org.uk> (raw)
In-Reply-To: <CALq1K=J4iRqD5qiSr2S7m+jgr63K7=e1PmA-pX1s4MEDimsLbw@mail.gmail.com>

Leon Romanovsky <leon@leon.nu> wrote:

> Blind conversion to pr_debug will blow the code because it will be always
> compiled in.

No, it won't.

> Additionally, It looks like the output of these macros can be viewed by ftrace
> mechanism.

*blink* It can?

> Maybe we should delete them from mm/nommu.c as was pointed by Joe?

Why?

David

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Leon Romanovsky <leon@leon.nu>
Cc: dhowells@redhat.com, Linux-MM <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-cachefs <linux-cachefs@redhat.com>,
	linux-afs <linux-afs@lists.infradead.org>
Subject: Re: [RFC] Refactor kenter/kleave/kdebug macros
Date: Mon, 18 May 2015 14:29:01 +0100	[thread overview]
Message-ID: <23799.1431955741@warthog.procyon.org.uk> (raw)
In-Reply-To: <CALq1K=J4iRqD5qiSr2S7m+jgr63K7=e1PmA-pX1s4MEDimsLbw@mail.gmail.com>

Leon Romanovsky <leon@leon.nu> wrote:

> Blind conversion to pr_debug will blow the code because it will be always
> compiled in.

No, it won't.

> Additionally, It looks like the output of these macros can be viewed by ftrace
> mechanism.

*blink* It can?

> Maybe we should delete them from mm/nommu.c as was pointed by Joe?

Why?

David

  parent reply	other threads:[~2015-05-18 13:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-16 17:01 [RFC] Refactor kenter/kleave/kdebug macros Leon Romanovsky
2015-05-16 17:01 ` Leon Romanovsky
2015-05-16 17:09 ` Joe Perches
2015-05-16 17:09   ` Joe Perches
2015-05-16 18:56   ` Leon Romanovsky
2015-05-16 18:56     ` Leon Romanovsky
2015-05-18 10:31 ` David Howells
2015-05-18 10:31   ` David Howells
2015-05-18 13:23   ` Leon Romanovsky
2015-05-18 13:27     ` Leon Romanovsky
2015-05-18 13:27       ` Leon Romanovsky
2015-05-18 13:29     ` David Howells [this message]
2015-05-18 13:29       ` David Howells
2015-05-18 13:52       ` Leon Romanovsky
2015-05-18 13:52         ` Leon Romanovsky
2015-05-18 15:20         ` David Howells
2015-05-18 15:20           ` David Howells
2015-05-18 18:35           ` Leon Romanovsky
2015-05-18 18:35             ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23799.1431955741@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=leon@leon.nu \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-cachefs@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.