All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Moore <pmoore@redhat.com>
To: Eduardo Otubo <otubo@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] New syscalls to the seccomp whitelist
Date: Wed, 26 Sep 2012 16:10:01 -0400	[thread overview]
Message-ID: <2382564.6AYpmYLdf3@sifl> (raw)
In-Reply-To: <1348231233-29841-1-git-send-email-otubo@linux.vnet.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 2096 bytes --]

On Friday, September 21, 2012 09:40:33 AM Eduardo Otubo wrote:
> Seccomp syscall whitelist updated after tests running qemu under
> libvirt. Reference to the bug -
> https://bugzilla.redhat.com/show_bug.cgi?id=855162

Unfortunately, this patch still does not work correctly for me using 
F17/libvirt and a F16 guest.  The QEMU instance starts, and the guest appears 
to be running, but I never see any of the BIOS POST messages on the console.

I'm attaching the guest's XML definition file if that helps.

> Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
> ---
>  qemu-seccomp.c | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index 64329a3..4712338 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -70,6 +70,7 @@ static const struct QemuSeccompSyscall seccomp_whitelist[]
> = { { SCMP_SYS(setsockopt), 245},
>      { SCMP_SYS(uname), 245},
>      { SCMP_SYS(semget), 245},
> +    { SCMP_SYS(accept4), 241 },
>  #endif
>      { SCMP_SYS(eventfd2), 245 },
>      { SCMP_SYS(dup), 245 },
> @@ -107,7 +108,25 @@ static const struct QemuSeccompSyscall
> seccomp_whitelist[] = { { SCMP_SYS(getsockname), 242 },
>      { SCMP_SYS(getpeername), 242 },
>      { SCMP_SYS(fdatasync), 242 },
> -    { SCMP_SYS(close), 242 }
> +    { SCMP_SYS(close), 242 },
> +    { SCMP_SYS(unlink), 241 },
> +    { SCMP_SYS(statfs), 241 },
> +    { SCMP_SYS(getuid), 241 },
> +    { SCMP_SYS(ftruncate), 241 },
> +    { SCMP_SYS(getegid), 241 },
> +    { SCMP_SYS(geteuid), 241 },
> +    { SCMP_SYS(getgid), 241 },
> +    { SCMP_SYS(getrlimit), 241 },
> +    { SCMP_SYS(set_tid_address), 241 },
> +    { SCMP_SYS(socketpair), 241 },
> +    { SCMP_SYS(fstatfs), 241 },
> +    { SCMP_SYS(epoll_create), 241 },
> +    { SCMP_SYS(epoll_ctl), 241 },
> +    { SCMP_SYS(epoll_wait), 241 },
> +    { SCMP_SYS(pipe), 241 },
> +    { SCMP_SYS(poll), 241 },
> +    { SCMP_SYS(rt_sigpending), 241 },
> +    { SCMP_SYS(rt_sigtimedwait), 241 },
>  };
> 
>  int seccomp_start(void)

-- 
paul moore
security and virtualization @ redhat

[-- Attachment #2: f16-test-1.xml --]
[-- Type: application/xml, Size: 2353 bytes --]

  parent reply	other threads:[~2012-09-26 20:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20 21:00 [Qemu-devel] [PATCH] New syscalls to the seccomp whitelist Eduardo Otubo
2012-09-21 11:21 ` Kevin Wolf
2012-09-21 12:40   ` Eduardo Otubo
2012-09-24 12:36     ` Eduardo Otubo
2012-09-26 16:55     ` Cole Robinson
2012-09-26 20:10     ` Paul Moore [this message]
2012-09-26 15:14 ` Paul Moore
2012-09-26 16:24   ` Eduardo Otubo
2012-09-26 16:42     ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2382564.6AYpmYLdf3@sifl \
    --to=pmoore@redhat.com \
    --cc=otubo@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.