From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Anton Vasilyev <vasilyev@ispras.ru>
Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>,
Miodrag Dinic <miodrag.dinic@mips.com>,
Goran Ferenc <goran.ferenc@mips.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] video: goldfishfb: fix memory leak on driver remove
Date: Tue, 24 Jul 2018 15:41:17 +0000 [thread overview]
Message-ID: <2385463.SiM69ykDI2@amdc3058> (raw)
In-Reply-To: <20180706120422.14628-1-vasilyev@ispras.ru>
On Friday, July 06, 2018 03:04:22 PM Anton Vasilyev wrote:
> goldfish_fb_probe() allocates memory for fb, but goldfish_fb_remove() does
> not have deallocation of fb, which leads to memory leak on probe/remove.
>
> The patch adds deallocation into goldfish_fb_remove().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Patch queued for 4.19, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Anton Vasilyev <vasilyev@ispras.ru>
Cc: Aleksandar Markovic <aleksandar.markovic@mips.com>,
Miodrag Dinic <miodrag.dinic@mips.com>,
Goran Ferenc <goran.ferenc@mips.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] video: goldfishfb: fix memory leak on driver remove
Date: Tue, 24 Jul 2018 17:41:17 +0200 [thread overview]
Message-ID: <2385463.SiM69ykDI2@amdc3058> (raw)
In-Reply-To: <20180706120422.14628-1-vasilyev@ispras.ru>
On Friday, July 06, 2018 03:04:22 PM Anton Vasilyev wrote:
> goldfish_fb_probe() allocates memory for fb, but goldfish_fb_remove() does
> not have deallocation of fb, which leads to memory leak on probe/remove.
>
> The patch adds deallocation into goldfish_fb_remove().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Patch queued for 4.19, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2018-07-24 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180706120501epcas5p3a2db5a74c3b4b0d2c8e102fbe3943de6@epcas5p3.samsung.com>
2018-07-06 12:04 ` [PATCH] video: goldfishfb: fix memory leak on driver remove Anton Vasilyev
2018-07-06 12:04 ` Anton Vasilyev
2018-07-24 15:41 ` Bartlomiej Zolnierkiewicz [this message]
2018-07-24 15:41 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2385463.SiM69ykDI2@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=aleksandar.markovic@mips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=goran.ferenc@mips.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miodrag.dinic@mips.com \
--cc=vasilyev@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.