From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: spock@gentoo.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: uvesafb: constify attribute_group structures.
Date: Tue, 01 Aug 2017 13:53:28 +0000 [thread overview]
Message-ID: <2391550.2naV14eqVs@amdc3058> (raw)
In-Reply-To: <aa3e89c4a81699a5e7799f9c20cc7a123e2fce37.1500441256.git.arvind.yadav.cs@gmail.com>
On Wednesday, July 19, 2017 10:46:55 AM Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 15426 4952 187 20565 5055 drivers/video/fbdev/uvesafb.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 15490 4888 187 20565 5055 drivers/video/fbdev/uvesafb.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: spock@gentoo.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: uvesafb: constify attribute_group structures.
Date: Tue, 01 Aug 2017 15:53:28 +0200 [thread overview]
Message-ID: <2391550.2naV14eqVs@amdc3058> (raw)
In-Reply-To: <aa3e89c4a81699a5e7799f9c20cc7a123e2fce37.1500441256.git.arvind.yadav.cs@gmail.com>
On Wednesday, July 19, 2017 10:46:55 AM Arvind Yadav wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 15426 4952 187 20565 5055 drivers/video/fbdev/uvesafb.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 15490 4888 187 20565 5055 drivers/video/fbdev/uvesafb.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2017-08-01 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170719051736epcas5p3b707e162f6741c876a069f0eb0768fd7@epcas5p3.samsung.com>
2017-07-19 5:16 ` [PATCH] video: fbdev: uvesafb: constify attribute_group structures Arvind Yadav
2017-07-19 5:28 ` Arvind Yadav
2017-08-01 13:53 ` Bartlomiej Zolnierkiewicz [this message]
2017-08-01 13:53 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2391550.2naV14eqVs@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spock@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.