All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: ulf.hansson@linaro.org, mark.rutland@arm.com,
	lpieralisi@kernel.org, sudeep.holla@arm.com,
	Robin Murphy <robin.murphy@arm.com>
Cc: linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] pmdomain: rockchip: Relax SMCCC dependency
Date: Tue, 20 May 2025 20:38:39 +0200	[thread overview]
Message-ID: <2393836.usQuhbGJ8B@phil> (raw)
In-Reply-To: <6f0a38e596c0727d0de13a29c9224f71bc7d30f1.1747760015.git.robin.murphy@arm.com>

Am Dienstag, 20. Mai 2025, 19:10:17 Mitteleuropäische Sommerzeit schrieb Robin Murphy:
> Most 32-bit Rockchip platforms do not use PSCI, so having to select
> ARM_PSCI to satisfy a dependency chain to retain working power domain
> support is a bit weird and non-obvious. Now that the offending SMCCC API
> is properly stubbed out for optional usage, we can relax this again.
> 
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>


Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Of course this needs patch1 of this series to get applied
first.

I think for bisectability, doing this directly in patch1 might
be less dangerous though?


Heiko

> ---
>  drivers/pmdomain/rockchip/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pmdomain/rockchip/Kconfig b/drivers/pmdomain/rockchip/Kconfig
> index 218d43186e5b..ffe5e7b78494 100644
> --- a/drivers/pmdomain/rockchip/Kconfig
> +++ b/drivers/pmdomain/rockchip/Kconfig
> @@ -4,7 +4,6 @@ if ARCH_ROCKCHIP || COMPILE_TEST
>  config ROCKCHIP_PM_DOMAINS
>  	bool "Rockchip generic power domain"
>  	depends on PM
> -	depends on HAVE_ARM_SMCCC_DISCOVERY
>  	depends on REGULATOR
>  	select PM_GENERIC_DOMAINS
>  	help
> 






WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: ulf.hansson@linaro.org, mark.rutland@arm.com,
	lpieralisi@kernel.org, sudeep.holla@arm.com,
	Robin Murphy <robin.murphy@arm.com>
Cc: linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] pmdomain: rockchip: Relax SMCCC dependency
Date: Tue, 20 May 2025 20:38:39 +0200	[thread overview]
Message-ID: <2393836.usQuhbGJ8B@phil> (raw)
In-Reply-To: <6f0a38e596c0727d0de13a29c9224f71bc7d30f1.1747760015.git.robin.murphy@arm.com>

Am Dienstag, 20. Mai 2025, 19:10:17 Mitteleuropäische Sommerzeit schrieb Robin Murphy:
> Most 32-bit Rockchip platforms do not use PSCI, so having to select
> ARM_PSCI to satisfy a dependency chain to retain working power domain
> support is a bit weird and non-obvious. Now that the offending SMCCC API
> is properly stubbed out for optional usage, we can relax this again.
> 
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>


Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Of course this needs patch1 of this series to get applied
first.

I think for bisectability, doing this directly in patch1 might
be less dangerous though?


Heiko

> ---
>  drivers/pmdomain/rockchip/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pmdomain/rockchip/Kconfig b/drivers/pmdomain/rockchip/Kconfig
> index 218d43186e5b..ffe5e7b78494 100644
> --- a/drivers/pmdomain/rockchip/Kconfig
> +++ b/drivers/pmdomain/rockchip/Kconfig
> @@ -4,7 +4,6 @@ if ARCH_ROCKCHIP || COMPILE_TEST
>  config ROCKCHIP_PM_DOMAINS
>  	bool "Rockchip generic power domain"
>  	depends on PM
> -	depends on HAVE_ARM_SMCCC_DISCOVERY
>  	depends on REGULATOR
>  	select PM_GENERIC_DOMAINS
>  	help
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-05-20 18:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-20 17:10 [PATCH 1/2] firmware: smccc: Stub out get_conduit() Robin Murphy
2025-05-20 17:10 ` Robin Murphy
2025-05-20 17:10 ` [PATCH 2/2] pmdomain: rockchip: Relax SMCCC dependency Robin Murphy
2025-05-20 17:10   ` Robin Murphy
2025-05-20 18:38   ` Heiko Stuebner [this message]
2025-05-20 18:38     ` Heiko Stuebner
2025-05-21 11:41     ` Ulf Hansson
2025-05-21 11:41       ` Ulf Hansson
2025-05-21 11:57       ` Robin Murphy
2025-05-21 11:57         ` Robin Murphy
2025-05-21  5:07   ` Urja
2025-05-21  5:07     ` Urja
2025-05-20 18:36 ` [PATCH 1/2] firmware: smccc: Stub out get_conduit() Heiko Stuebner
2025-05-20 18:36   ` Heiko Stuebner
2025-05-21 11:28 ` Ulf Hansson
2025-05-21 11:28   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2393836.usQuhbGJ8B@phil \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robin.murphy@arm.com \
    --cc=sudeep.holla@arm.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.