All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: renesas: r8a7796: Add FDP clock
@ 2018-01-02 15:21 Geert Uytterhoeven
  2018-01-02 15:54 ` Laurent Pinchart
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2018-01-02 15:21 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Laurent Pinchart
  Cc: linux-clk, linux-renesas-soc, ABE Hiroshige, Takeshi Kihara,
	Geert Uytterhoeven

From: ABE Hiroshige <hiroshige.abe.zc@renesas.com>

This patch adds FDP1-0 clock to the R8A7796 SoC.

Signed-off-by: ABE Hiroshige <hiroshige.abe.zc@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
[geert: s/fdp0/fdp1-0/]
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This gets rid of the following error messages during boot and system
resume:

    renesas-cpg-mssr e6150000.clock-controller: Cannot get module clock 119: -2
    rcar_fdp1 fe940000.fdp1: failed to add to PM domain a3vc: -2

To be queued in clk-renesas-for-v4.16.
---
 drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
index 83a68e51e4ec1d12..dfb267a92f2a20d3 100644
--- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
@@ -117,6 +117,7 @@ static const struct cpg_core_clk r8a7796_core_clks[] __initconst = {
 };
 
 static const struct mssr_mod_clk r8a7796_mod_clks[] __initconst = {
+	DEF_MOD("fdp1-0",		 119,	R8A7796_CLK_S0D1),
 	DEF_MOD("scif5",		 202,	R8A7796_CLK_S3D4),
 	DEF_MOD("scif4",		 203,	R8A7796_CLK_S3D4),
 	DEF_MOD("scif3",		 204,	R8A7796_CLK_S3D4),
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: renesas: r8a7796: Add FDP clock
  2018-01-02 15:21 [PATCH] clk: renesas: r8a7796: Add FDP clock Geert Uytterhoeven
@ 2018-01-02 15:54 ` Laurent Pinchart
  2018-01-04 10:38   ` Geert Uytterhoeven
  0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2018-01-02 15:54 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Michael Turquette, Stephen Boyd, Laurent Pinchart, linux-clk,
	linux-renesas-soc, ABE Hiroshige, Takeshi Kihara

Hi Geert,

Thank you for the patch.

On Tuesday, 2 January 2018 17:21:43 EET Geert Uytterhoeven wrote:
> From: ABE Hiroshige <hiroshige.abe.zc@renesas.com>
> 
> This patch adds FDP1-0 clock to the R8A7796 SoC.
> 
> Signed-off-by: ABE Hiroshige <hiroshige.abe.zc@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> [geert: s/fdp0/fdp1-0/]
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

I can't verify the parent clock, but apart from that,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> This gets rid of the following error messages during boot and system
> resume:
> 
>     renesas-cpg-mssr e6150000.clock-controller: Cannot get module clock 119:
> -2 rcar_fdp1 fe940000.fdp1: failed to add to PM domain a3vc: -2
> 
> To be queued in clk-renesas-for-v4.16.
> ---
>  drivers/clk/renesas/r8a7796-cpg-mssr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c
> b/drivers/clk/renesas/r8a7796-cpg-mssr.c index
> 83a68e51e4ec1d12..dfb267a92f2a20d3 100644
> --- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
> @@ -117,6 +117,7 @@ static const struct cpg_core_clk r8a7796_core_clks[]
> __initconst = { };
> 
>  static const struct mssr_mod_clk r8a7796_mod_clks[] __initconst = {
> +	DEF_MOD("fdp1-0",		 119,	R8A7796_CLK_S0D1),
>  	DEF_MOD("scif5",		 202,	R8A7796_CLK_S3D4),
>  	DEF_MOD("scif4",		 203,	R8A7796_CLK_S3D4),
>  	DEF_MOD("scif3",		 204,	R8A7796_CLK_S3D4),

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: renesas: r8a7796: Add FDP clock
  2018-01-02 15:54 ` Laurent Pinchart
@ 2018-01-04 10:38   ` Geert Uytterhoeven
  0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2018-01-04 10:38 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: Geert Uytterhoeven, Michael Turquette, Stephen Boyd,
	Laurent Pinchart, linux-clk, Linux-Renesas, ABE Hiroshige,
	Takeshi Kihara

On Tue, Jan 2, 2018 at 4:54 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Tuesday, 2 January 2018 17:21:43 EET Geert Uytterhoeven wrote:
>> From: ABE Hiroshige <hiroshige.abe.zc@renesas.com>
>>
>> This patch adds FDP1-0 clock to the R8A7796 SoC.
>>
>> Signed-off-by: ABE Hiroshige <hiroshige.abe.zc@renesas.com>
>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>> [geert: s/fdp0/fdp1-0/]
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> I can't verify the parent clock, but apart from that,
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Applied with Laurent's ack, and queued in clk-renesas-for-v4.16.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-01-04 10:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-02 15:21 [PATCH] clk: renesas: r8a7796: Add FDP clock Geert Uytterhoeven
2018-01-02 15:54 ` Laurent Pinchart
2018-01-04 10:38   ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.