From: Paul Moore <paul@paul-moore.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org,
James Morris <james.l.morris@oracle.com>
Subject: Re: [PATCH v2 1/1] selinux: use absolute path to include directory
Date: Tue, 19 Jan 2016 16:19:34 -0500 [thread overview]
Message-ID: <2400530.bhohIrbhWL@sifl> (raw)
In-Reply-To: <1453223272-120888-1-git-send-email-andriy.shevchenko@linux.intel.com>
On Tuesday, January 19, 2016 07:07:52 PM Andy Shevchenko wrote:
> diff --git a/security/selinux/Makefile b/security/selinux/Makefile
> index ad5cd76..b850811 100644
> --- a/security/selinux/Makefile
> +++ b/security/selinux/Makefile
> @@ -13,7 +13,7 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
>
> selinux-$(CONFIG_NETLABEL) += netlabel.o
>
> -ccflags-y := -Isecurity/selinux -Isecurity/selinux/include
> +ccflags-y := -I$(srctree)security/selinux I$(srctree)/security/...
You are missing a "/" after "$(srctree)".
Please make sure that your patches compile and pass basic functionality before
submitting; I don't care how trivial they may be, we all make the occasional
mistake, and a basic compile/boot test does wonders for catching a lot of
these stupid mistakes.
> $(addprefix $(obj)/,$(selinux-y)): $(obj)/flask.h
--
paul moore
www.paul-moore.com
prev parent reply other threads:[~2016-01-19 21:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 17:07 [PATCH v2 1/1] selinux: use absolute path to include directory Andy Shevchenko
2016-01-19 21:19 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2400530.bhohIrbhWL@sifl \
--to=paul@paul-moore.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=james.l.morris@oracle.com \
--cc=linux-security-module@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.