[PATCH v2 1/1] selinux: use absolute path to include directory

[PATCH v2 1/1] selinux: use absolute path to include directory

[Andy Shevchenko]

Compiler warns us a lot that it can't find include folder because it's provided
in relative form.

  CC      security/selinux/netlabel.o
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]

Add $(srctree) prefix to the path.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2:
- apply change for all -I occurences
 security/selinux/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/selinux/Makefile b/security/selinux/Makefile
index ad5cd76..b850811 100644
--- a/security/selinux/Makefile
+++ b/security/selinux/Makefile
@@ -13,7 +13,7 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
 
 selinux-$(CONFIG_NETLABEL) += netlabel.o
 
-ccflags-y := -Isecurity/selinux -Isecurity/selinux/include
+ccflags-y := -I$(srctree)security/selinux -I$(srctree)/security/selinux/include
 
 $(addprefix $(obj)/,$(selinux-y)): $(obj)/flask.h
 
-- 
2.7.0.rc3

Re: [PATCH v2 1/1] selinux: use absolute path to include directory

[Paul Moore]

On Tuesday, January 19, 2016 07:07:52 PM Andy Shevchenko wrote:
> diff --git a/security/selinux/Makefile b/security/selinux/Makefile
> index ad5cd76..b850811 100644
> --- a/security/selinux/Makefile
> +++ b/security/selinux/Makefile
> @@ -13,7 +13,7 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
> 
>  selinux-$(CONFIG_NETLABEL) += netlabel.o
> 
> -ccflags-y := -Isecurity/selinux -Isecurity/selinux/include
> +ccflags-y := -I$(srctree)security/selinux I$(srctree)/security/...

You are missing a "/" after "$(srctree)".

Please make sure that your patches compile and pass basic functionality before 
submitting; I don't care how trivial they may be, we all make the occasional 
mistake, and a basic compile/boot test does wonders for catching a lot of 
these stupid mistakes.

>  $(addprefix $(obj)/,$(selinux-y)): $(obj)/flask.h

-- 
paul moore
www.paul-moore.com