All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: Christoph Raisch <RAISCH@de.ibm.com>
Cc: Thomas Q Klein <TKLEIN@de.ibm.com>,
	ossthema@linux.vnet.ibm.com, Jeff Garzik <jeff@garzik.org>,
	Jan-Bernd Themann <THEMANN@de.ibm.com>,
	netdev <netdev@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-ppc <linuxppc-dev@ozlabs.org>,
	Marcus Eder <MEDER@de.ibm.com>,
	Stefan Roscher <stefan.roscher@de.ibm.com>
Subject: Re: [PATCH] ehea: add kexec support
Date: Sat, 03 Nov 2007 17:06:31 +1100	[thread overview]
Message-ID: <24042.1194069991@neuling.org> (raw)
In-Reply-To: <OF3FAFDB41.AF236738-ONC1257387.00376233-C1257387.00389861@de.ibm.com>

> Michael Ellerman <michael@ellerman.id.au> wrote on 02.11.2007 07:30:08:
> 
> > On Wed, 2007-10-31 at 20:48 +0100, Christoph Raisch wrote:
> > > Michael Ellerman <michael@ellerman.id.au> wrote on 30.10.2007 23:50:36:
> > If that's really the way it works then eHEA is more or less broken for
> > kdump I'm afraid.
> 
> We think we have a way to workaround this, but let me first try to
> explain the base problem.
> 
> DD allocates HEA resources and gets firmware_handles for these resources.
> To free the resources DD needs to use exactly these handles.
> There's no generic firmware call "clean out all resources".
> Allocating the same resources twice does not work.

Can we get a new firmware call to do this?  

> So a new kernel can't free the resources allocated by an old kernel,
> because the numeric values of the handles aren't known anymore.

How many possible handles are there?  

If the handles are lost, is the only way to clear out the HEA resources
is to reset the partition?

> Potential Solution:
> Hea driver cleanup function hooks into ppc_md.machine_crash_shutdown
> and frees all firmware resources at shutdown time of the crashed kernel.

This means the crashed kernel now has to be trusted to shut down and
free up the resources.  Isn't trusting the crashing kernel in this way
against the whole kdump idea?

> crash_kexec continues and loads new kernel.
> The new kernel restarts the HEA driver within kdump kernel, which will work
> because resources have been freed before.
> 
> Michael, would this work?
> 
> Gruss / Regards
> Christoph R.
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
> 

WARNING: multiple messages have this Message-ID (diff)
From: Michael Neuling <mikey@neuling.org>
To: Christoph Raisch <RAISCH@de.ibm.com>
Cc: michael@ellerman.id.au, Thomas Q Klein <TKLEIN@de.ibm.com>,
	ossthema@linux.vnet.ibm.com, Jeff Garzik <jeff@garzik.org>,
	Jan-Bernd Themann <THEMANN@de.ibm.com>,
	netdev <netdev@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-ppc <linuxppc-dev@ozlabs.org>,
	Marcus Eder <MEDER@de.ibm.com>,
	Stefan Roscher <stefan.roscher@de.ibm.com>
Subject: Re: [PATCH] ehea: add kexec support
Date: Sat, 03 Nov 2007 17:06:31 +1100	[thread overview]
Message-ID: <24042.1194069991@neuling.org> (raw)
In-Reply-To: <OF3FAFDB41.AF236738-ONC1257387.00376233-C1257387.00389861@de.ibm.com>

> Michael Ellerman <michael@ellerman.id.au> wrote on 02.11.2007 07:30:08:
> 
> > On Wed, 2007-10-31 at 20:48 +0100, Christoph Raisch wrote:
> > > Michael Ellerman <michael@ellerman.id.au> wrote on 30.10.2007 23:50:36:
> > If that's really the way it works then eHEA is more or less broken for
> > kdump I'm afraid.
> 
> We think we have a way to workaround this, but let me first try to
> explain the base problem.
> 
> DD allocates HEA resources and gets firmware_handles for these resources.
> To free the resources DD needs to use exactly these handles.
> There's no generic firmware call "clean out all resources".
> Allocating the same resources twice does not work.

Can we get a new firmware call to do this?  

> So a new kernel can't free the resources allocated by an old kernel,
> because the numeric values of the handles aren't known anymore.

How many possible handles are there?  

If the handles are lost, is the only way to clear out the HEA resources
is to reset the partition?

> Potential Solution:
> Hea driver cleanup function hooks into ppc_md.machine_crash_shutdown
> and frees all firmware resources at shutdown time of the crashed kernel.

This means the crashed kernel now has to be trusted to shut down and
free up the resources.  Isn't trusting the crashing kernel in this way
against the whole kdump idea?

> crash_kexec continues and loads new kernel.
> The new kernel restarts the HEA driver within kdump kernel, which will work
> because resources have been freed before.
> 
> Michael, would this work?
> 
> Gruss / Regards
> Christoph R.
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
> 

  reply	other threads:[~2007-11-03  6:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-26 12:37 [PATCH] ehea: add kexec support Jan-Bernd Themann
2007-10-26 12:37 ` Jan-Bernd Themann
2007-10-28 22:32 ` Michael Ellerman
2007-10-28 22:32   ` Michael Ellerman
2007-10-30  8:39   ` Christoph Raisch
2007-10-30  8:39     ` Christoph Raisch
2007-10-30 22:50     ` Michael Ellerman
2007-10-30 22:50       ` Michael Ellerman
2007-10-31 19:48       ` Christoph Raisch
2007-10-31 19:48         ` Christoph Raisch
2007-11-02  6:30         ` Michael Ellerman
2007-11-02  6:30           ` Michael Ellerman
2007-11-02 10:19           ` Christoph Raisch
2007-11-02 10:19             ` Christoph Raisch
2007-11-03  6:06             ` Michael Neuling [this message]
2007-11-03  6:06               ` Michael Neuling
2007-11-05 14:24               ` Christoph Raisch
2007-11-05 14:24                 ` Christoph Raisch
2007-10-29  9:47 ` Jeff Garzik
2007-10-29  9:47   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24042.1194069991@neuling.org \
    --to=mikey@neuling.org \
    --cc=MEDER@de.ibm.com \
    --cc=RAISCH@de.ibm.com \
    --cc=THEMANN@de.ibm.com \
    --cc=TKLEIN@de.ibm.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=ossthema@linux.vnet.ibm.com \
    --cc=stefan.roscher@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.