* [PATCH/RFC] v4l: vsp1: Add format for Mem2Mem Playback
@ 2014-12-20 14:16 ` Yoshihiro Kaneko
0 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Kaneko @ 2014-12-20 14:16 UTC (permalink / raw)
To: linux-media
Cc: Mauro Carvalho Chehab, Laurent Pinchart, Simon Horman,
Magnus Damm, linux-sh
From: Hiroki Negishi <hiroki.negishi.zr@hitachi-solutions.com>
Signed-off-by: Hiroki Negishi <hiroki.negishi.zr@hitachi-solutions.com>
Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
This patch is based on the master branch of linuxtv.org/media_tree.git.
drivers/media/platform/vsp1/vsp1_video.c | 3 +++
include/uapi/linux/videodev2.h | 3 +++
2 files changed, 6 insertions(+)
diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c
index e512336..9bbc02a 100644
--- a/drivers/media/platform/vsp1/vsp1_video.c
+++ b/drivers/media/platform/vsp1/vsp1_video.c
@@ -130,6 +130,9 @@ static const struct vsp1_format_info vsp1_video_formats[] = {
VI6_FMT_Y_U_V_420, VI6_RPF_DSWAP_P_LLS | VI6_RPF_DSWAP_P_LWS |
VI6_RPF_DSWAP_P_WDS | VI6_RPF_DSWAP_P_BTS,
3, { 8, 8, 8 }, false, false, 2, 2, false },
+ { V4L2_PIX_FMT_RGB32S, MEDIA_BUS_FMT_ARGB8888_1X32,
+ VI6_FMT_ARGB_8888, VI6_RPF_DSWAP_P_LLS | VI6_RPF_DSWAP_P_LWS,
+ 1, { 32, 0, 0 }, false, false, 1, 1, false },
};
/*
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index d279c1b..f22e167 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -396,6 +396,9 @@ struct v4l2_pix_format {
#define V4L2_PIX_FMT_ARGB32 v4l2_fourcc('B', 'A', '2', '4') /* 32 ARGB-8-8-8-8 */
#define V4L2_PIX_FMT_XRGB32 v4l2_fourcc('B', 'X', '2', '4') /* 32 XRGB-8-8-8-8 */
+/* RGB formats for memory output */
+#define V4L2_PIX_FMT_RGB32S v4l2_fourcc('R', 'G', '4', 'S') /* 32 RGB-8-8-8-8 */
+
/* Grey formats */
#define V4L2_PIX_FMT_GREY v4l2_fourcc('G', 'R', 'E', 'Y') /* 8 Greyscale */
#define V4L2_PIX_FMT_Y4 v4l2_fourcc('Y', '0', '4', ' ') /* 4 Greyscale */
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH/RFC] v4l: vsp1: Add format for Mem2Mem Playback
@ 2014-12-20 14:16 ` Yoshihiro Kaneko
0 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Kaneko @ 2014-12-20 14:16 UTC (permalink / raw)
To: linux-media
Cc: Mauro Carvalho Chehab, Laurent Pinchart, Simon Horman,
Magnus Damm, linux-sh
From: Hiroki Negishi <hiroki.negishi.zr@hitachi-solutions.com>
Signed-off-by: Hiroki Negishi <hiroki.negishi.zr@hitachi-solutions.com>
Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
This patch is based on the master branch of linuxtv.org/media_tree.git.
drivers/media/platform/vsp1/vsp1_video.c | 3 +++
include/uapi/linux/videodev2.h | 3 +++
2 files changed, 6 insertions(+)
diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c
index e512336..9bbc02a 100644
--- a/drivers/media/platform/vsp1/vsp1_video.c
+++ b/drivers/media/platform/vsp1/vsp1_video.c
@@ -130,6 +130,9 @@ static const struct vsp1_format_info vsp1_video_formats[] = {
VI6_FMT_Y_U_V_420, VI6_RPF_DSWAP_P_LLS | VI6_RPF_DSWAP_P_LWS |
VI6_RPF_DSWAP_P_WDS | VI6_RPF_DSWAP_P_BTS,
3, { 8, 8, 8 }, false, false, 2, 2, false },
+ { V4L2_PIX_FMT_RGB32S, MEDIA_BUS_FMT_ARGB8888_1X32,
+ VI6_FMT_ARGB_8888, VI6_RPF_DSWAP_P_LLS | VI6_RPF_DSWAP_P_LWS,
+ 1, { 32, 0, 0 }, false, false, 1, 1, false },
};
/*
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index d279c1b..f22e167 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -396,6 +396,9 @@ struct v4l2_pix_format {
#define V4L2_PIX_FMT_ARGB32 v4l2_fourcc('B', 'A', '2', '4') /* 32 ARGB-8-8-8-8 */
#define V4L2_PIX_FMT_XRGB32 v4l2_fourcc('B', 'X', '2', '4') /* 32 XRGB-8-8-8-8 */
+/* RGB formats for memory output */
+#define V4L2_PIX_FMT_RGB32S v4l2_fourcc('R', 'G', '4', 'S') /* 32 RGB-8-8-8-8 */
+
/* Grey formats */
#define V4L2_PIX_FMT_GREY v4l2_fourcc('G', 'R', 'E', 'Y') /* 8 Greyscale */
#define V4L2_PIX_FMT_Y4 v4l2_fourcc('Y', '0', '4', ' ') /* 4 Greyscale */
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH/RFC] v4l: vsp1: Add format for Mem2Mem Playback
2014-12-20 14:16 ` Yoshihiro Kaneko
@ 2014-12-20 18:35 ` Laurent Pinchart
-1 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2014-12-20 18:35 UTC (permalink / raw)
To: Yoshihiro Kaneko
Cc: linux-media, Mauro Carvalho Chehab, Laurent Pinchart,
Simon Horman, Magnus Damm, linux-sh
Hello Kaneko-san,
Thank you for the patch.
On Saturday 20 December 2014 23:16:03 Yoshihiro Kaneko wrote:
> From: Hiroki Negishi <hiroki.negishi.zr@hitachi-solutions.com>
>
> Signed-off-by: Hiroki Negishi <hiroki.negishi.zr@hitachi-solutions.com>
> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
>
> This patch is based on the master branch of linuxtv.org/media_tree.git.
>
> drivers/media/platform/vsp1/vsp1_video.c | 3 +++
> include/uapi/linux/videodev2.h | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_video.c
> b/drivers/media/platform/vsp1/vsp1_video.c index e512336..9bbc02a 100644
> --- a/drivers/media/platform/vsp1/vsp1_video.c
> +++ b/drivers/media/platform/vsp1/vsp1_video.c
> @@ -130,6 +130,9 @@ static const struct vsp1_format_info
> vsp1_video_formats[] = { VI6_FMT_Y_U_V_420, VI6_RPF_DSWAP_P_LLS |
> VI6_RPF_DSWAP_P_LWS | VI6_RPF_DSWAP_P_WDS | VI6_RPF_DSWAP_P_BTS,
> 3, { 8, 8, 8 }, false, false, 2, 2, false },
> + { V4L2_PIX_FMT_RGB32S, MEDIA_BUS_FMT_ARGB8888_1X32,
> + VI6_FMT_ARGB_8888, VI6_RPF_DSWAP_P_LLS | VI6_RPF_DSWAP_P_LWS,
> + 1, { 32, 0, 0 }, false, false, 1, 1, false },
> };
>
> /*
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index d279c1b..f22e167 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -396,6 +396,9 @@ struct v4l2_pix_format {
> #define V4L2_PIX_FMT_ARGB32 v4l2_fourcc('B', 'A', '2', '4') /* 32
> ARGB-8-8-8-8 */ #define V4L2_PIX_FMT_XRGB32 v4l2_fourcc('B', 'X', '2',
> '4') /* 32 XRGB-8-8-8-8 */
>
> +/* RGB formats for memory output */
> +#define V4L2_PIX_FMT_RGB32S v4l2_fourcc('R', 'G', '4', 'S') /* 32
> RGB-8-8-8-8 */ +
When adding a new format V4L2 also requires a documentation update to describe
the format. I assume your format falls in the category of packed RGB formats,
could you thus please update Documentation/DocBook/media/v4l/pixfmt-packed-
rgb.xml in this patch as well ?
> /* Grey formats */
> #define V4L2_PIX_FMT_GREY v4l2_fourcc('G', 'R', 'E', 'Y') /* 8
> Greyscale */ #define V4L2_PIX_FMT_Y4 v4l2_fourcc('Y', '0', '4', '
> ') /* 4 Greyscale */
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH/RFC] v4l: vsp1: Add format for Mem2Mem Playback
@ 2014-12-20 18:35 ` Laurent Pinchart
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2014-12-20 18:35 UTC (permalink / raw)
To: Yoshihiro Kaneko
Cc: linux-media, Mauro Carvalho Chehab, Laurent Pinchart,
Simon Horman, Magnus Damm, linux-sh
Hello Kaneko-san,
Thank you for the patch.
On Saturday 20 December 2014 23:16:03 Yoshihiro Kaneko wrote:
> From: Hiroki Negishi <hiroki.negishi.zr@hitachi-solutions.com>
>
> Signed-off-by: Hiroki Negishi <hiroki.negishi.zr@hitachi-solutions.com>
> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
>
> This patch is based on the master branch of linuxtv.org/media_tree.git.
>
> drivers/media/platform/vsp1/vsp1_video.c | 3 +++
> include/uapi/linux/videodev2.h | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_video.c
> b/drivers/media/platform/vsp1/vsp1_video.c index e512336..9bbc02a 100644
> --- a/drivers/media/platform/vsp1/vsp1_video.c
> +++ b/drivers/media/platform/vsp1/vsp1_video.c
> @@ -130,6 +130,9 @@ static const struct vsp1_format_info
> vsp1_video_formats[] = { VI6_FMT_Y_U_V_420, VI6_RPF_DSWAP_P_LLS |
> VI6_RPF_DSWAP_P_LWS | VI6_RPF_DSWAP_P_WDS | VI6_RPF_DSWAP_P_BTS,
> 3, { 8, 8, 8 }, false, false, 2, 2, false },
> + { V4L2_PIX_FMT_RGB32S, MEDIA_BUS_FMT_ARGB8888_1X32,
> + VI6_FMT_ARGB_8888, VI6_RPF_DSWAP_P_LLS | VI6_RPF_DSWAP_P_LWS,
> + 1, { 32, 0, 0 }, false, false, 1, 1, false },
> };
>
> /*
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index d279c1b..f22e167 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -396,6 +396,9 @@ struct v4l2_pix_format {
> #define V4L2_PIX_FMT_ARGB32 v4l2_fourcc('B', 'A', '2', '4') /* 32
> ARGB-8-8-8-8 */ #define V4L2_PIX_FMT_XRGB32 v4l2_fourcc('B', 'X', '2',
> '4') /* 32 XRGB-8-8-8-8 */
>
> +/* RGB formats for memory output */
> +#define V4L2_PIX_FMT_RGB32S v4l2_fourcc('R', 'G', '4', 'S') /* 32
> RGB-8-8-8-8 */ +
When adding a new format V4L2 also requires a documentation update to describe
the format. I assume your format falls in the category of packed RGB formats,
could you thus please update Documentation/DocBook/media/v4l/pixfmt-packed-
rgb.xml in this patch as well ?
> /* Grey formats */
> #define V4L2_PIX_FMT_GREY v4l2_fourcc('G', 'R', 'E', 'Y') /* 8
> Greyscale */ #define V4L2_PIX_FMT_Y4 v4l2_fourcc('Y', '0', '4', '
> ') /* 4 Greyscale */
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH/RFC] v4l: vsp1: Add format for Mem2Mem Playback
2014-12-20 18:35 ` Laurent Pinchart
@ 2014-12-23 8:20 ` Yoshihiro Kaneko
-1 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Kaneko @ 2014-12-23 8:20 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Linux Media Mailing List, Mauro Carvalho Chehab, Laurent Pinchart,
Simon Horman, Magnus Damm, Linux-sh list
Hi Laurent-san,
Thanks for your comment.
2014-12-21 3:35 GMT+09:00 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> Hello Kaneko-san,
>
> Thank you for the patch.
>
>
> On Saturday 20 December 2014 23:16:03 Yoshihiro Kaneko wrote:
>> From: Hiroki Negishi <hiroki.negishi.zr@hitachi-solutions.com>
>>
>> Signed-off-by: Hiroki Negishi <hiroki.negishi.zr@hitachi-solutions.com>
>> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> ---
>>
>> This patch is based on the master branch of linuxtv.org/media_tree.git.
>>
>> drivers/media/platform/vsp1/vsp1_video.c | 3 +++
>> include/uapi/linux/videodev2.h | 3 +++
>> 2 files changed, 6 insertions(+)
>>
>> diff --git a/drivers/media/platform/vsp1/vsp1_video.c
>> b/drivers/media/platform/vsp1/vsp1_video.c index e512336..9bbc02a 100644
>> --- a/drivers/media/platform/vsp1/vsp1_video.c
>> +++ b/drivers/media/platform/vsp1/vsp1_video.c
>> @@ -130,6 +130,9 @@ static const struct vsp1_format_info
>> vsp1_video_formats[] = { VI6_FMT_Y_U_V_420, VI6_RPF_DSWAP_P_LLS |
>> VI6_RPF_DSWAP_P_LWS | VI6_RPF_DSWAP_P_WDS | VI6_RPF_DSWAP_P_BTS,
>> 3, { 8, 8, 8 }, false, false, 2, 2, false },
>> + { V4L2_PIX_FMT_RGB32S, MEDIA_BUS_FMT_ARGB8888_1X32,
>> + VI6_FMT_ARGB_8888, VI6_RPF_DSWAP_P_LLS | VI6_RPF_DSWAP_P_LWS,
>> + 1, { 32, 0, 0 }, false, false, 1, 1, false },
>> };
>>
>> /*
>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
>> index d279c1b..f22e167 100644
>> --- a/include/uapi/linux/videodev2.h
>> +++ b/include/uapi/linux/videodev2.h
>> @@ -396,6 +396,9 @@ struct v4l2_pix_format {
>> #define V4L2_PIX_FMT_ARGB32 v4l2_fourcc('B', 'A', '2', '4') /* 32
>> ARGB-8-8-8-8 */ #define V4L2_PIX_FMT_XRGB32 v4l2_fourcc('B', 'X', '2',
>> '4') /* 32 XRGB-8-8-8-8 */
>>
>> +/* RGB formats for memory output */
>> +#define V4L2_PIX_FMT_RGB32S v4l2_fourcc('R', 'G', '4', 'S') /* 32
>> RGB-8-8-8-8 */ +
>
> When adding a new format V4L2 also requires a documentation update to describe
> the format. I assume your format falls in the category of packed RGB formats,
> could you thus please update Documentation/DocBook/media/v4l/pixfmt-packed-
> rgb.xml in this patch as well ?
Thank you very much for your advice.
I'll look into the documentation and update this patch.
Thanks,
Kaneko
>
>> /* Grey formats */
>> #define V4L2_PIX_FMT_GREY v4l2_fourcc('G', 'R', 'E', 'Y') /* 8
>> Greyscale */ #define V4L2_PIX_FMT_Y4 v4l2_fourcc('Y', '0', '4', '
>> ') /* 4 Greyscale */
>
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH/RFC] v4l: vsp1: Add format for Mem2Mem Playback
@ 2014-12-23 8:20 ` Yoshihiro Kaneko
0 siblings, 0 replies; 6+ messages in thread
From: Yoshihiro Kaneko @ 2014-12-23 8:20 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Linux Media Mailing List, Mauro Carvalho Chehab, Laurent Pinchart,
Simon Horman, Magnus Damm, Linux-sh list
Hi Laurent-san,
Thanks for your comment.
2014-12-21 3:35 GMT+09:00 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> Hello Kaneko-san,
>
> Thank you for the patch.
>
>
> On Saturday 20 December 2014 23:16:03 Yoshihiro Kaneko wrote:
>> From: Hiroki Negishi <hiroki.negishi.zr@hitachi-solutions.com>
>>
>> Signed-off-by: Hiroki Negishi <hiroki.negishi.zr@hitachi-solutions.com>
>> Signed-off-by: Yoshifumi Hosoya <yoshifumi.hosoya.wj@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> ---
>>
>> This patch is based on the master branch of linuxtv.org/media_tree.git.
>>
>> drivers/media/platform/vsp1/vsp1_video.c | 3 +++
>> include/uapi/linux/videodev2.h | 3 +++
>> 2 files changed, 6 insertions(+)
>>
>> diff --git a/drivers/media/platform/vsp1/vsp1_video.c
>> b/drivers/media/platform/vsp1/vsp1_video.c index e512336..9bbc02a 100644
>> --- a/drivers/media/platform/vsp1/vsp1_video.c
>> +++ b/drivers/media/platform/vsp1/vsp1_video.c
>> @@ -130,6 +130,9 @@ static const struct vsp1_format_info
>> vsp1_video_formats[] = { VI6_FMT_Y_U_V_420, VI6_RPF_DSWAP_P_LLS |
>> VI6_RPF_DSWAP_P_LWS | VI6_RPF_DSWAP_P_WDS | VI6_RPF_DSWAP_P_BTS,
>> 3, { 8, 8, 8 }, false, false, 2, 2, false },
>> + { V4L2_PIX_FMT_RGB32S, MEDIA_BUS_FMT_ARGB8888_1X32,
>> + VI6_FMT_ARGB_8888, VI6_RPF_DSWAP_P_LLS | VI6_RPF_DSWAP_P_LWS,
>> + 1, { 32, 0, 0 }, false, false, 1, 1, false },
>> };
>>
>> /*
>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
>> index d279c1b..f22e167 100644
>> --- a/include/uapi/linux/videodev2.h
>> +++ b/include/uapi/linux/videodev2.h
>> @@ -396,6 +396,9 @@ struct v4l2_pix_format {
>> #define V4L2_PIX_FMT_ARGB32 v4l2_fourcc('B', 'A', '2', '4') /* 32
>> ARGB-8-8-8-8 */ #define V4L2_PIX_FMT_XRGB32 v4l2_fourcc('B', 'X', '2',
>> '4') /* 32 XRGB-8-8-8-8 */
>>
>> +/* RGB formats for memory output */
>> +#define V4L2_PIX_FMT_RGB32S v4l2_fourcc('R', 'G', '4', 'S') /* 32
>> RGB-8-8-8-8 */ +
>
> When adding a new format V4L2 also requires a documentation update to describe
> the format. I assume your format falls in the category of packed RGB formats,
> could you thus please update Documentation/DocBook/media/v4l/pixfmt-packed-
> rgb.xml in this patch as well ?
Thank you very much for your advice.
I'll look into the documentation and update this patch.
Thanks,
Kaneko
>
>> /* Grey formats */
>> #define V4L2_PIX_FMT_GREY v4l2_fourcc('G', 'R', 'E', 'Y') /* 8
>> Greyscale */ #define V4L2_PIX_FMT_Y4 v4l2_fourcc('Y', '0', '4', '
>> ') /* 4 Greyscale */
>
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-23 8:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-20 14:16 [PATCH/RFC] v4l: vsp1: Add format for Mem2Mem Playback Yoshihiro Kaneko
2014-12-20 14:16 ` Yoshihiro Kaneko
2014-12-20 18:35 ` Laurent Pinchart
2014-12-20 18:35 ` Laurent Pinchart
2014-12-23 8:20 ` Yoshihiro Kaneko
2014-12-23 8:20 ` Yoshihiro Kaneko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.