From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: jroedel-l3A5Bk7waGM@public.gmane.org,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Laurent Pinchart
<laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
Alexandre Courbot
<acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH URGENT] arm: dma-mapping: Set DMA IOMMU ops in arm_iommu_attach_device()
Date: Fri, 23 Jan 2015 17:55:25 +0200 [thread overview]
Message-ID: <2416515.WUUq1g4kPD@avalon> (raw)
In-Reply-To: <10179212.ryUUVC9zEx@wuerfel>
Hi Arnd,
On Friday 23 January 2015 16:27:24 Arnd Bergmann wrote:
> On Friday 23 January 2015 16:21:49 Laurent Pinchart wrote:
> > +/**
> > + * arm_iommu_detach_device
> > + * @dev: valid struct device pointer
> > + *
> > + * Detaches the provided device from a previously attached map.
> > + * This voids the dma operations (dma_map_ops pointer)
> > + */
> > +void arm_iommu_detach_device(struct device *dev)
> > +{
> > + __arm_iommu_detach_device(dev);
> > + set_dma_ops(dev, NULL);
> > +}
> >
> > EXPORT_SYMBOL_GPL(arm_iommu_detach_device);
>
> Would this introduce a regression in the case where the device is
> cache coherent and needs arm_coherent_dma_ops set?
I think we need to handle that case (as well as the coherent IOMMU case in
arm_iommu_attach_device), but this patch only tries to restore the previous
behaviour to fix the bug detailed in the commit message. Would you prefer
fixing both issues in one go ?
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH URGENT] arm: dma-mapping: Set DMA IOMMU ops in arm_iommu_attach_device()
Date: Fri, 23 Jan 2015 17:55:25 +0200 [thread overview]
Message-ID: <2416515.WUUq1g4kPD@avalon> (raw)
In-Reply-To: <10179212.ryUUVC9zEx@wuerfel>
Hi Arnd,
On Friday 23 January 2015 16:27:24 Arnd Bergmann wrote:
> On Friday 23 January 2015 16:21:49 Laurent Pinchart wrote:
> > +/**
> > + * arm_iommu_detach_device
> > + * @dev: valid struct device pointer
> > + *
> > + * Detaches the provided device from a previously attached map.
> > + * This voids the dma operations (dma_map_ops pointer)
> > + */
> > +void arm_iommu_detach_device(struct device *dev)
> > +{
> > + __arm_iommu_detach_device(dev);
> > + set_dma_ops(dev, NULL);
> > +}
> >
> > EXPORT_SYMBOL_GPL(arm_iommu_detach_device);
>
> Would this introduce a regression in the case where the device is
> cache coherent and needs arm_coherent_dma_ops set?
I think we need to handle that case (as well as the coherent IOMMU case in
arm_iommu_attach_device), but this patch only tries to restore the previous
behaviour to fix the bug detailed in the commit message. Would you prefer
fixing both issues in one go ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2015-01-23 15:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 14:21 [PATCH URGENT] arm: dma-mapping: Set DMA IOMMU ops in arm_iommu_attach_device() Laurent Pinchart
2015-01-23 14:21 ` Laurent Pinchart
[not found] ` <1422022909-31044-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2015-01-23 15:27 ` Arnd Bergmann
2015-01-23 15:27 ` Arnd Bergmann
2015-01-23 15:55 ` Laurent Pinchart [this message]
2015-01-23 15:55 ` Laurent Pinchart
2015-01-23 17:00 ` Arnd Bergmann
2015-01-23 17:00 ` Arnd Bergmann
2015-01-23 17:04 ` Will Deacon
2015-01-23 17:04 ` Will Deacon
2015-01-26 0:34 ` Heiko Stübner
2015-01-26 0:34 ` Heiko Stübner
2015-01-26 10:42 ` Joerg Roedel
2015-01-26 10:42 ` Joerg Roedel
2015-01-28 0:25 ` Heiko Stübner
2015-01-28 0:25 ` Heiko Stübner
2015-01-29 18:57 ` Olof Johansson
2015-01-29 18:57 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2416515.WUUq1g4kPD@avalon \
--to=laurent.pinchart-rylnwiuwjnjg/c1bvhzhaw@public.gmane.org \
--cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jroedel-l3A5Bk7waGM@public.gmane.org \
--cc=laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.