Re: [PATCH 7/7] ASoC: dt-bindings: ES8389: Add members about HPF and clock

[Krzysztof Kozlowski <krzk@kernel.org>]

On 15/06/2026 08:07, Zhang Yi wrote:
>>>>> +    $ref: /schemas/types.yaml#/definitions/flag
>>>>> +    description:
>>>>> +      Indicates that SCLK is used as the internal clock.
>>>>
>>>> And what happens with mclk in such case? Is it still wired?
>>>
>>> Yes, setting mclk-from-sclk does not affect the MCLK connection.
>>
>> I am asking about wiring of the device. If MCLK is used from SCLK, but
>> SCLK is used as the internal clock, then how can you still have MCLK
>> connected?
> 
> If MCLK is derived from SCLK, whether the 'MCLK' pin on the device is
> connected or not has no effect on operation.

If MCLK is connected, why would you derive it from SCLK? That's the
point - your clocks property already might be telling everything needed
here.

> 
>>>>> +
>>>>> +  everest,hpfl:
>>>>> +    $ref: /schemas/types.yaml#/definitions/uint8
>>>>> +    description:
>>>>> +      the HPF value of ADCL.
>>>>
>>>> Is HPF value in dB? If so, use proper unit suffix and proper units.
>>>
>>> No, the values here correspond to the values in the registers.
>>> The value is not in dB
>>
>> What are the meanings of the register values?
> 
> The value of everest,hpfl is equal to the value of the corresponding register,
> not the cutoff frequency of the HPF.

You keep avoiding answers.

I don't want you to encode standard units as register values.


Best regards,
Krzysztof