All of lore.kernel.org
 help / color / mirror / Atom feed
* libtirpc-0.3.1 fails to build with Heimdal Kerberos
@ 2015-06-05 12:18 Karl-Johan Karlsson
  2015-06-05 14:17 ` Chuck Lever
  0 siblings, 1 reply; 2+ messages in thread
From: Karl-Johan Karlsson @ 2015-06-05 12:18 UTC (permalink / raw)
  To: linux-nfs, Steve Dickson

Hi,

I'm trying to debug a build failure for libtirpc-0.3.1 with GSSAPI support 
when using Heimdal 1.5.3 as Kerberos provider. Downstream bug report is at 
https://bugs.gentoo.org/show_bug.cgi?id=551036

src/svc_auth_gss.c has an unconditional
   #include <gssapi/gssapi_ext.h>
but Heimdal doesn't ship that file; MIT-Krb5 does, though. It looks like most 
(but not all) of the functions that MIT-Krb5 declares in <gssapi/gssapi_ext.h> 
are declared in Heimdal by <gssapi/gssapi.h>.

src/svc_auth_gss.c has
   #ifdef HAVE_KRB5
and
   #elif HAVE_HEIMDAL
sections, but nothing I can see in the Autoconf system defines those. 
configure.ac does have
   AC_CHECK_HEADER([gssapi/gssapi.h], [HAVE_GSSAPI_H=yes], [HAVE_GSSAPI_H=no])
but that's just used internally in the configure script.

Would it be correct to export HAVE_GSSAPI_H and HAVE_GSSAPI_EXT_H to config.h 
and have src/svc_auth_gss.c include gssapi.h and/or gssapi_ext.h depending on 
them?

By the way, the link to the libtirpc gitweb on http://linux-nfs.org/wiki/index.php/Main_Page is broken. It points to http://git.linux-nfs.org/?p=steved/libtirpc.git;a=summary which is a 404.

-- 
Karl-Johan Karlsson

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: libtirpc-0.3.1 fails to build with Heimdal Kerberos
  2015-06-05 12:18 libtirpc-0.3.1 fails to build with Heimdal Kerberos Karl-Johan Karlsson
@ 2015-06-05 14:17 ` Chuck Lever
  0 siblings, 0 replies; 2+ messages in thread
From: Chuck Lever @ 2015-06-05 14:17 UTC (permalink / raw)
  To: Karl-Johan Karlsson; +Cc: Linux NFS Mailing List, Steve Dickson, libtirpc List


On Jun 5, 2015, at 8:18 AM, Karl-Johan Karlsson <creideiki+linux-nfs@lysator.liu.se> wrote:

> Hi,
> 
> I'm trying to debug a build failure for libtirpc-0.3.1 with GSSAPI support 
> when using Heimdal 1.5.3 as Kerberos provider. Downstream bug report is at 
> https://bugs.gentoo.org/show_bug.cgi?id=551036
> 
> src/svc_auth_gss.c has an unconditional
>   #include <gssapi/gssapi_ext.h>
> but Heimdal doesn't ship that file; MIT-Krb5 does, though. It looks like most 
> (but not all) of the functions that MIT-Krb5 declares in <gssapi/gssapi_ext.h> 
> are declared in Heimdal by <gssapi/gssapi.h>.
> 
> src/svc_auth_gss.c has
>   #ifdef HAVE_KRB5
> and
>   #elif HAVE_HEIMDAL
> sections, but nothing I can see in the Autoconf system defines those. 

Looks like that’s dead code. But it’s just a debugging message, so no harm.
Should be cleaned up, eventually.

> configure.ac does have
>   AC_CHECK_HEADER([gssapi/gssapi.h], [HAVE_GSSAPI_H=yes], [HAVE_GSSAPI_H=no])
> but that's just used internally in the configure script.
> 
> Would it be correct to export HAVE_GSSAPI_H and HAVE_GSSAPI_EXT_H to config.h 
> and have src/svc_auth_gss.c include gssapi.h and/or gssapi_ext.h depending on 
> them?

Using the HAVE_GSSAPI_* macros in src/*.c is just fine. You’ll have to introduce
an AC_CHECK for gssapi_ext.h in configure.ac.

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-06-05 14:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-05 12:18 libtirpc-0.3.1 fails to build with Heimdal Kerberos Karl-Johan Karlsson
2015-06-05 14:17 ` Chuck Lever

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.