* [PATCH v2] arm64: defconfig: Enable Rockchip UFS host driver
@ 2025-03-05 7:54 ` Shawn Lin
0 siblings, 0 replies; 8+ messages in thread
From: Shawn Lin @ 2025-03-05 7:54 UTC (permalink / raw)
To: Heiko Stuebner
Cc: linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski, Shawn Lin
Enable Rockchip UFS host driver.
This driver is first introduced on Rockchip RK3576 SoC, and will
be used for more SoCs in near future, so add it to defconfig
will make these platforms work better.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 3a3706d..907e92d 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1191,6 +1191,7 @@ CONFIG_SCSI_UFS_HISI=y
CONFIG_SCSI_UFS_RENESAS=m
CONFIG_SCSI_UFS_TI_J721E=m
CONFIG_SCSI_UFS_EXYNOS=y
+CONFIG_SCSI_UFS_ROCKCHIP=y
CONFIG_NEW_LEDS=y
CONFIG_LEDS_CLASS=y
CONFIG_LEDS_CLASS_MULTICOLOR=m
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2] arm64: defconfig: Enable Rockchip UFS host driver
@ 2025-03-05 7:54 ` Shawn Lin
0 siblings, 0 replies; 8+ messages in thread
From: Shawn Lin @ 2025-03-05 7:54 UTC (permalink / raw)
To: Heiko Stuebner
Cc: linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski, Shawn Lin
Enable Rockchip UFS host driver.
This driver is first introduced on Rockchip RK3576 SoC, and will
be used for more SoCs in near future, so add it to defconfig
will make these platforms work better.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 3a3706d..907e92d 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1191,6 +1191,7 @@ CONFIG_SCSI_UFS_HISI=y
CONFIG_SCSI_UFS_RENESAS=m
CONFIG_SCSI_UFS_TI_J721E=m
CONFIG_SCSI_UFS_EXYNOS=y
+CONFIG_SCSI_UFS_ROCKCHIP=y
CONFIG_NEW_LEDS=y
CONFIG_LEDS_CLASS=y
CONFIG_LEDS_CLASS_MULTICOLOR=m
--
2.7.4
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] arm64: defconfig: Enable Rockchip UFS host driver
2025-03-05 7:54 ` Shawn Lin
@ 2025-03-06 13:09 ` Heiko Stuebner
-1 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2025-03-06 13:09 UTC (permalink / raw)
To: Shawn Lin
Cc: Heiko Stuebner, linux-arm-kernel, linux-rockchip,
Krzysztof Kozlowski
On Wed, 05 Mar 2025 15:54:12 +0800, Shawn Lin wrote:
> Enable Rockchip UFS host driver.
>
> This driver is first introduced on Rockchip RK3576 SoC, and will
> be used for more SoCs in near future, so add it to defconfig
> will make these platforms work better.
>
>
> [...]
Applied, thanks!
[1/1] arm64: defconfig: Enable Rockchip UFS host driver
commit: 769c2b450b89b6a71ed614b7c507d17a84f52a4e
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] arm64: defconfig: Enable Rockchip UFS host driver
@ 2025-03-06 13:09 ` Heiko Stuebner
0 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2025-03-06 13:09 UTC (permalink / raw)
To: Shawn Lin
Cc: Heiko Stuebner, linux-arm-kernel, linux-rockchip,
Krzysztof Kozlowski
On Wed, 05 Mar 2025 15:54:12 +0800, Shawn Lin wrote:
> Enable Rockchip UFS host driver.
>
> This driver is first introduced on Rockchip RK3576 SoC, and will
> be used for more SoCs in near future, so add it to defconfig
> will make these platforms work better.
>
>
> [...]
Applied, thanks!
[1/1] arm64: defconfig: Enable Rockchip UFS host driver
commit: 769c2b450b89b6a71ed614b7c507d17a84f52a4e
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] arm64: defconfig: Enable Rockchip UFS host driver
2025-03-05 7:54 ` Shawn Lin
@ 2025-05-14 12:48 ` Diederik de Haas
-1 siblings, 0 replies; 8+ messages in thread
From: Diederik de Haas @ 2025-05-14 12:48 UTC (permalink / raw)
To: Shawn Lin, Heiko Stuebner
Cc: linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski
[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]
Hi,
I'm updating my own kernel config and have a question about this change.
On Wed Mar 5, 2025 at 8:54 AM CET, Shawn Lin wrote:
> Enable Rockchip UFS host driver.
>
> This driver is first introduced on Rockchip RK3576 SoC, and will
> be used for more SoCs in near future, so add it to defconfig
> will make these platforms work better.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 3a3706d..907e92d 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1191,6 +1191,7 @@ CONFIG_SCSI_UFS_HISI=y
> CONFIG_SCSI_UFS_RENESAS=m
> CONFIG_SCSI_UFS_TI_J721E=m
> CONFIG_SCSI_UFS_EXYNOS=y
> +CONFIG_SCSI_UFS_ROCKCHIP=y
Is there a particular reason why this is `=y` and not `=m`?
For SCSI_UFS_EXYNOS there is an explicit reason for `=y` in
5be91fe8d91b ("arm64: defconfig: Enable Exynos UFS driver")
(it won't detect (some?) UFS devices otherwise)
But this patch/commit doesn't say if/why it must be built-in.
Is there such a reason or is `=m` fine as well?
Cheers,
Diederik
> CONFIG_NEW_LEDS=y
> CONFIG_LEDS_CLASS=y
> CONFIG_LEDS_CLASS_MULTICOLOR=m
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] arm64: defconfig: Enable Rockchip UFS host driver
@ 2025-05-14 12:48 ` Diederik de Haas
0 siblings, 0 replies; 8+ messages in thread
From: Diederik de Haas @ 2025-05-14 12:48 UTC (permalink / raw)
To: Shawn Lin, Heiko Stuebner
Cc: linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski
[-- Attachment #1.1: Type: text/plain, Size: 1375 bytes --]
Hi,
I'm updating my own kernel config and have a question about this change.
On Wed Mar 5, 2025 at 8:54 AM CET, Shawn Lin wrote:
> Enable Rockchip UFS host driver.
>
> This driver is first introduced on Rockchip RK3576 SoC, and will
> be used for more SoCs in near future, so add it to defconfig
> will make these platforms work better.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 3a3706d..907e92d 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1191,6 +1191,7 @@ CONFIG_SCSI_UFS_HISI=y
> CONFIG_SCSI_UFS_RENESAS=m
> CONFIG_SCSI_UFS_TI_J721E=m
> CONFIG_SCSI_UFS_EXYNOS=y
> +CONFIG_SCSI_UFS_ROCKCHIP=y
Is there a particular reason why this is `=y` and not `=m`?
For SCSI_UFS_EXYNOS there is an explicit reason for `=y` in
5be91fe8d91b ("arm64: defconfig: Enable Exynos UFS driver")
(it won't detect (some?) UFS devices otherwise)
But this patch/commit doesn't say if/why it must be built-in.
Is there such a reason or is `=m` fine as well?
Cheers,
Diederik
> CONFIG_NEW_LEDS=y
> CONFIG_LEDS_CLASS=y
> CONFIG_LEDS_CLASS_MULTICOLOR=m
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] arm64: defconfig: Enable Rockchip UFS host driver
2025-05-14 12:48 ` Diederik de Haas
@ 2025-05-20 19:01 ` Heiko Stuebner
-1 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2025-05-20 19:01 UTC (permalink / raw)
To: Shawn Lin, Diederik de Haas
Cc: linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski
Am Mittwoch, 14. Mai 2025, 14:48:46 Mitteleuropäische Sommerzeit schrieb Diederik de Haas:
> Hi,
>
> I'm updating my own kernel config and have a question about this change.
>
> On Wed Mar 5, 2025 at 8:54 AM CET, Shawn Lin wrote:
> > Enable Rockchip UFS host driver.
> >
> > This driver is first introduced on Rockchip RK3576 SoC, and will
> > be used for more SoCs in near future, so add it to defconfig
> > will make these platforms work better.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> > ---
> >
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 3a3706d..907e92d 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1191,6 +1191,7 @@ CONFIG_SCSI_UFS_HISI=y
> > CONFIG_SCSI_UFS_RENESAS=m
> > CONFIG_SCSI_UFS_TI_J721E=m
> > CONFIG_SCSI_UFS_EXYNOS=y
> > +CONFIG_SCSI_UFS_ROCKCHIP=y
>
> Is there a particular reason why this is `=y` and not `=m`?
>
> For SCSI_UFS_EXYNOS there is an explicit reason for `=y` in
> 5be91fe8d91b ("arm64: defconfig: Enable Exynos UFS driver")
> (it won't detect (some?) UFS devices otherwise)
>
> But this patch/commit doesn't say if/why it must be built-in.
> Is there such a reason or is `=m` fine as well?
Most things are supposed to be modules. Though the on-soc mass-
storage devices get a bit of leniency ;-) .
I.e. defconfig is supposed to get you started, so not having to jump
through an initramfs to load the mmc of ufs module is helpful.
Heiko
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] arm64: defconfig: Enable Rockchip UFS host driver
@ 2025-05-20 19:01 ` Heiko Stuebner
0 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2025-05-20 19:01 UTC (permalink / raw)
To: Shawn Lin, Diederik de Haas
Cc: linux-arm-kernel, linux-rockchip, Krzysztof Kozlowski
Am Mittwoch, 14. Mai 2025, 14:48:46 Mitteleuropäische Sommerzeit schrieb Diederik de Haas:
> Hi,
>
> I'm updating my own kernel config and have a question about this change.
>
> On Wed Mar 5, 2025 at 8:54 AM CET, Shawn Lin wrote:
> > Enable Rockchip UFS host driver.
> >
> > This driver is first introduced on Rockchip RK3576 SoC, and will
> > be used for more SoCs in near future, so add it to defconfig
> > will make these platforms work better.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> > ---
> >
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 3a3706d..907e92d 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1191,6 +1191,7 @@ CONFIG_SCSI_UFS_HISI=y
> > CONFIG_SCSI_UFS_RENESAS=m
> > CONFIG_SCSI_UFS_TI_J721E=m
> > CONFIG_SCSI_UFS_EXYNOS=y
> > +CONFIG_SCSI_UFS_ROCKCHIP=y
>
> Is there a particular reason why this is `=y` and not `=m`?
>
> For SCSI_UFS_EXYNOS there is an explicit reason for `=y` in
> 5be91fe8d91b ("arm64: defconfig: Enable Exynos UFS driver")
> (it won't detect (some?) UFS devices otherwise)
>
> But this patch/commit doesn't say if/why it must be built-in.
> Is there such a reason or is `=m` fine as well?
Most things are supposed to be modules. Though the on-soc mass-
storage devices get a bit of leniency ;-) .
I.e. defconfig is supposed to get you started, so not having to jump
through an initramfs to load the mmc of ufs module is helpful.
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-05-20 19:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-05 7:54 [PATCH v2] arm64: defconfig: Enable Rockchip UFS host driver Shawn Lin
2025-03-05 7:54 ` Shawn Lin
2025-03-06 13:09 ` Heiko Stuebner
2025-03-06 13:09 ` Heiko Stuebner
2025-05-14 12:48 ` Diederik de Haas
2025-05-14 12:48 ` Diederik de Haas
2025-05-20 19:01 ` Heiko Stuebner
2025-05-20 19:01 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.