[PATCH] sched_ext: Fix missing @slice and @vtime descriptions in finish_dispatch() kernel-doc

[PATCH] sched_ext: Fix missing @slice and @vtime descriptions in finish_dispatch() kernel-doc

[luoliang]

From: Liang Luo <luoliang@kylinos.cn>

Commit 13f1eae3b662 ("sched_ext: Synchronize slice and dsq_vtime
writes") added the slice and vtime parameters to finish_dispatch() but
did not update its kernel-doc, which produces warnings:

  Warning: function parameter 'slice' not described in 'finish_dispatch'
  Warning: function parameter 'vtime' not described in 'finish_dispatch'

Describe both parameters using the same wording as
dispatch_to_local_dsq(), which receives the same values.

Signed-off-by: Liang Luo <luoliang@kylinos.cn>
---
 kernel/sched/ext/ext.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/sched/ext/ext.c b/kernel/sched/ext/ext.c
index 10af28a9f2c0..a40a6d73b413 100644
--- a/kernel/sched/ext/ext.c
+++ b/kernel/sched/ext/ext.c
@@ -2806,6 +2806,8 @@ static void dispatch_to_local_dsq(struct scx_sched *sch, struct rq *rq,
  * @p: task to finish dispatching
  * @qseq_at_dispatch: qseq when @p started getting dispatched
  * @dsq_id: destination DSQ ID
+ * @slice: slice carried by the insert verdict, 0 keeps the current value
+ * @vtime: vtime carried by the insert verdict, committed on PRIQ inserts
  * @enq_flags: %SCX_ENQ_*
  *
  * Dispatching to local DSQs may need to wait for queueing to complete or
-- 
2.25.1

Re: [PATCH] sched_ext: Fix missing @slice and @vtime descriptions in finish_dispatch() kernel-doc

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding kernel-doc descriptions for non-existent parameters `@slice` and `@vtime` causes an "Excess function parameter" kernel-doc warning.
--

--- Patch [1]: [PATCH] sched_ext: Fix missing @slice and @vtime descriptions in finish_dispatch() kernel-doc ---
commit 41530400fea7676e4713b34dcf07ebfd18e9b839
Author: Liang Luo <luoliang@kylinos.cn>

sched_ext: Fix missing @slice and @vtime descriptions in finish_dispatch() kernel-doc

This commit attempts to fix kernel-doc warnings by adding slice and vtime
parameter descriptions to the finish_dispatch() comment block.

> diff --git a/kernel/sched/ext/ext.c b/kernel/sched/ext/ext.c
> index 18183062f751c..84b2bb05ab90b 100644
> --- a/kernel/sched/ext/ext.c
> +++ b/kernel/sched/ext/ext.c
> @@ -2664,6 +2664,8 @@ static void dispatch_to_local_dsq(struct scx_sched *sch, struct rq *rq,
>   * @p: task to finish dispatching
>   * @qseq_at_dispatch: qseq when @p started getting dispatched
>   * @dsq_id: destination DSQ ID
> + * @slice: slice carried by the insert verdict, 0 keeps the current value
> + * @vtime: vtime carried by the insert verdict, committed on PRIQ inserts

[Severity: Low]
Will this trigger "Excess function parameter" kernel-doc warnings?

Looking at the code, finish_dispatch() does not appear to have slice or vtime
parameters in its signature:

static void finish_dispatch(struct scx_sched *sch, struct rq *rq,
                            struct task_struct *p,
                            unsigned long qseq_at_dispatch,
                            u64 dsq_id, u64 enq_flags)

>   * @enq_flags: %SCX_ENQ_*
>   *
>   * Dispatching to local DSQs may need to wait for queueing to complete or

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825055053.2295139-1-luoliang@kylinos.cn?part=1

Re: [PATCH] sched_ext: Fix missing @slice and @vtime descriptions in finish_dispatch() kernel-doc

[Liang Luo]

On Tue, Aug 25, 2026 at 05:58:49AM +0000, sashiko-bot@kernel.org wrote:
> Looking at the code, finish_dispatch() does not appear to have slice or
> vtime parameters in its signature:
> 
> static void finish_dispatch(struct scx_sched *sch, struct rq *rq,
>                             struct task_struct *p,
>                             unsigned long qseq_at_dispatch,
>                             u64 dsq_id, u64 enq_flags)

The review appears to be against a tree predating commit 13f1eae3b662
("sched_ext: Synchronize slice and dsq_vtime writes"), which added the
slice and vtime parameters to finish_dispatch(). In current mainline,
the signature is:

    static void finish_dispatch(struct scx_sched *sch, struct rq *rq,
                                struct task_struct *p,
                                unsigned long qseq_at_dispatch, u64 dsq_id,
                                u64 slice, u64 vtime, u64 enq_flags)

scripts/kernel-doc -none kernel/sched/ext/ext.c reports the two
"function parameter not described" warnings before this patch and
produces no warnings after it, so no "Excess function parameter"
warning is introduced.

Re: [PATCH] sched_ext: Fix missing @slice and @vtime descriptions in finish_dispatch() kernel-doc

[Tejun Heo]

Applied to sched_ext/for-7.3-fixes.

Thanks.

--
tejun