All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Viorel Suman <viorel.suman@oss.nxp.com>
Cc: Abel Vesa <abelvesa@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Viorel Suman <viorel.suman@nxp.com>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: Re: [PATCH 1/2] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0
Date: Fri, 16 Sep 2022 15:03:47 +0200	[thread overview]
Message-ID: <24402933.EfDdHjke4D@steina-w> (raw)
In-Reply-To: <20220916110936.jmxgjps5zrcndjxn@fsr-ub1664-116>

Hi Viorel,

added missing CC.

Am Freitag, 16. September 2022, 13:09:36 CEST schrieb Viorel Suman:
> On 22-09-16 08:30:46, Alexander Stein wrote:
> > Am Donnerstag, 15. September 2022, 20:18:04 CEST schrieb Viorel Suman 
(OSS):
> > > From: Viorel Suman <viorel.suman@nxp.com>
> > > 
> > > Sync defines with the latest available SCFW kit version 1.13.0,
> > > may be found at the address below:
> > > 
> > > https://www.nxp.com/webapp/Download?colCode=L5.15.32_2.0.0_SCFWKIT-1.13.
> > > 0&ap pType=license
> > > 
> > > Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> > > ---
> > > 
> > >  include/dt-bindings/firmware/imx/rsrc.h | 299 ++++++++++++++++--------
> > >  1 file changed, 203 insertions(+), 96 deletions(-)
> > 
> > This is not bisectable and breaks compilation, as this patch removes
> > symbols which are still used in drivers/clk/imx/clk-imx8qm-rsrc.c
> > (addressed in 2nd patch). IMHO this series should be squashed into one
> > patch.
> 
> Hi Alexander,
> 
> Thank you for review, you are right. Is sending a squashed v2 the usual
> approach in such case or shall I hope that the maintainer will squash them
> before push ? Just want to avoid unnecessary noise.

AFAIK maintainers will not squash patches. This is something you will need to 
do yourself. So sending a v2 seems right.
Also please keep all the other recipients on CC.

Best regards,
Alexander




WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Viorel Suman <viorel.suman@oss.nxp.com>
Cc: Abel Vesa <abelvesa@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Viorel Suman <viorel.suman@nxp.com>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: Re: [PATCH 1/2] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0
Date: Fri, 16 Sep 2022 15:03:47 +0200	[thread overview]
Message-ID: <24402933.EfDdHjke4D@steina-w> (raw)
In-Reply-To: <20220916110936.jmxgjps5zrcndjxn@fsr-ub1664-116>

Hi Viorel,

added missing CC.

Am Freitag, 16. September 2022, 13:09:36 CEST schrieb Viorel Suman:
> On 22-09-16 08:30:46, Alexander Stein wrote:
> > Am Donnerstag, 15. September 2022, 20:18:04 CEST schrieb Viorel Suman 
(OSS):
> > > From: Viorel Suman <viorel.suman@nxp.com>
> > > 
> > > Sync defines with the latest available SCFW kit version 1.13.0,
> > > may be found at the address below:
> > > 
> > > https://www.nxp.com/webapp/Download?colCode=L5.15.32_2.0.0_SCFWKIT-1.13.
> > > 0&ap pType=license
> > > 
> > > Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> > > ---
> > > 
> > >  include/dt-bindings/firmware/imx/rsrc.h | 299 ++++++++++++++++--------
> > >  1 file changed, 203 insertions(+), 96 deletions(-)
> > 
> > This is not bisectable and breaks compilation, as this patch removes
> > symbols which are still used in drivers/clk/imx/clk-imx8qm-rsrc.c
> > (addressed in 2nd patch). IMHO this series should be squashed into one
> > patch.
> 
> Hi Alexander,
> 
> Thank you for review, you are right. Is sending a squashed v2 the usual
> approach in such case or shall I hope that the maintainer will squash them
> before push ? Just want to avoid unnecessary noise.

AFAIK maintainers will not squash patches. This is something you will need to 
do yourself. So sending a v2 seems right.
Also please keep all the other recipients on CC.

Best regards,
Alexander




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-09-16 13:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 18:18 [PATCH 0/2] sync SCFW defines with SCFW kit v1.13.0 Viorel Suman (OSS)
2022-09-15 18:18 ` Viorel Suman (OSS)
2022-09-15 18:18 ` [PATCH 1/2] dt-bindings: firmware: imx: sync " Viorel Suman (OSS)
2022-09-15 18:18   ` Viorel Suman (OSS)
2022-09-16  6:30   ` Alexander Stein
2022-09-16  6:30     ` Alexander Stein
     [not found]     ` <20220916110936.jmxgjps5zrcndjxn@fsr-ub1664-116>
2022-09-16 13:03       ` Alexander Stein [this message]
2022-09-16 13:03         ` Alexander Stein
2022-09-16  7:43   ` Ahmad Fatoum
2022-09-16  7:43     ` Ahmad Fatoum
2022-09-16 10:36     ` Viorel Suman
2022-09-16 10:36       ` Viorel Suman
2022-09-16  9:38   ` Krzysztof Kozlowski
2022-09-16  9:38     ` Krzysztof Kozlowski
2022-09-16 10:17     ` Viorel Suman
2022-09-16 10:17       ` Viorel Suman
2022-09-16 10:30       ` Krzysztof Kozlowski
2022-09-16 10:30         ` Krzysztof Kozlowski
2022-09-15 18:18 ` [PATCH 2/2] clk: imx8qm: " Viorel Suman (OSS)
2022-09-15 18:18   ` Viorel Suman (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24402933.EfDdHjke4D@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=abelvesa@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=viorel.suman@nxp.com \
    --cc=viorel.suman@oss.nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.