From: Steve Grubb <sgrubb@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>, Paul Moore <pmoore@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH 1/2] errormsg: correct a number of messages that have drifted
Date: Thu, 04 May 2017 15:50:49 -0400 [thread overview]
Message-ID: <2449913.vTbGUtYPhj@x2> (raw)
In-Reply-To: <1491302268-797-1-git-send-email-rgb@redhat.com>
On Tuesday, April 4, 2017 6:37:47 AM EDT Richard Guy Briggs wrote:
> A number of error message descriptions have drifted from the conditions that
> caused them in audit_rule_fieldpair_data() including expansion of fields to
> be used by the user filter list, restriction to the exit list only and
> changing an operator to "equals" only. Correct these, using the new
> errormsg macros.
>
> See: https://github.com/linux-audit/audit-userspace/issues/12
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
This was hard to check because the first patch switch numbers to macros in
libaudit.c, but did not change them in the errormsg tab. It would have been
better to apply this first and then change to macros or change everything to
macros and then do this last. In any event, it's applied.
-Steve
next prev parent reply other threads:[~2017-05-04 19:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 10:37 [PATCH 1/2] errormsg: correct a number of messages that have drifted Richard Guy Briggs
2017-04-04 10:37 ` [PATCH 2/2] errormsg: add descriptive macros to replace overloaded error codes Richard Guy Briggs
2017-05-04 20:11 ` Steve Grubb
2017-05-04 20:29 ` Richard Guy Briggs
2017-05-04 20:49 ` Steve Grubb
2017-05-04 21:05 ` Richard Guy Briggs
2017-05-04 21:09 ` Steve Grubb
2017-05-08 13:52 ` Richard Guy Briggs
2017-05-24 20:02 ` Steve Grubb
2017-05-24 21:46 ` Richard Guy Briggs
2017-05-29 15:36 ` Richard Guy Briggs
2017-05-08 13:48 ` errormsg table macros [was: Re: [PATCH 2/2] errormsg: add descriptive macros to replace overloaded error codes] Richard Guy Briggs
2017-05-04 19:50 ` Steve Grubb [this message]
2017-05-04 20:25 ` [PATCH 1/2] errormsg: correct a number of messages that have drifted Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2449913.vTbGUtYPhj@x2 \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=pmoore@redhat.com \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.