From: Steve Grubb <sgrubb@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH 2/2] errormsg: add descriptive macros to replace overloaded error codes
Date: Wed, 24 May 2017 16:02:47 -0400 [thread overview]
Message-ID: <1894724.IJY7jiRZBU@x2> (raw)
In-Reply-To: <20170508135200.GY25861@madcap2.tricolour.ca>
On Monday, May 8, 2017 9:52:00 AM EDT Richard Guy Briggs wrote:
> > > Ok, so coming back to patch acceptance, if I read correctly your
> > > comments, reduce the four new error types to two?
> >
> > Yes, two are needed. One for missing filter/action and one for we are
> > attempting an incompatible comparison between fields.
>
> Ok, here you go:
> https://github.com/linux-audit/audit-userspace/pull/21
Was just going to look over this patch and now I see its not on the mail list.
This version looks fine. I kind of prefer patches sent to the mail list so
that any discussion is archived.
-Steve
next prev parent reply other threads:[~2017-05-24 20:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 10:37 [PATCH 1/2] errormsg: correct a number of messages that have drifted Richard Guy Briggs
2017-04-04 10:37 ` [PATCH 2/2] errormsg: add descriptive macros to replace overloaded error codes Richard Guy Briggs
2017-05-04 20:11 ` Steve Grubb
2017-05-04 20:29 ` Richard Guy Briggs
2017-05-04 20:49 ` Steve Grubb
2017-05-04 21:05 ` Richard Guy Briggs
2017-05-04 21:09 ` Steve Grubb
2017-05-08 13:52 ` Richard Guy Briggs
2017-05-24 20:02 ` Steve Grubb [this message]
2017-05-24 21:46 ` Richard Guy Briggs
2017-05-29 15:36 ` Richard Guy Briggs
2017-05-08 13:48 ` errormsg table macros [was: Re: [PATCH 2/2] errormsg: add descriptive macros to replace overloaded error codes] Richard Guy Briggs
2017-05-04 19:50 ` [PATCH 1/2] errormsg: correct a number of messages that have drifted Steve Grubb
2017-05-04 20:25 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1894724.IJY7jiRZBU@x2 \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.