Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Asus Tinker Board 3 and 3S device tree

["Heiko Stübner" <heiko@sntech.de>]

Am Samstag, 15. November 2025, 08:14:58 Mitteleuropäische Normalzeit schrieb Dragan Simic:
> Hello Michael,
> 
> On Saturday, November 15, 2025 07:03 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
> > On 11/15/25 01:53, Dragan Simic wrote:
> > > Thanks for the v2!  Please, see one nitpick below.
> > >
> > > On Friday, November 14, 2025 16:46 CET, michael.opdenacker@rootcommit.com wrote:
> > >> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> > > I'm sorry for not mentioning it in my earlier responses, but this
> > > line is redundant, because it duplicates the From value found in
> > > the actual email message.
> > 
> > This actually comes from my Git settings. I need this when I send 
> > patches to the Yocto project and OpenEmbedded. That's because their 
> > mailing list server which alters the address of senders ("<sender> via 
> > lists.yoctoproject.org"), and ultimately the commit author identity in 
> > Git. See 
> > https://docs.yoctoproject.org/contributor-guide/submit-changes.html#fixing-your-from-identity
> > 
> > I've checked that my patches apply fine and that this "From:" line 
> > doesn't appear in the commits in the tree.
> > So, can I keep this?

Yes you can keep that, I don't see a problem with that additional
From header.

> Actually, I forgot to mention that the From headers in your patch
> submissions are a bit wrong by containing just the email address,
> without the first and last name.  That issue should be fixed first,
> regardless of the presence (or absence) of From tags.
> 
> Thanks for clarifying what's the reason for having the From tags
> regardless of the actual need for having them.  Maybe setting Git's
> "format.from" option to true at the repository level could solve
> this nicely, while also exercising the Git-fu a bit? :)
> 
> BTW, my responses are currently jailed by the linux-rockchip mailing
> list, requiring manual approval, as a result of the mail server I'm
> using sometimes inserting some strange invisible UTF-8 characters
> into the email subjects.  Oh well. :)

I guess that mailserver needs a fix :-)


Heiko